• Kubernetes Submit Queue's avatar
    Merge pull request #62534 from nicolasbigler/duplicate-iptables-comment · 03c5f298
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Fix duplicate comment in iptables rule for non-local public-port rule
    
    **What this PR does / why we need it**:
    
    When kubernetes creates an iptable rule for "from-non-local public-port"
    rule the rule gets created with two identical comment section.
    
    The function `iptablesNonLocalNodePortArgs` creates a list of arguments
    for the rule from iptablesCommonPortalArgs function. This function
    already appends the arguments for the rules comments and therefore does
    not require appending the comment again.
    
    **Special notes for your reviewer**:
    
    I'm actually not a go programmer at all and have no idea how your tests work.
    I doubt that my fix will require adjustements on tests but I'm not 100% sure.
    If additional work is needed, I would be glad if someone could point it out to me so I can take care of it.
    
    **Release note**:
    ```release-note
    NONE
    ```
    03c5f298
Name
Last commit
Last update
..
apis/kubeproxyconfig Loading commit data...
config Loading commit data...
healthcheck Loading commit data...
iptables Loading commit data...
ipvs Loading commit data...
metrics Loading commit data...
userspace Loading commit data...
util Loading commit data...
winkernel Loading commit data...
winuserspace Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
doc.go Loading commit data...
endpoints.go Loading commit data...
endpoints_test.go Loading commit data...
service.go Loading commit data...
service_test.go Loading commit data...
types.go Loading commit data...