• Kubernetes Submit Queue's avatar
    Merge pull request #63143 from jsafrane/containerized-subpath · d2495b83
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 63348, 63839, 63143, 64447, 64567). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Containerized subpath
    
    **What this PR does / why we need it**:
    Containerized kubelet needs a different implementation of `PrepareSafeSubpath` than kubelet running directly on the host.
    
    On the host we safely open the subpath and then bind-mount `/proc/<pidof kubelet>/fd/<descriptor of opened subpath>`.
    
    With kubelet running in a container, `/proc/xxx/fd/yy` on the host contains path that works only inside the container, i.e. `/rootfs/path/to/subpath` and thus any bind-mount on the host fails.
    
    Solution:
    - safely open the subpath and gets its device ID and inode number
    - blindly bind-mount the subpath to `/var/lib/kubelet/pods/<uid>/volume-subpaths/<name of container>/<id of mount>`. This is potentially unsafe, because user can change the subpath source to a link to a bad place (say `/run/docker.sock`) just before the bind-mount.
    - get device ID and inode number of the destination. Typical users can't modify this file, as it lies on /var/lib/kubelet on the host.
    - compare these device IDs and inode numbers.
    
    **Which issue(s) this PR fixes**
    Fixes #61456
    
    **Special notes for your reviewer**:
    
    The PR contains some refactoring of `doBindSubPath` to extract the common code. New `doNsEnterBindSubPath` is added for the nsenter related parts.
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    d2495b83
Name
Last commit
Last update
..
async Loading commit data...
bandwidth Loading commit data...
config Loading commit data...
configz Loading commit data...
conntrack Loading commit data...
dbus Loading commit data...
ebtables Loading commit data...
env Loading commit data...
file Loading commit data...
filesystem Loading commit data...
flag Loading commit data...
flock Loading commit data...
goroutinemap Loading commit data...
hash Loading commit data...
initsystem Loading commit data...
interrupt Loading commit data...
io Loading commit data...
ipconfig Loading commit data...
ipset Loading commit data...
iptables Loading commit data...
ipvs Loading commit data...
keymutex Loading commit data...
labels Loading commit data...
limitwriter Loading commit data...
maps Loading commit data...
metrics Loading commit data...
mount Loading commit data...
net Loading commit data...
netsh Loading commit data...
node Loading commit data...
normalizer Loading commit data...
nsenter Loading commit data...
oom Loading commit data...
parsers Loading commit data...
pod Loading commit data...
pointer Loading commit data...
procfs Loading commit data...
reflector/prometheus Loading commit data...
removeall Loading commit data...
resizefs Loading commit data...
resourcecontainer Loading commit data...
rlimit Loading commit data...
selinux Loading commit data...
slice Loading commit data...
strings Loading commit data...
sysctl Loading commit data...
system Loading commit data...
tail Loading commit data...
taints Loading commit data...
template Loading commit data...
term Loading commit data...
threading Loading commit data...
tolerations Loading commit data...
version Loading commit data...
workqueue/prometheus Loading commit data...
BUILD Loading commit data...
verify-util-pkg.sh Loading commit data...