• Kubernetes Submit Queue's avatar
    Merge pull request #60106 from dashpole/cadvisor_godep · 6af07687
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 60106, 59510, 60263, 60063, 59088). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Update cadvisor godeps to v0.29.0 and ignore per-cpu metrics
    
    **What this PR does / why we need it**:
    Updates the cAdvisor dependency to the cAdvisor release associated with the kubernetes 1.10 release.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #60052
    
    **Special notes for your reviewer**:
    This PR also adds per-cpu metrics to the ignoreMetrics list.  This is a new metric that can be ignored in the most recent cAdvisor release.
    The reason for not collecting per-cpu metrics is that it can cause severe scalability issues.
    For example, if using a 128 core machine, and running 100 containers, we have 12800 different streams of metrics just for per-cpu metrics which cAdvisor needs to process and transmit.
    Additionally, per-cpu metrics are not used by any kubernetes components, and if a user needs these metrics, they can run cAdvisor as a daemonset. 
    
    **Release note**:
    ```release-note
    Disable per-cpu metrics by default for scalability.
    Fix inaccurate disk usage monitoring of overlayFs.
    Retry docker connection on startup timeout to avoid permanent loss of metrics.
    ```
    
    /assign @dchen1107
    6af07687
Name
Last commit
Last update
..
Godeps.json Loading commit data...
LICENSES Loading commit data...
OWNERS Loading commit data...
Readme Loading commit data...