• Kubernetes Submit Queue's avatar
    Merge pull request #60457 from sjenning/fix-websocket-e2e-test · 8c3b5541
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 60457, 60331, 54970, 58731, 60562). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    tests: e2e: empty msg from channel other than stdout should be non-fatal
    
    Currently, if the exec websocket encounters a message that is not in the stdout stream, it immediately fails.  However it also currently requests the stderr steam in the query params.  There doesn't seem to be any guarantee that we don't get an empty message on the stderr stream.
    
    Requesting the stderr stream in the query is desirable if, for some reason, something in the container fails and writes to stderr.
    
    However, we do not need fail the test if we get an empty message on another stream.  If the message is not empty, then that _does_ indicate and error and we should fail.
    
    This is the situation we are currently observing with docker 1.13 in the origin CI https://github.com/openshift/origin/issues/18726
    
    @derekwaynecarr @smarterclayton @gabemontero @liggitt @deads2k 
    
    /sig node
    8c3b5541
Name
Last commit
Last update
..
BUILD Loading commit data...
apparmor.go Loading commit data...
autoscaling_utils.go Loading commit data...
configmap.go Loading commit data...
configmap_volume.go Loading commit data...
container_probe.go Loading commit data...
docker_containers.go Loading commit data...
downward_api.go Loading commit data...
downwardapi_volume.go Loading commit data...
empty_dir.go Loading commit data...
events.go Loading commit data...
expansion.go Loading commit data...
host_path.go Loading commit data...
init_container.go Loading commit data...
kubelet_etc_hosts.go Loading commit data...
networking.go Loading commit data...
pods.go Loading commit data...
privileged.go Loading commit data...
projected.go Loading commit data...
secrets.go Loading commit data...
secrets_volume.go Loading commit data...
sysctl.go Loading commit data...
util.go Loading commit data...
volumes.go Loading commit data...