• Kubernetes Submit Queue's avatar
    Merge pull request #33376 from luxas/fix_arm_atomics_2 · 331eb835
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Move HighWaterMark to the top of the struct in order to fix arm, second time
    
    ref: #33117
    
    Sorry for not fixing everyone at once, but I seriously wasn't prepared for that quick LGTM 😄, so here's the other half.
    
    @lavalamp 
    
    > lgtm, but seriously, this is terrible, we probably have this bug all over. And what if someone embeds the etcdWatcher struct in something else not at the top? We need the compiler to enforce things like this, it just can't be done manually. Can you file or link a golang issue for this?
    
    I totally agree! There isn't currently a way of programmatically detecting this unfortunately.
    I guess @davecheney or @minux can explain better to you why it's so hard.
    
    This is noted in https://github.com/kubernetes/kubernetes/blob/master/docs/proposals/multi-platform.md as a corner case indeed.
    
    @pwittrock This should be cherrypicked toghether with #33117
    331eb835
Name
Last commit
Last update
..
etcd Loading commit data...
etcd3 Loading commit data...
storagebackend Loading commit data...
testing Loading commit data...
OWNERS Loading commit data...
cacher.go Loading commit data...
cacher_test.go Loading commit data...
doc.go Loading commit data...
errors.go Loading commit data...
interfaces.go Loading commit data...
util.go Loading commit data...
util_test.go Loading commit data...
watch_cache.go Loading commit data...
watch_cache_test.go Loading commit data...