• Kubernetes Submit Queue's avatar
    Merge pull request #51608 from cofyc/rbd_attach_detach · 90a35f1d
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 53730, 51608, 54459, 54534, 54585). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    RBD Plugin: Implement Attacher/Detacher interfaces.
    
    **What this PR does / why we need it**:
    
    This PR continues @rootfs 's work in #33660. It implements volume.Attacher/Volume.Detacher interfaces to resolve RBD image locking and makes RBD plugin more robust.
    
    Summary of interfaces and what they do for RBD plugin:
    
    - Attacher.Attach(): does nothing
    - Attacher.VolumesAreAttached(): method to query volume attach status
    - Attacher.GetDeviceMountPath(): method to get device mount path 
    - Attacher.WaitForAttach(): kubelet maps the image on the node (and lock the image if needed)
    - Attacher.MountDevice(): kubelet mounts device at the device mount path
    - Detacher.UnmountDevice: kubelet unmounts device from the device mount path (currently, we need to unmaps image from the node here) (and unlock the image if needed)
    - Detacher.Detach(): does nothing
    
    **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
    
    fixes #50142.
    
    **Special notes for your reviewer**:
    
    RBD changes:
    
      1) Modify rbdPlugin to implement volume.AttachableVolumePlugin interface.
      2) Add rbdAttacher/rbdDetacher structs to implement
      volume.Attacher/Detacher interfaces.
      3) Add mount.SafeFormatAndMount/mount.Exec fields to rbdPlugin, and setup them in
      rbdPlugin.Init for later uses. Attacher/Mounter/Unmounter/Detacher
      reference rbdPlugin to use mounter and exec. This simplifies
      code.
      4) Add testcase struct to abstract RBD Plugin test case, etc.
      5) Add newRBD constructor to unify rbd struct initialization.
    
    Non-RBD changes:
    
      1) Fix FakeMounter.IsLikelyNotMountPoint to return ErrNotExist if the
      directory does not exist. Mounter.IsLikelyNotMountPoint interface
      requires this, and RBD plugin depends on it.
      2) ~~Extend Detacher.Detach method to pass `*volume.Spec`, RBD plugin
      needs it to detach device from the node.~~
      3) ~~Extend Volume.Spec struct to include namespace string, RBD Plugin needs
      it to locate objects (e.g. secrets) in Pod's namespace.~~
      4) ~~Update RABC bootstrap policy to allow
      `system:controller:attachdetach-controller` cluster role to get
      Secrets object. RBD attach/detach needs to access secrets object in
      Pod's namespace.~~
    
    **Release note**:
    
    ```
    NONE
    ```
    90a35f1d
Name
Last commit
Last update
..
async Loading commit data...
bandwidth Loading commit data...
config Loading commit data...
configz Loading commit data...
dbus Loading commit data...
ebtables Loading commit data...
env Loading commit data...
file Loading commit data...
filesystem Loading commit data...
flock Loading commit data...
goroutinemap Loading commit data...
hash Loading commit data...
initsystem Loading commit data...
interrupt Loading commit data...
io Loading commit data...
ipconfig Loading commit data...
iptables Loading commit data...
ipvs Loading commit data...
keymutex Loading commit data...
labels Loading commit data...
limitwriter Loading commit data...
maps Loading commit data...
metrics Loading commit data...
mount Loading commit data...
net Loading commit data...
netsh Loading commit data...
node Loading commit data...
nsenter Loading commit data...
oom Loading commit data...
parsers Loading commit data...
pointer Loading commit data...
procfs Loading commit data...
reflector/prometheus Loading commit data...
removeall Loading commit data...
resourcecontainer Loading commit data...
rlimit Loading commit data...
selinux Loading commit data...
slice Loading commit data...
strings Loading commit data...
sysctl Loading commit data...
system Loading commit data...
tail Loading commit data...
taints Loading commit data...
template Loading commit data...
term Loading commit data...
threading Loading commit data...
tolerations Loading commit data...
version Loading commit data...
workqueue/prometheus Loading commit data...
BUILD Loading commit data...
verify-util-pkg.sh Loading commit data...