• k8s-merge-robot's avatar
    Merge pull request #29581 from Random-Liu/panic-if-cadvisor-not-started · ed3a29bd
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    Kubelet: Fail kubelet if cadvisor is not started.
    
    Fixes https://github.com/kubernetes/kubernetes/issues/28997.
    
    We started cadvisor in `sync.Do()`, which only run once no matter cadvisor successfully starts or not.
    
    Once it fails, kubelet will be stuck in a bad state. Kubelet could never start sync loop because there is an internal error, but kubelet would never retry starting cadvisor again.
    
    This PR just fails kubelet when cadvisor start fails, and then relies on the babysitter to restart kubelet.
    In the future, we may want to add backoff logic in the babysitter to protect the system.
    
    On the other hand, https://github.com/kubernetes/kubernetes/pull/29492 will fix cadvisor side to prevent cadvisor failing because of these kind of transient error.
    
    Mark P1 to match the original issue.
    
    @dchen1107 @vishh 
    ed3a29bd
Name
Last commit
Last update
..
admission Loading commit data...
api Loading commit data...
apimachinery Loading commit data...
apis Loading commit data...
apiserver Loading commit data...
auth Loading commit data...
capabilities Loading commit data...
client Loading commit data...
cloudprovider Loading commit data...
controller Loading commit data...
conversion Loading commit data...
credentialprovider Loading commit data...
dns Loading commit data...
fieldpath Loading commit data...
fields Loading commit data...
genericapiserver Loading commit data...
healthz Loading commit data...
httplog Loading commit data...
hyperkube Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
labels Loading commit data...
master Loading commit data...
metrics Loading commit data...
probe Loading commit data...
proxy Loading commit data...
quota Loading commit data...
registry Loading commit data...
runtime Loading commit data...
security Loading commit data...
securitycontext Loading commit data...
serviceaccount Loading commit data...
ssh Loading commit data...
storage Loading commit data...
types Loading commit data...
ui Loading commit data...
util Loading commit data...
version Loading commit data...
volume Loading commit data...
watch Loading commit data...
OWNERS Loading commit data...