• k8s-merge-robot's avatar
    Merge pull request #28228 from mtaufen/e2e-killcmd-cleanup · 480233c5
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    Use slices of items to clean up after tests
    
    Fixes #27582.
    
    We used to maintain a pointer variable for each process to kill after the
    tests finish. @lavalamp suggested using a slice instead, which is a much
    cleaner solution. This implements @lavalamp's suggestion and also extends
    the idea to tracking directories that need to be removed after the tests finish.
    
    This also means that we should no longer check for nil `killCmd`s inside
    `func (k *killCmd) Kill() error {...}` (see #27582 and #27589). If a nil
    `killCmd` makes it in there, something is bad elsewhere and we want to see
    the nil pointer exception immediately.
    
    Mentioning @timstclair and @euank wrt the original issue/PR. 
    480233c5
Name
Last commit
Last update
..
environment Loading commit data...
jenkins Loading commit data...
runner Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
configmap.go Loading commit data...
container.go Loading commit data...
container_list.go Loading commit data...
container_manager_test.go Loading commit data...
doc.go Loading commit data...
downward_api_test.go Loading commit data...
e2e_build.go Loading commit data...
e2e_node_suite_test.go Loading commit data...
e2e_remote.go Loading commit data...
e2e_service.go Loading commit data...
exec_util.go Loading commit data...
image.go Loading commit data...
image_conformance_test.go Loading commit data...
kubelet_test.go Loading commit data...
mirror_pod_test.go Loading commit data...
privileged_test.go Loading commit data...
runtime_conformance_test.go Loading commit data...
util.go Loading commit data...