• Kubernetes Submit Queue's avatar
    Merge pull request #43609 from Random-Liu/update-npd-rbac · 53d14e9a
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Update NPD rbac.
    
    I recently enabled NPD in gke.
    
    However, I found that in gke e2e test (https://k8s-testgrid.appspot.com/google-gke#gci-gke), npd on the node could not talk with apiserver, and reported full of following errors:
    ```
    E0324 05:08:26.745545    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
    E0324 05:08:37.719423    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
    E0324 05:08:47.719694    1328 manager.go:160] failed to update node conditions: the server does not allow access to the requested resource (patch nodes gke-bootstrap-e2e-default-pool-fd91d792-mqh4)
    ```
    
    I created a GKE cluster (v1.7.0-alpha.0.1483+1e879c69) myself, and found that addon manager could not create npd binding with the following error:
    ```
    error: error validating "/etc/kubernetes/addons/node-problem-detector/standalone/npd-binding.yaml": error validating data: couldn't find type: v1alpha1.ClusterRoleBinding; if you choose to ignore these errors, turn validation off with --validate=false
    ```
    
    I found that rbac was updated to beta, but npd was missed because it was merged after https://github.com/kubernetes/kubernetes/commit/9e6a3496b44e9a5ab9740cb903e46f769d65cde3#diff-b05c70853d9a772b310db71a61297841.
    
    I updated rbac to beta in the master manifest and npd on the node could talk with apiserver immediately.
    We must get this in 1.6 to make NPD working. @dchen1107 
    
    @dchen1107 @fabioy @liggitt
    53d14e9a
Name
Last commit
Last update
..
addons Loading commit data...
aws Loading commit data...
centos Loading commit data...
gce Loading commit data...
gke Loading commit data...
images Loading commit data...
juju Loading commit data...
kubemark Loading commit data...
lib Loading commit data...
libvirt-coreos Loading commit data...
local Loading commit data...
openstack-heat Loading commit data...
ovirt Loading commit data...
photon-controller Loading commit data...
rackspace Loading commit data...
saltbase Loading commit data...
skeleton Loading commit data...
ubuntu Loading commit data...
vagrant Loading commit data...
vsphere Loading commit data...
windows Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
clientbin.sh Loading commit data...
common.sh Loading commit data...
get-kube-binaries.sh Loading commit data...
get-kube-local.sh Loading commit data...
get-kube.sh Loading commit data...
kube-down.sh Loading commit data...
kube-push.sh Loading commit data...
kube-up.sh Loading commit data...
kube-util.sh Loading commit data...
kubeadm.sh Loading commit data...
kubectl.sh Loading commit data...
log-dump.sh Loading commit data...
options.md Loading commit data...
restore-from-backup.sh Loading commit data...
test-e2e.sh Loading commit data...
test-network.sh Loading commit data...
test-smoke.sh Loading commit data...
update-storage-objects.sh Loading commit data...
validate-cluster.sh Loading commit data...