• Kubernetes Submit Queue's avatar
    Merge pull request #38244 from MrHohn/e2e-reboot-drop · 81dd16a4
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 36419, 38330, 37718, 38244, 38375)
    
    Guarantees drop packets commands succeed in reboot test
    
    Fixes the main case in #33405 and #36230.
    Previous attempted fix in #38057.
    
    During the reboot test, the iptables command that was supposed to take the node offline failed to exec. 
    Turned out the xtables lock was holding by other processes led to this failure. Logs as below:
    ```
    I1202 20:00:29.686] Dec  2 20:00:29.685: INFO: ssh jenkins@146.148.111.167:22: stdout:
    "+ sleep 10
    + sudo iptables -I INPUT 1 -s 127.0.0.1 -j ACCEPT
    Another app is currently holding the xtables lock. Perhaps you want to use the -w option?"
    I1202 20:00:29.686] Dec  2 20:00:29.685: INFO: ssh jenkins@146.148.111.167:22: stderr:    ""
    I1202 20:00:29.686] Dec  2 20:00:29.685: INFO: ssh jenkins@146.148.111.167:22: exit code: 0
    ```
    
    This reboot test won't pass if any one of these iptables commands fails. This PR put "reboot" commands into while loops to guarantee it retries until succeed.
    
    `sudo iptables -t filter -nL` is removed since it is clear now that the `FILTER` rules won't be clobbered.
    
    (Tests passed on local cluster.)
    
    @bprashanth
    81dd16a4
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build-tools Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
vendor Loading commit data...
.gazelcfg.json Loading commit data...
.generated_docs Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
BUILD Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...