• Kubernetes Submit Queue's avatar
    Merge pull request #61833 from bart0sh/PR0008-kubelet-unknown-command · 7d57060d
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    check for commands in kubelet command line
    
    **What this PR does / why we need it**:
    
    Kubelet doesn't support subcommands and silently ignores them.
    This causes a lot of confusion among users, for example:
    
      Running 'kubelet logs' can produce this output:
    ```
        I0206 16:20:40.010949    5712 feature_gate.go:220] feature gates: &{{} map[]}
        I0206 16:20:40.011054    5712 controller.go:114] kubelet config controller: starting controller
        ...
        error: failed to run Kubelet: failed to create kubelet:
               misconfiguration: kubelet cgroup driver: "cgroupfs" is different from
               docker cgroup driver: "systemd"
    ```
    
    The output in this case looks like a valid log output. The error is not
    caused by incorrectly configured cgroup driver though. It's caused by
    the fact that kubelet ignores 'logs' subcommand, so 'kubelet logs' is
    essentially the same as 'kubelet': it runs kubelet with the default set
    of parameters, including default cgroup driver.
    
    **The fix**:
    Added check to prevent kubelet from running if user specifies
    subcommands in the command line.
    
    **Which issue(s) this PR fixes**:
    Fixes: kubeadm issue 639
    
    **Release note**:
    ```release-note
    NONE
    ```
    7d57060d
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.kazelcfg.json Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG-1.10.md Loading commit data...
CHANGELOG-1.11.md Loading commit data...
CHANGELOG-1.2.md Loading commit data...
CHANGELOG-1.3.md Loading commit data...
CHANGELOG-1.4.md Loading commit data...
CHANGELOG-1.5.md Loading commit data...
CHANGELOG-1.6.md Loading commit data...
CHANGELOG-1.7.md Loading commit data...
CHANGELOG-1.8.md Loading commit data...
CHANGELOG-1.9.md Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
SUPPORT.md Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...