• k8s-merge-robot's avatar
    Merge pull request #26936 from yifan-gu/fix_selinux · 7c4c19f6
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    rkt: Fix incomplete selinux context string when the option is partial.
    
    Fix "EmptyDir" e2e tests failures caused by #https://github.com/kubernetes/kubernetes/pull/24901
    
    As mentioned in https://github.com/kubernetes/kubernetes/pull/24901#discussion_r61372312
    We should apply the selinux context of the rkt data directory (/var/lib/rkt) when users do not specify all the selinux options.
    
    Due to my fault, the change was missed during rebase, thus caused the regression.
    
    After applying this PR, the e2e tests passed.
    ```
    $ go run hack/e2e.go -v -test --test_args="--ginkgo.dryRun=false --ginkgo.focus=EmptyDir"
    ...
    Ran 19 of 313 Specs in 199.319 seconds
    SUCCESS! -- 19 Passed | 0 Failed | 0 Pending | 294 Skipped PASS
    ```
    
    BTW, the test is removed because the `--no-overlay=true` flag will only be there on non-coreos distro.
    
    cc @euank @kubernetes/sig-node 
    7c4c19f6
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api/swagger-spec Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
contrib Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
release Loading commit data...
test Loading commit data...
third_party Loading commit data...
vendor Loading commit data...
www Loading commit data...
.generated_docs Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIB.md Loading commit data...
CONTRIBUTING.md Loading commit data...
DESIGN.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
code-of-conduct.md Loading commit data...