• Kubernetes Submit Queue's avatar
    Merge pull request #67316 from m1kola/67314_fix_regression · 4fff3523
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 66920, 67316, 67363, 67528, 66963). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Fixes regression in kubectl logs: the --all-containers=true option didn't work
    
    **What this PR does / why we need it**:
    
    Fixes regression introduced in #66398 and adds unit tests for logging with `--all-containers=true`. See #67314 for more details.
    
    **Which issue(s) this PR fixes**:
    Fixes #67314
    
    **Special notes for your reviewer**:
    
    I didn't cover cases with `coreinternal.PodList` and `coreinternal.Pod` in tests, because it doesn't look like we need them: I didn't manage to find any callers of the `logsForObjectWithClient` and `logsForObject` functions, so, probably, we can remove them. I'll double check and try to do that separately once this PR is merged.
    
    **Release note**:
    ```release-note
    NONE
    ```
    
    /sig cli
    4fff3523
Name
Last commit
Last update
..
apply Loading commit data...
apps Loading commit data...
cmd Loading commit data...
explain Loading commit data...
genericclioptions Loading commit data...
metricsutil Loading commit data...
plugins Loading commit data...
polymorphichelpers Loading commit data...
proxy Loading commit data...
scheme Loading commit data...
util Loading commit data...
validation Loading commit data...
.import-restrictions Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
apply.go Loading commit data...
autoscale.go Loading commit data...
autoscale_test.go Loading commit data...
clusterrolebinding.go Loading commit data...
clusterrolebinding_test.go Loading commit data...
conditions.go Loading commit data...
configmap.go Loading commit data...
configmap_test.go Loading commit data...
deployment.go Loading commit data...
deployment_test.go Loading commit data...
doc.go Loading commit data...
env_file.go Loading commit data...
env_file_test.go Loading commit data...
generate.go Loading commit data...
generate_test.go Loading commit data...
history.go Loading commit data...
history_test.go Loading commit data...
interfaces.go Loading commit data...
namespace.go Loading commit data...
namespace_test.go Loading commit data...
pdb.go Loading commit data...
pdb_test.go Loading commit data...
priorityclass.go Loading commit data...
priorityclass_test.go Loading commit data...
quota.go Loading commit data...
quota_test.go Loading commit data...
rolebinding.go Loading commit data...
rolebinding_test.go Loading commit data...
rollback.go Loading commit data...
rollback_test.go Loading commit data...
rolling_updater.go Loading commit data...
rolling_updater_test.go Loading commit data...
rollout_status.go Loading commit data...
rollout_status_test.go Loading commit data...
run.go Loading commit data...
run_test.go Loading commit data...
scale.go Loading commit data...
scale_test.go Loading commit data...
secret.go Loading commit data...
secret_for_docker_registry.go Loading commit data...
secret_for_docker_registry_test.go Loading commit data...
secret_for_tls.go Loading commit data...
secret_for_tls_test.go Loading commit data...
secret_test.go Loading commit data...
service.go Loading commit data...
service_basic.go Loading commit data...
service_basic_test.go Loading commit data...
service_test.go Loading commit data...
serviceaccount.go Loading commit data...
serviceaccount_test.go Loading commit data...
sorter.go Loading commit data...
sorter_test.go Loading commit data...