• k8s-merge-robot's avatar
    Merge pull request #29673 from pmorie/mount-collision · 1ae9b73c
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    Fix mount collision timeout issue
    
    Short- or medium-term workaround for #29555.  The root issue being fixed here is that the recent attach/detach work in the kubelet uses a unique volume name as a key that tracks the work that has to be done for each volume in a pod to attach/mount/umount/detach.  However, the non-attachable volume plugins do not report unique names for themselves, which causes collisions when a single secret or configmap is mounted multiple times in a pod.
    
    This is still a WIP -- I need to add a couple E2E tests that ensure that tests break in the future if there is a regression -- but posting for early review.
    
    cc @kubernetes/sig-storage 
    
    Ultimately, I would like to refine this a bit further.  A couple things I would like to change:
    
    1.  `GetUniqueVolumeName` should be a property ONLY of attachable volumes
    2.  I would like to see the kubelet apparatus for attach/mount/umount/detach handle non-attachable volumes specifically to avoid things like the `WaitForControllerAttach` call that has to be done for those volume types now
    1ae9b73c
Name
Last commit
Last update
..
component/scheduler/perf Loading commit data...
e2e Loading commit data...
e2e_node Loading commit data...
fixtures/pkg/kubectl/cmd/apply Loading commit data...
images Loading commit data...
integration Loading commit data...
kubemark Loading commit data...
soak Loading commit data...
utils Loading commit data...
.gitattributes Loading commit data...
OWNERS Loading commit data...
test_owners.csv Loading commit data...