• Kubernetes Submit Queue's avatar
    Merge pull request #47103 from madhusudancs/fed-ds-uncheck-label · b8b5c68c
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 43005, 46660, 46385, 46991, 47103)
    
    Ignore `daemonset-controller-hash` label key in federation before comparing the federated object with its cluster equivalent.
    
    Kubernetes daemonset controller writes a daemonset's hash to the object label as an optimization to avoid recomputing it every time. Adding a new label to the object that the federation is unaware of causes problems because federated controllers compare the objects in federation and their equivalents in clusters and try to reconcile them. This leads to a constant fight between the federated daemonset
    controller and the cluster controllers, and they never reach a stable state.
    
    Ideally, cluster components should not update an object's spec or metadata in a way federation cannot replicate. They can update an object's status though. Therefore, this daemonset hash should be a
    field in daemonset's status, not a label in object meta. @janetkuo says that this label is only a short term solution. In the near future, they are going to replace it with revision numbers in daemonset status. We
    can then rip this bandaid out.
    
    Fixes #46925
    
    **Release note**:
    ```release-note
    NONE
    ```
    
    /assign @csbell 
    
    /cc @shashidharatd @marun @nikhiljindal @perotinus 
    
    /sig federation
    b8b5c68c
Name
Last commit
Last update
..
apis Loading commit data...
client Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
deploy Loading commit data...
develop Loading commit data...
docs/api-reference Loading commit data...
manifests Loading commit data...
pkg Loading commit data...
plugin/pkg/admission/schedulingpolicy Loading commit data...
registry/cluster Loading commit data...
BUILD Loading commit data...
Makefile Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...