• Kubernetes Submit Queue's avatar
    Merge pull request #62874 from dcbw/dockershim-SetUpPod-cleanup-on-failure · 61892abc
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    dockershim/sandbox: clean up pod network even if SetUpPod() failed
    
    If the CNI network plugin completes successfully, but something fails
    between that success and dockerhsim's sandbox setup code, plugin resources
    may not be cleaned up. A non-trivial amount of code runs after the
    plugin itself exits and the CNI driver's SetUpPod() returns, and any error
    condition recognized by that code would cause this leakage.
    
    The Kubernetes CRI RunPodSandbox() request does not attempt to clean
    up on errors, since it cannot know how much (if any) networking
    was actually set up. It depends on the CRI implementation to do
    that cleanup for it.
    
    In the dockershim case, a SetUpPod() failure means networkReady is
    FALSE for the sandbox, and TearDownPod() will not be called later by
    garbage collection even though networking was configured, because
    dockershim can't know how far SetUpPod() got.
    
    Concrete examples include if the sandbox's container is somehow
    removed during during that time, or another OS error is encountered,
    or the plugin returns a malformed result to the CNI driver.
    
    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1532965
    
    ```release-note
    NONE
    ```
    61892abc
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.kazelcfg.json Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG-1.10.md Loading commit data...
CHANGELOG-1.11.md Loading commit data...
CHANGELOG-1.2.md Loading commit data...
CHANGELOG-1.3.md Loading commit data...
CHANGELOG-1.4.md Loading commit data...
CHANGELOG-1.5.md Loading commit data...
CHANGELOG-1.6.md Loading commit data...
CHANGELOG-1.7.md Loading commit data...
CHANGELOG-1.8.md Loading commit data...
CHANGELOG-1.9.md Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
SUPPORT.md Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...