• Kubernetes Submit Queue's avatar
    Merge pull request #54237 from lichuqiang/apimachinery_fix · 52d87de1
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 52717, 54568, 54452, 53997, 54237). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Fix bug in func OnError() of apimachinery in case time moves backwards for any reason
    
    **What this PR does / why we need it**:
    in func OnError() of ErrorHandlers in apimachinery
    ```
    func (r *rudimentaryErrorBackoff) OnError(error) {
    	r.lastErrorTimeLock.Lock()
    	defer r.lastErrorTimeLock.Unlock()
    	d := time.Since(r.lastErrorTime)
    	if d < 0 {
    		time.Sleep(r.minPeriod - d)
    	}
    	r.lastErrorTime = time.Now()
    }
    ```
    it is expected to go on sleep for some time if not meet the minPeriod. However, if time happens hops to the past in the process. `d := time.Since(r.lastErrorTime)` would be a negative number, thus, it may sleep a lot longer than we expected.
    
    The period for sleep should be reseted if time hops
    
    **Which issue this PR fixes**
     fixes #54236
    
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    52d87de1
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.kazelcfg.json Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG-1.2.md Loading commit data...
CHANGELOG-1.3.md Loading commit data...
CHANGELOG-1.4.md Loading commit data...
CHANGELOG-1.5.md Loading commit data...
CHANGELOG-1.6.md Loading commit data...
CHANGELOG-1.7.md Loading commit data...
CHANGELOG-1.8.md Loading commit data...
CHANGELOG-1.9.md Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
SUPPORT.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...