• Kubernetes Submit Queue's avatar
    Merge pull request #56550 from andyzhangx/error-info-createshare · 528f0451
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 56337, 56546, 56550, 56633, 56635). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    fix incorrect error info when creating an azure file PVC failed
    
    **What this PR does / why we need it**:
    when creating an azure file PVC failed, it will always return following error which is totally incorrect:
    ```
    Failed to provision volume with StorageClass "azurefile-premium": failed to find a matching storage account
    ```
    The incorrect error info would mislead customer a lot, I would suggest return error directly if create first file share failed.
    
    By this PR, the error info would be like following, which would provide user detailed and **correct** info:
    ```
    Events:
      Type     Reason              Age               From                         Message
      ----     ------              ----              ----                         -------
      Warning  ProvisioningFailed  13s                  persistentvolume-controller  Failed to provision volume with StorageClass "azurefile-premium": failed to create share andy-k8s182-dynamic-pvc-cd66f4bd-d4c4-11e7-9f09-000d3a019e90 in account 00mqk6lqaouexy6agnt0: failed to create file share, err: Put https://00mqk6lqaouexy6agnt0.file.core.windows.net/andy-k8s182-dynamic-pvc-cd66f4bd-d4c4-11e7-9f09-000d3a019e90?restype=share: dial tcp: lookup 00mqk6lqaouexy6agnt0.file.core.windows.net on 168.63.129.16:53: no such host
    ```
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #56548
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```
    none
    ```
    /sig azure
    /assign @rootfs
    528f0451
Name
Last commit
Last update
..
api Loading commit data...
apis Loading commit data...
auth Loading commit data...
bootstrap/api Loading commit data...
capabilities Loading commit data...
client Loading commit data...
cloudprovider Loading commit data...
controller Loading commit data...
credentialprovider Loading commit data...
features Loading commit data...
fieldpath Loading commit data...
generated Loading commit data...
kubeapiserver Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
master Loading commit data...
printers Loading commit data...
probe Loading commit data...
proxy Loading commit data...
quota Loading commit data...
registry Loading commit data...
routes Loading commit data...
security Loading commit data...
securitycontext Loading commit data...
serviceaccount Loading commit data...
ssh Loading commit data...
util Loading commit data...
version Loading commit data...
volume Loading commit data...
watch Loading commit data...
.import-restrictions Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...