• k8s-merge-robot's avatar
    Merge pull request #28379 from deads2k/allow-late-joins · 4ee877c2
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    allow handler to join after the informer has started
    
    This allows an event handler to join after a SharedInformer has started.  It can't add any indexes, but it can add its reaction functions.
    
    This works by 
     1. stopping the flow of events from the reflector (thus stopping updates to our store)
     1. registering the new handler
     1. sending synthetic "add" events to the new handler only
     1. unblocking the flow of events
    
    It would be possible to 
     1. block
     1. list
     1. add recorder
     1. unblock
     1. play list to as-yet unregistered handler
     1. block
     1. remove recorder
     1. play recording
     1. add new handler
     1. unblock
    
    But that is considerably more complicated.  I'd rather not start there since this ought to be the exception rather than the rule.
    
    @wojtek-t who requested this power in the initial review
    @smarterclayton @liggitt I think this resolves our all-in-one ordering problem.
    @hongchaodeng since this came up on the call
    4ee877c2
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api/swagger-spec Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
contrib Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
release Loading commit data...
test Loading commit data...
third_party Loading commit data...
vendor Loading commit data...
www Loading commit data...
.generated_docs Loading commit data...
.gitignore Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIB.md Loading commit data...
CONTRIBUTING.md Loading commit data...
DESIGN.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
code-of-conduct.md Loading commit data...