• Kubernetes Submit Queue's avatar
    Merge pull request #48394 from smarterclayton/must_serialize_if_data_differs · 4ae3b032
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 48439, 48440, 48394)
    
    GuaranteedUpdate must write if stored data is not canonical
    
    An optimization added to the GuaranteedUpdate loop changed the
    comparison of the current objects serialization against the stored data,
    instead comparing to the in memory object, which defeated the mechanism
    we use to migrate stored data (GET then PUT should update the version stored in etcd if the canonical serialization has changed)
    
    This commit preserves that optimization but correctly verifies the in
    memory serialization against the on disk serialization by fetching the
    latest serialized data. Since most updates are not no-ops, this should
    not regress the performance of the normal path.
    
    Fixes #48393
    
    ```release-note
    When performing a GET then PUT, the kube-apiserver must write the canonical representation of the object to etcd if the current value does not match. That allows external agents to migrate content in etcd from one API version to another, across different storage types, or across varying encryption levels. This fixes a bug introduced in 1.5 where we unintentionally stopped writing the newest data.
    ```
    4ae3b032
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.gazelcfg.json Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...