• Kubernetes Submit Queue's avatar
    Merge pull request #62462 from jsafrane/private-mount-propagation · 92065407
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 60476, 62462, 61391, 62535, 62394). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Private mount propagation
    
    This PR changes the default mount propagation from "rslave" (newly added in 1.10) to "private" (default in 1.9 and before). "rslave" as default causes regressions, see below.
    
    Value `"None"` has to be added to `MountPropagationMode` enum in API ("I don't want any propagation at all"), which translates to "private" on Linux. [We did not have use cases for it](https://github.com/kubernetes/community/pull/659#discussion_r131454319), but we have them now.
    
    **Which issue(s) this PR fixes**
    Fixes #62397, fixes #62396
    
    **Special notes for your reviewer**:
    CRI already has an option for private mount propagation in volumes, however it's called "PRIVATE", while Kubernetes API value is "None". I did not change PRIVATE to NONE to keep the interface stable. See `kubelet_pods.go`.
    
    **Release note**:
    ```release-note
    Default mount propagation has changed from "HostToContainer" ("rslave" in Linux terminology) to "None" ("private") to match the behavior in 1.9 and earlier releases. "HostToContainer" as a default caused regressions in some pods.
    ```
    
    
    /sig storage
    /sig node
    92065407
Name
Last commit
Last update
..
apimachinery Loading commit data...
apps Loading commit data...
auth Loading commit data...
autoscaling Loading commit data...
chaosmonkey Loading commit data...
common Loading commit data...
framework Loading commit data...
generated Loading commit data...
instrumentation Loading commit data...
kubectl Loading commit data...
lifecycle Loading commit data...
manifest Loading commit data...
network Loading commit data...
node Loading commit data...
perftype Loading commit data...
scalability Loading commit data...
scheduling Loading commit data...
servicecatalog Loading commit data...
storage Loading commit data...
testing-manifests Loading commit data...
ui Loading commit data...
upgrades Loading commit data...
BUILD Loading commit data...
README.md Loading commit data...
e2e-example-config.json Loading commit data...
e2e.go Loading commit data...
e2e_test.go Loading commit data...
examples.go Loading commit data...
gke_local_ssd.go Loading commit data...
gke_node_pools.go Loading commit data...