• Kubernetes Submit Queue's avatar
    Merge pull request #64274 from neolit123/kubeadm-alpha-phase-addon · 046619f3
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 64308, 64367, 64165, 64274). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    kubeadm: rename the `kube-dns` phases addon
    
    **What this PR does / why we need it**:
    The command `kubeadm alpha phases addon` has a property
    called `kube-dns` which would install kube-dns, pre 1.11.
    
    In the case of 1.11 this property will install CoreDNS,
    because the property is also bound to the `CoreDNS` feature gate,
    which is now `true` by default.
    
    Fix that by renaming the property to `coredns`, updating the Cobra
    info and also updating the unit tests.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes https://github.com/kubernetes/kubeadm/issues/856
    
    **Special notes for your reviewer**:
    Please verify if we are OK with the "hard rename".
    
    **Release note**:
    
    ```release-note
    kubeadm: rename the addon parameter `kube-dns` to `coredns` for `kubeadm alpha phases addons` as CoreDNS is now the default DNS server in 1.11.
    ```
    
    @kubernetes/sig-cluster-lifecycle-pr-reviews 
    /area kubeadm
    046619f3
Name
Last commit
Last update
..
clicheck Loading commit data...
cloud-controller-manager Loading commit data...
controller-manager Loading commit data...
gendocs Loading commit data...
genkubedocs Loading commit data...
genman Loading commit data...
genswaggertypedocs Loading commit data...
genutils Loading commit data...
genyaml Loading commit data...
hyperkube Loading commit data...
importverifier Loading commit data...
kube-apiserver Loading commit data...
kube-controller-manager Loading commit data...
kube-proxy Loading commit data...
kube-scheduler Loading commit data...
kubeadm Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
linkcheck Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...