• Kubernetes Submit Queue's avatar
    Merge pull request #50583 from liggitt/endpoints-empty-noop · 402e48b0
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 49869, 47987, 50211, 50804, 50583)
    
    Make endpoints controller update based on semantic equality
    
    Fixes #50828
    Split from https://github.com/kubernetes/kubernetes/pull/45294 for separate review
    
    Currently, endpoints objects containing no subsets are decoded by the go client as subsets:[] (when requested individually) or as subsets:null (when requested in a list of endpoints).
    
    Because the endpoints controller is fed via a lister/watcher, it gets the `subsets:null` version fed to it. The subsets computation then returns an empty slice, which fails reflect.DeepEqual, which triggers a write attempt.
    
    This PR makes the comparison use semantic.DeepEqual to avoid spurious writes.
    
    https://github.com/kubernetes/kubernetes/pull/45294 would remove the inconsistency between lists and individual gets.
    402e48b0
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
translations Loading commit data...
vendor Loading commit data...
.bazelrc Loading commit data...
.generated_files Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.kazelcfg.json Loading commit data...
BUILD.bazel Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIBUTING.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
OWNERS_ALIASES Loading commit data...
README.md Loading commit data...
SUPPORT.md Loading commit data...
Vagrantfile Loading commit data...
WORKSPACE Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...