• Kubernetes Submit Queue's avatar
    Merge pull request #49025 from danwinship/non-cloud-node-ip · b91f1918
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 50537, 49699, 50160, 49025, 50205)
    
    When not using a CloudProvider, set both InternalIP and ExternalIP on Nodes
    
    #36095 changed all of the cloudproviders to set both InternalIP and ExternalIP on Nodes, but the non-cloudprovider fallback code now only sets InternalIP.
    
    This causes the test "should be able to create a functioning NodePort service" in test/e2e/service.go to fail on cloud-provider-less clusters, because (with LegacyHostIP gone), it now will only try to work with ExternalIPs, and will fail if the node has only an InternalIP.
    
    There isn't much other code that assumes that ExternalIP will always be set (there's something in pkg/master/master.go, but I don't know what it's doing, so maybe it's only useful in the case where InternalIP != ExternalIP anyway). But given that several of the cloudproviders (mesos, ovirt, rackspace) now explicitly set both InternalIP and ExternalIP to the same value always, it seemed right to do that in the fallback case too.
    
    @deads2k FYI
    
    **Release note**:
    ```release-note
    NONE
    ```
    b91f1918
Name
Last commit
Last update
..
e2e Loading commit data...
e2e_federation Loading commit data...
e2e_node Loading commit data...
fixtures Loading commit data...
images Loading commit data...
integration Loading commit data...
kubemark Loading commit data...
list Loading commit data...
soak Loading commit data...
utils Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
test_owners.csv Loading commit data...
test_owners.json Loading commit data...