• Kubernetes Submit Queue's avatar
    Merge pull request #64216 from misterikkit/nil-or-empty · 2a18b026
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 64174, 64187, 64216, 63265, 64223). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Do not use DeepEqual to compare slices in test.
    
    This wraps DeepEqual with a helper that considers nil slices and empty
    slices to be equal.
    
    Scheduler code might use a nil slice or empty slice to represent an
    empty list, so tests should not be sensitive to the difference.  Tests
    could fail because DeepEqual considers nil to be different from an empty
    slice.
    
    
    
    **What this PR does / why we need it**:
    Avoid breaking tests in cases where application behavior is not changed.
    
    **Special notes for your reviewer**:
    This brittle test keeps breaking in a number of my PRs. Hoping to get this fix merged independently.
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    
    /sig scheduling
    /kind cleanup
    2a18b026
Name
Last commit
Last update
..
api Loading commit data...
apis Loading commit data...
auth Loading commit data...
capabilities Loading commit data...
client Loading commit data...
cloudprovider Loading commit data...
controller Loading commit data...
credentialprovider Loading commit data...
features Loading commit data...
fieldpath Loading commit data...
generated Loading commit data...
kubeapiserver Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
master Loading commit data...
printers Loading commit data...
probe Loading commit data...
proxy Loading commit data...
quota Loading commit data...
registry Loading commit data...
routes Loading commit data...
scheduler Loading commit data...
security Loading commit data...
securitycontext Loading commit data...
serviceaccount Loading commit data...
ssh Loading commit data...
util Loading commit data...
version Loading commit data...
volume Loading commit data...
watch/json Loading commit data...
windows/service Loading commit data...
.import-restrictions Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...