• Kubernetes Submit Queue's avatar
    Merge pull request #66082 from sjenning/fix-is-critical-checks · 0a284c1c
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    move feature gate checks inside IsCriticalPod
    
    Currently `IsCriticalPod()` calls throughout the code are protected by `utilfeature.DefaultFeatureGate.Enabled(features.ExperimentalCriticalPodAnnotation)`.
    
    However, with Pod Priority, this gate could be disabled which skips the priority check inside IsCriticalPod().
    
    This PR moves the feature gate checking inside `IsCriticalPod()` and handles both situations properly.
    
    @aveshagarwal @ravisantoshgudimetla @derekwaynecarr 
    /sig node
    /sig scheduling
    /king bug
    0a284c1c
Name
Last commit
Last update
..
util Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
daemon_controller.go Loading commit data...
daemon_controller_test.go Loading commit data...
doc.go Loading commit data...
update.go Loading commit data...
update_test.go Loading commit data...