• Kubernetes Submit Queue's avatar
    Merge pull request #66799 from noqcks/master · f3b98a08
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
    
    Add validation for kube-scheduler configuration options
    
    **What this PR does / why we need it**: This adds validation to the kube-scheduler so that we're not accepting bogus values to the kube-scheduler. As requested by @bsalamat in issue https://github.com/kubernetes/kubernetes/issues/66743
    
    **Which issue(s) this PR fixes**:
    Fixes #66743
    
    **Special notes for your reviewer**:
    - Not sure if this validation is too heavy handed. Would love some feedback. 
    - I started working on this before I realized @islinwb was also working on this same problem... https://github.com/kubernetes/kubernetes/pull/66787 I put this PR up anyways since I'm sure good code exists in both. I wasn't aware of the /assign command so didn't assign myself before starting work. 
    - I didn't have time to work on adding validation to deprecated cli options. If the rest of this looks ok, I can finish that up.
    - I hope the location of IsValidSocketAddr is correct. Lmk if it isn't. 
    
    **Release note**:
    ```release-note
    Adding validation to kube-scheduler at the API level
    ```
    f3b98a08
Name
Last commit
Last update
..
src Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...