• Kubernetes Submit Queue's avatar
    Merge pull request #51087 from oracle/for/upstream/master/ccm-instance-exists · 27fbb68f
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 51174, 51363, 51087, 51382, 51388)
    
    Add InstanceExistsByProviderID to cloud provider interface for CCM
    
    **What this PR does / why we need it**:
    
    Currently, [`MonitorNode()`](https://github.com/kubernetes/kubernetes/blob/02b520f0a40be2056d91fc0661c2b4fdb2694c30/pkg/controller/cloud/nodecontroller.go#L240) in the node controller checks with the CCM if a node still exists by calling `ExternalID(nodeName)`. `ExternalID` is supposed to return the provider id of a node which is not supported on every cloud. This means that any clouds who cannot infer the provider id by the node name from a remote location will never remove nodes that no longer exist. 
    
    
    **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50985
    
    **Special notes for your reviewer**:
    
    We'll want to create a subsequent issue to track the implementation of these two new methods in the cloud providers.
    
    **Release note**:
    
    ```release-note
    Adds `InstanceExists` and `InstanceExistsByProviderID` to cloud provider interface for the cloud controller manager
    ```
    
    /cc @wlan0 @thockin @andrewsykim @luxas @jhorwit2
    
    /area cloudprovider
    /sig cluster-lifecycle
    27fbb68f
Name
Last commit
Last update
..
providers Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
cloud.go Loading commit data...
doc.go Loading commit data...
plugins.go Loading commit data...