• Kubernetes Submit Queue's avatar
    Merge pull request #56483 from dixudx/fix_cli_attach_format · 5f920426
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 57127, 57011, 56754, 56601, 56483). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    fix bad output format for attaching pods
    
    **What this PR does / why we need it**:
    If the user wants to attach stdin, wants a TTY, and `o.In` is a terminal, `t.Raw` is set to true, which is causing bad format like #56450.
    
    We should avoid print extra logs in `SafeFunc`. Move it outer.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #56450
    
    **Special notes for your reviewer**:
    /assign @thockin @kubernetes/sig-cli-bugs  
    
    **Release note**:
    
    ```release-note
    None
    ```
    5f920426
Name
Last commit
Last update
..
auth Loading commit data...
config Loading commit data...
resource Loading commit data...
rollout Loading commit data...
set Loading commit data...
templates Loading commit data...
testdata/edit Loading commit data...
testing Loading commit data...
util Loading commit data...
BUILD Loading commit data...
alpha.go Loading commit data...
annotate.go Loading commit data...
annotate_test.go Loading commit data...
apiversions.go Loading commit data...
apply.go Loading commit data...
apply_edit_last_applied.go Loading commit data...
apply_set_last_applied.go Loading commit data...
apply_test.go Loading commit data...
apply_view_last_applied.go Loading commit data...
attach.go Loading commit data...
attach_test.go Loading commit data...
autoscale.go Loading commit data...
certificates.go Loading commit data...
clusterinfo.go Loading commit data...
clusterinfo_dump.go Loading commit data...
clusterinfo_dump_test.go Loading commit data...
cmd.go Loading commit data...
cmd_test.go Loading commit data...
completion.go Loading commit data...
convert.go Loading commit data...
convert_test.go Loading commit data...
cp.go Loading commit data...
cp_test.go Loading commit data...
create.go Loading commit data...
create_clusterrole.go Loading commit data...
create_clusterrole_test.go Loading commit data...
create_clusterrolebinding.go Loading commit data...
create_clusterrolebinding_test.go Loading commit data...
create_configmap.go Loading commit data...
create_configmap_test.go Loading commit data...
create_deployment.go Loading commit data...
create_deployment_test.go Loading commit data...
create_namespace.go Loading commit data...
create_namespace_test.go Loading commit data...
create_pdb.go Loading commit data...
create_pdb_test.go Loading commit data...
create_priorityclass.go Loading commit data...
create_priorityclass_test.go Loading commit data...
create_quota.go Loading commit data...
create_quota_test.go Loading commit data...
create_role.go Loading commit data...
create_role_test.go Loading commit data...
create_rolebinding.go Loading commit data...
create_rolebinding_test.go Loading commit data...
create_secret.go Loading commit data...
create_secret_test.go Loading commit data...
create_service.go Loading commit data...
create_service_test.go Loading commit data...
create_serviceaccount.go Loading commit data...
create_serviceaccount_test.go Loading commit data...
create_test.go Loading commit data...
delete.go Loading commit data...
delete_test.go Loading commit data...
describe.go Loading commit data...
describe_test.go Loading commit data...
diff.go Loading commit data...
diff_test.go Loading commit data...
drain.go Loading commit data...
drain_test.go Loading commit data...
edit.go Loading commit data...
edit_test.go Loading commit data...
exec.go Loading commit data...
exec_test.go Loading commit data...
explain.go Loading commit data...
expose.go Loading commit data...
expose_test.go Loading commit data...
help.go Loading commit data...
label.go Loading commit data...
label_test.go Loading commit data...
logs.go Loading commit data...
logs_test.go Loading commit data...
options.go Loading commit data...
patch.go Loading commit data...
patch_test.go Loading commit data...
plugin.go Loading commit data...
plugin_test.go Loading commit data...
portforward.go Loading commit data...
portforward_test.go Loading commit data...
proxy.go Loading commit data...
replace.go Loading commit data...
replace_test.go Loading commit data...
rollingupdate.go Loading commit data...
rollingupdate_test.go Loading commit data...
run.go Loading commit data...
run_test.go Loading commit data...
scale.go Loading commit data...
taint.go Loading commit data...
taint_test.go Loading commit data...
top.go Loading commit data...
top_node.go Loading commit data...
top_node_test.go Loading commit data...
top_pod.go Loading commit data...
top_pod_test.go Loading commit data...
top_test.go Loading commit data...
version.go Loading commit data...