• hui luo's avatar
    While reviewing devicemanager code, found · 7101c174
    hui luo authored
    the caching layer on endpoint is redundant.
    
    Here are the 3 related objects in picture:
    devicemanager <-> endpoint <-> plugin
    
    Plugin is the source of truth for devices
    and device health status.
    
    devicemanager maintain healthyDevices,
    unhealthyDevices, allocatedDevices based on updates
    from plugin.
    
    So there is no point for endpoint caching devices,
    this patch is removing this caching layer on endpoint,
    
    Also removing the Manager.Devices() since i didn't
    find any caller of this other than test, i am adding a
    notification channel to facilitate testing,
    
    If we need to get all devices from manager in future,
    it just need to return healthyDevices + unhealthyDevices,
    we don't have to call endpoint after all.
    
    This patch makes code more readable, data model been simplified.
    7101c174
Name
Last commit
Last update
..
apis Loading commit data...
cadvisor Loading commit data...
certificate Loading commit data...
checkpoint Loading commit data...
checkpointmanager Loading commit data...
client Loading commit data...
cloudresource Loading commit data...
cm Loading commit data...
config Loading commit data...
configmap Loading commit data...
container Loading commit data...
custommetrics Loading commit data...
dockershim Loading commit data...
envvars Loading commit data...
events Loading commit data...
eviction Loading commit data...
images Loading commit data...
kubeletconfig Loading commit data...
kuberuntime Loading commit data...
leaky Loading commit data...
lifecycle Loading commit data...
logs Loading commit data...
metrics Loading commit data...
mountpod Loading commit data...
network Loading commit data...
nodestatus Loading commit data...
pleg Loading commit data...
pod Loading commit data...
preemption Loading commit data...
prober Loading commit data...
qos Loading commit data...
remote Loading commit data...
secret Loading commit data...
server Loading commit data...
stats Loading commit data...
status Loading commit data...
sysctl Loading commit data...
token Loading commit data...
types Loading commit data...
util Loading commit data...
volumemanager Loading commit data...
winstats Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...
active_deadline.go Loading commit data...
active_deadline_test.go Loading commit data...
doc.go Loading commit data...
kubelet.go Loading commit data...
kubelet_getters.go Loading commit data...
kubelet_getters_test.go Loading commit data...
kubelet_network.go Loading commit data...
kubelet_network_test.go Loading commit data...
kubelet_node_status.go Loading commit data...
kubelet_node_status_test.go Loading commit data...
kubelet_pods.go Loading commit data...
kubelet_pods_test.go Loading commit data...
kubelet_pods_windows_test.go Loading commit data...
kubelet_resources.go Loading commit data...
kubelet_resources_test.go Loading commit data...
kubelet_test.go Loading commit data...
kubelet_volumes.go Loading commit data...
kubelet_volumes_test.go Loading commit data...
oom_watcher.go Loading commit data...
oom_watcher_test.go Loading commit data...
pod_container_deletor.go Loading commit data...
pod_container_deletor_test.go Loading commit data...
pod_workers.go Loading commit data...
pod_workers_test.go Loading commit data...
reason_cache.go Loading commit data...
reason_cache_test.go Loading commit data...
runonce.go Loading commit data...
runonce_test.go Loading commit data...
runtime.go Loading commit data...
util.go Loading commit data...
volume_host.go Loading commit data...