• k8s-merge-robot's avatar
    Merge pull request #27762 from xiangpengzhao/fix-port-range · 5f766748
    k8s-merge-robot authored
    Automatic merge from submit-queue
    
    Fix port range checking, port should not be greater than 65535.
    
    When passing flag `--proxy-port-range` to kube-proxy with an invalid range which is greater than 65535, the proxy doesn't exit. That's not what we want.
    
    Should we fix this in v1.3?
    /cc @thockin @mikedanese @resouer 
    
    Before fixing:
    ```
    root@vm:/home/paas/zxp# kube-proxy --master=172.16.1.11:8080 --logtostderr=false --log-dir=/home/user/log/kube --proxy-port-range=65536-65599 &
    [6] 6671
    root@vm:/home/paas/zxp# ps -ef | grep kube-proxy
    root      6671 13507  0 03:48 pts/1    00:00:00 kube-proxy --master=172.16.1.11:8080 --logtostderr=false --log-dir=/home/user/log/kube --proxy-port-range=65536-65599
    ```
    
    After:
    ```
    root@vm:/home/paas/zxp# kube-proxy --master=172.16.1.11:8080 --logtostderr=false --log-dir=/home/user/log/kube --proxy-port-range=65536-65599 &
    [6] 6725
    root@vm:/home/paas/zxp# invalid argument "65536-65599" for --proxy-port-range=65536-65599: "65536-65599" is not a valid port range: the port range cannot be greater than 65535: 65536-65599
    ..............
    [6]+  Exit 2                  kube-proxy --master=172.16.1.11:8080 --logtostderr=false --log-dir=/home/user/log/kube --proxy-port-range=65536-65599
    ```
    ```
    root@vm:/home/paas/zxp# kube-proxy --master=172.16.1.11:8080 --logtostderr=false --log-dir=/home/user/log/kube --proxy-port-range=6000-65599 &
    [6] 6732
    root@vm:/home/paas/zxp# invalid argument "6000-65599" for --proxy-port-range=6000-65599: "6000-65599" is not a valid port range: the port range cannot be greater than 65535: 6000-65599
    ..............
    [6]+  Exit 2                  kube-proxy --master=172.16.1.11:8080 --logtostderr=false --log-dir=/home/user/log/kube --proxy-port-range=6000-65599
    ```
    5f766748
Name
Last commit
Last update
..
bandwidth Loading commit data...
cache Loading commit data...
certificates Loading commit data...
chmod Loading commit data...
chown Loading commit data...
codeinspector Loading commit data...
config Loading commit data...
configz Loading commit data...
crlf Loading commit data...
crypto Loading commit data...
dbus Loading commit data...
diff Loading commit data...
env Loading commit data...
errors Loading commit data...
exec Loading commit data...
flag Loading commit data...
flock Loading commit data...
flowcontrol Loading commit data...
flushwriter Loading commit data...
framer Loading commit data...
goroutinemap Loading commit data...
hash Loading commit data...
homedir Loading commit data...
httpstream Loading commit data...
integer Loading commit data...
interrupt Loading commit data...
intstr Loading commit data...
io Loading commit data...
iptables Loading commit data...
json Loading commit data...
jsonpath Loading commit data...
keymutex Loading commit data...
labels Loading commit data...
limitwriter Loading commit data...
metrics Loading commit data...
mount Loading commit data...
net Loading commit data...
node Loading commit data...
oom Loading commit data...
parsers Loading commit data...
pod Loading commit data...
procfs Loading commit data...
proxy Loading commit data...
rand Loading commit data...
replicaset Loading commit data...
runtime Loading commit data...
selinux Loading commit data...
sets Loading commit data...
slice Loading commit data...
strategicpatch Loading commit data...
strings Loading commit data...
sysctl Loading commit data...
system Loading commit data...
term Loading commit data...
testing Loading commit data...
threading Loading commit data...
validation Loading commit data...
wait Loading commit data...
workqueue Loading commit data...
wsstream Loading commit data...
yaml Loading commit data...
clock.go Loading commit data...
clock_test.go Loading commit data...
doc.go Loading commit data...
line_delimiter.go Loading commit data...
line_delimiter_test.go Loading commit data...
logs.go Loading commit data...
resource_container_linux.go Loading commit data...
resource_container_unsupported.go Loading commit data...
runner.go Loading commit data...
runner_test.go Loading commit data...
string_flag.go Loading commit data...
template.go Loading commit data...
template_test.go Loading commit data...
trace.go Loading commit data...
umask.go Loading commit data...
umask_windows.go Loading commit data...
util.go Loading commit data...
util_test.go Loading commit data...
uuid.go Loading commit data...