• Kubernetes Submit Queue's avatar
    Merge pull request #62903 from cofyc/fixfsgroupcheckinlocal · 186dd7be
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 62657, 63278, 62903, 63375). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    Add more volume types in e2e and fix part of them.
    
    **What this PR does / why we need it**:
    
    - Add dir-link/dir-bindmounted/dir-link-bindmounted/bockfs volume types for e2e tests.
    - Fix fsGroup related e2e tests partially.
    - Return error if we cannot resolve volume path.
      - Because we should not fallback to volume path, if it's a symbolic link, we may get wrong results.
    
    To safely set fsGroup on local volume, we need to implement these two methods correctly for all volume types both on the host and in container:
    
    - get volume path kubelet can access
      - paths on the host and in container are different
    - get mount references
      - for directories, we cannot use its mount source (device field) to identify mount references, because directories on same filesystem have same mount source (e.g. tmpfs), we need to check filesystem's major:minor and directory root path on it
    
    Here is current status:
    
    | | (A) volume-path (host) | (B) volume-path (container) | (C) mount-refs (host) | (D) mount-refs (container) |
    | --- | --- | --- | --- | --- |
    | (1) dir | OK | FAIL | FAIL | FAIL |
    | (2) dir-link | OK | FAIL | FAIL | FAIL |
    | (3) dir-bindmounted | OK | FAIL | FAIL | FAIL |
    | (4) dir-link-bindmounted | OK | FAIL | FAIL | FAIL |
    | (5) tmpfs| OK | FAIL | FAIL | FAIL |
    | (6) blockfs| OK | FAIL | OK | FAIL |
    | (7) block| NOTNEEDED | NOTNEEDED | NOTNEEDED | NOTNEEDED |
    | (8) gce-localssd-scsi-fs| NOTTESTED | NOTTESTED | NOTTESTED | NOTTESTED |
    
    - This PR uses `nsenter ... readlink` to resolve path in container as @msau42  @jsafrane [suggested](https://github.com/kubernetes/kubernetes/pull/61489#pullrequestreview-110032850). This fixes B1:B6 and D6, , the rest will be addressed in https://github.com/kubernetes/kubernetes/pull/62102.
    - C5:D5 marked `FAIL` because `tmpfs` filesystems can share same mount source, we cannot rely on it to check mount references. e2e tests passes due to we use unique mount source string in tests.
    - A7:D7 marked `NOTNEEDED` because we don't set fsGroup on block devices in local plugin. (TODO: Should we set fsGroup on block device?)
    - A8:D8 marked `NOTTESTED` because I didn't test it, I leave it to `pull-kubernetes-e2e-gce`. I think it should be same as `blockfs`.
    
    **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
    Fixes #
    
    **Special notes for your reviewer**:
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    186dd7be
Name
Last commit
Last update
..
async Loading commit data...
bandwidth Loading commit data...
config Loading commit data...
configz Loading commit data...
conntrack Loading commit data...
dbus Loading commit data...
ebtables Loading commit data...
env Loading commit data...
file Loading commit data...
filesystem Loading commit data...
flag Loading commit data...
flock Loading commit data...
goroutinemap Loading commit data...
hash Loading commit data...
initsystem Loading commit data...
interrupt Loading commit data...
io Loading commit data...
ipconfig Loading commit data...
ipset Loading commit data...
iptables Loading commit data...
ipvs Loading commit data...
keymutex Loading commit data...
labels Loading commit data...
limitwriter Loading commit data...
maps Loading commit data...
metrics Loading commit data...
mount Loading commit data...
net Loading commit data...
netsh Loading commit data...
node Loading commit data...
normalizer Loading commit data...
nsenter Loading commit data...
oom Loading commit data...
parsers Loading commit data...
pointer Loading commit data...
procfs Loading commit data...
reflector/prometheus Loading commit data...
removeall Loading commit data...
resizefs Loading commit data...
resourcecontainer Loading commit data...
rlimit Loading commit data...
selinux Loading commit data...
slice Loading commit data...
strings Loading commit data...
sysctl Loading commit data...
system Loading commit data...
tail Loading commit data...
taints Loading commit data...
template Loading commit data...
term Loading commit data...
threading Loading commit data...
tolerations Loading commit data...
version Loading commit data...
workqueue/prometheus Loading commit data...
BUILD Loading commit data...
verify-util-pkg.sh Loading commit data...