• Kubernetes Submit Queue's avatar
    Merge pull request #32620 from Random-Liu/refactor-e2e-services · 13126e51
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Node E2E: Cleanup e2e services
    
    fixes #31765.
    
    This PR is composed of 2 commits:
    * The 1st commit split services.go into: `services.go`, `server.go` and `internal_services.go`:
      * `services.go` contains the public object `E2EServices` which is used by the test framework directly.
      * `internal_services.go` contains the internal object `e2eServices` which manages internal (statically-linked) services - apiserver, etcd and namespace_controller.
      * `server.go` is the object managing exec process, both internal_services and kubelet are running as separate processes and managed with server.go.
    * The 2nd commit added `monitorParent` option in start function of `E2EServices`. This is added to fix #31765:
      * If `--stop-services=true`, `monitorParent` will be true, so that service processes will die with the parent process so as to enforce proper clean up.
      * If `--stop-services=false`, `monitorParent` will be false, so that service processes will not die with the parent process and keep running for debugging.
    
    This PR also moved the kubelet start logic into `E2EServices` (start kubelet in the test process), so that we can use flags directly when starting kubelet. Before we had to pass them to the services process and let it start kubelet, which was quite troublesome.
    
    @vishh 
    /cc @kubernetes/sig-node
    13126e51
Name
Last commit
Last update
.github Loading commit data...
Godeps Loading commit data...
api/swagger-spec Loading commit data...
build Loading commit data...
cluster Loading commit data...
cmd Loading commit data...
contrib Loading commit data...
docs Loading commit data...
examples Loading commit data...
federation Loading commit data...
hack Loading commit data...
hooks Loading commit data...
logo Loading commit data...
pkg Loading commit data...
plugin Loading commit data...
staging Loading commit data...
test Loading commit data...
third_party Loading commit data...
vendor Loading commit data...
www Loading commit data...
.generated_docs Loading commit data...
.gitignore Loading commit data...
CHANGELOG.md Loading commit data...
CONTRIB.md Loading commit data...
CONTRIBUTING.md Loading commit data...
DESIGN.md Loading commit data...
LICENSE Loading commit data...
Makefile Loading commit data...
Makefile.generated_files Loading commit data...
OWNERS Loading commit data...
README.md Loading commit data...
Vagrantfile Loading commit data...
code-of-conduct.md Loading commit data...
labels.yaml Loading commit data...