• Kubernetes Submit Queue's avatar
    Merge pull request #61833 from bart0sh/PR0008-kubelet-unknown-command · 7d57060d
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
    
    check for commands in kubelet command line
    
    **What this PR does / why we need it**:
    
    Kubelet doesn't support subcommands and silently ignores them.
    This causes a lot of confusion among users, for example:
    
      Running 'kubelet logs' can produce this output:
    ```
        I0206 16:20:40.010949    5712 feature_gate.go:220] feature gates: &{{} map[]}
        I0206 16:20:40.011054    5712 controller.go:114] kubelet config controller: starting controller
        ...
        error: failed to run Kubelet: failed to create kubelet:
               misconfiguration: kubelet cgroup driver: "cgroupfs" is different from
               docker cgroup driver: "systemd"
    ```
    
    The output in this case looks like a valid log output. The error is not
    caused by incorrectly configured cgroup driver though. It's caused by
    the fact that kubelet ignores 'logs' subcommand, so 'kubelet logs' is
    essentially the same as 'kubelet': it runs kubelet with the default set
    of parameters, including default cgroup driver.
    
    **The fix**:
    Added check to prevent kubelet from running if user specifies
    subcommands in the command line.
    
    **Which issue(s) this PR fixes**:
    Fixes: kubeadm issue 639
    
    **Release note**:
    ```release-note
    NONE
    ```
    7d57060d
Name
Last commit
Last update
..
clicheck Loading commit data...
cloud-controller-manager Loading commit data...
controller-manager Loading commit data...
gendocs Loading commit data...
genkubedocs Loading commit data...
genman Loading commit data...
genswaggertypedocs Loading commit data...
genutils Loading commit data...
genyaml Loading commit data...
hyperkube Loading commit data...
importverifier Loading commit data...
kube-apiserver Loading commit data...
kube-controller-manager Loading commit data...
kube-proxy Loading commit data...
kube-scheduler Loading commit data...
kubeadm Loading commit data...
kubectl Loading commit data...
kubelet Loading commit data...
kubemark Loading commit data...
linkcheck Loading commit data...
BUILD Loading commit data...
OWNERS Loading commit data...