• Kubernetes Submit Queue's avatar
    Merge pull request #31651 from Random-Liu/move-host-info-around-test-result · 3b404bd2
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue
    
    Node E2E: Move host info around test result.
    
    Discussed offline with @yujuhong and @dchen1107. Currently, the node e2e result is organized as:
    ```
    ================================================================
    Success Finished Host tmp-node-e2e-b6c375c7-e2e-node-containervm-v20160321-image Test Suite
    {ginkgo-output}
    {framework-error}
    ================================================================
    ```
    This makes it painful to find which image the test is failing on. The `{ginkgo-output}` is usually quite long, so we have to scroll mouse up and down to find the host name.
    This PR changes the test result to:
    ```
    ================================================================
    Start Host tmp-node-e2e-b6c375c7-e2e-node-containervm-v20160321-image Test Suite
    {ginkgo-output}
    Success Finished Host tmp-node-e2e-b6c375c7-e2e-node-containervm-v20160321-image Test Suite
    {framework-error}
    ================================================================
    ```
    This is not perfect, but much better than before. We can easily find the host name under the ginkgo test result, like this:
    ```
    ================================================================
    Start Host test-gci-dev-54-8743-3-0 Test Suite
    Running Suite: E2eNode Suite
    ============================
    Random Seed: 1472511489 - Will randomize all specs
    Will run 0 of 131 specs
    
    Running in parallel across 8 nodes
    
    I0829 22:58:13.727764    1143 e2e_node_suite_test.go:98] Pre-pulling images so that they are cached for the tests.
    I0829 22:58:28.562459    1143 e2e_node_suite_test.go:111] Node services started.  Running tests...
    I0829 22:58:28.562477    1143 e2e_node_suite_test.go:116] Wait for the node to be ready
    
    SSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSSS
    ------------------------------
    I0829 22:58:29.742596    1143 e2e_node_suite_test.go:136] Stopping node services...
    I0829 22:58:29.742650    1143 services.go:673] Killing process 1423 (services) with -TERM
    I0829 22:58:29.860893    1143 e2e_node_suite_test.go:141] Tests Finished
    
    
    Ran 0 of 131 Specs in 16.185 seconds
    SUCCESS! -- 0 Passed | 0 Failed | 0 Pending | 131 Skipped 
    
    Ginkgo ran 1 suite in 19.939034297s
    Test Suite Passed
    
    Success Finished Host test-gci-dev-54-8743-3-0 Test Suite
    ================================================================
    ```
    
    In a following PR, I'll print the test result from different images into different files to make it more clear for debugging. Mark v1.4 because this helps us de-flake test.
    
    /cc @kubernetes/sig-node
    3b404bd2
Name
Last commit
Last update
..
local Loading commit data...
remote Loading commit data...