• Kubernetes Submit Queue's avatar
    Merge pull request #45923 from verult/cxing/NodeStatusUpdaterFix · c34b359b
    Kubernetes Submit Queue authored
    Automatic merge from submit-queue (batch tested with PRs 46383, 45645, 45923, 44884, 46294)
    
    Node status updater now deletes the node entry in attach updates...
    
    … when node is missing in NodeInformer cache.
    
    - Added RemoveNodeFromAttachUpdates as part of node status updater operations.
    
    
    
    **What this PR does / why we need it**: Fixes issue of unnecessary node status updates when node is deleted.
    
    **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #42438
    
    **Special notes for your reviewer**: Unit tested added, but a more comprehensive test involving the attach detach controller requires certain testing functionality that is currently absent, and will require larger effort. Will be added at a later time.
    
    There is an edge case caused by the following steps:
    1) A node is deleted and restarted. The node exists, but is not yet recognized by Kubernetes.
    2) A pod requiring a volume attach with nodeName specifically set to this node.
    
    This would make the pod stuck in ContainerCreating state. This is low-pri since it's a specific edge case that can be avoided.
    
    **Release note**:
    
    ```release-note
    NONE
    ```
    c34b359b
Name
Last commit
Last update
..
BUILD Loading commit data...
actual_state_of_world.go Loading commit data...
actual_state_of_world_test.go Loading commit data...
desired_state_of_world.go Loading commit data...
desired_state_of_world_test.go Loading commit data...