- 05 Jan, 2018 5 commits
-
-
Pengfei Ni authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix bug of swallowing missing merge key error The bug is caused by variable shadowing. Fixes #57834 ```release-note NONE ``` /assign @liggitt
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Bump pause container used by kubelet and tests to 3.1 This updates the version of the pause container used by the kubelet and various test utilities to 3.1. **What this PR does / why we need it**: The pause container hasn't been rebuilt in quite a while and needs an update to reap zombies (#50865) and for schema2 manifest (#56253). **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #50865, Fixes #56253 **Special notes for your reviewer**: **Release note**: ```release-note The kubelet uses a new release 3.1 of the pause container with the Docker runtime. This version will clean up orphaned zombie processes that it inherits. ```
-
ymqytw authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Honor make variable OUT_DIR in hyperkube Makefile Needed to ensure the split of `make cross-in-a-container` and `make package-tarballs` honors the use of `OUT_DIR`. In the new and upcoming containerized (GCB) release builds, multiple `cross-in-a-container` targets are run into their own `_output ($OUT_DIR)` directories and a second pass runs multiple `package-tarballs`. This won't work unless we honor `$OUT_DIR` here. See also #23839 cc @javier-b-perez
-
- 04 Jan, 2018 35 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix typo **What this PR does / why we need it**: fix typos in pkg/kubeapiserver/default_storage_factory_builder.go **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: tiny fix typo **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57021, 56843, 54983). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Optimizing the implementation of the error check for PriorityClass **What this PR does / why we need it**: When i create pod(on the bottom) with not exist PriorityClass, the output will be shown as follow: ``` # kubectl apply -f priorityclassname-pod.yaml Error from server: error when creating "priorityclassname-pod.yaml": failed to get default priority class not-exist-priorityclassname: priorityclass.scheduling.k8s.io "not-exist-priorityclassname" not found ``` In my eyes, "get default priority class" is not the correct description, so i changed it. The new output will be shown like this: ``` # kubectl apply -f priorityclassname-pod.yaml Error from server (NotFound): error when creating "priorityclassname-pod.yaml": priorityclass.scheduling.k8s.io "not-exist-priorityclassname" not found ``` In addition, the 'pc' will never be nil when err is nil, i think this check is not neccessary, so i removed it. thank you! Pod template: ``` apiVersion: v1 kind: Pod metadata: name: priorityclassname-pod labels: env: priorityclassname-pod spec: containers: - name: was image: gcr.io/google_containers/busybox:v1.0 imagePullPolicy: IfNotPresent priorityClassName: not-exist-priorityclassname ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57021, 56843, 54983). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [PSP] always check validated policy first for update operation When update a pod with `kubernetes.io/psp` annotation set, we should check this policy first. Because this saved policy is `usually` the one we are looking for. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. delete the unused function in kubectl **What this PR does / why we need it**: delete some unused code in `kubctl`
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56315, 57846). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix ExternalAddress parsing problem under IPv6 **What this PR does / why we need it**: `!strings.Contains(host, ":") ` will fail miserably under ipv6 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Record volumeID in GlusterFS PV spec.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57810, 57752). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Clarify error messages in HPA metrics **What this PR does / why we need it**: With the introduction of the RESTMetrics client, there are two ways to fetch metrics for auto-scaling. However, they previously shared error messages. This could be misleading. Make the error message more clearly show which method is in use. **Special notes for your reviewer**: @DirectXMan12 re conversation in #56827 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fixing typo in e2e test variable Fixing a typo in a value of one constant. ```release-note ```
-
Davanum Srinivas authored
`!strings.Contains(host, ":")` will fail miserably under ipv6
-
mbohlool authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56971, 57570, 57830, 57742). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Allow kubectl set image/env on a cronjob @kubernetes/sig-cli-pr-reviews ptal **Release note**: ```release-note Allow kubectl set image|env on a cronjob ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56971, 57570, 57830, 57742). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix possible panic in kube-aggregator **What this PR does / why we need it**: https://github.com/kubernetes/kubernetes/blob/91dc55562c9e7742a1cfdaa6d1db0b1ce262ff95/staging/src/k8s.io/kube-aggregator/pkg/apiserver/handler_proxy.go#L210 If startup kube-aggregator as a standalone process. `r.proxyTransport ` is uninitialized, so `r.proxyTransport.Dial` will panic. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56971, 57570, 57830, 57742). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add local PV negative scheduling tests to integration testing Closes: #56088 ```release-note Move local PV negative scheduling tests to integration ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56971, 57570, 57830, 57742). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. LimitRange ignores objects previously marked for deletion **What this PR does / why we need it**: A `LimitRange` added to a namespace after it has pods can prevent terminating pods from being deleted if they do not conform to the min/max criteria. xref https://bugzilla.redhat.com/show_bug.cgi?id=1509309 Fixes https://github.com/kubernetes/kubernetes/issues/57201 ```release-note NONE ```
-
Serguei Bezverkhi authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56382, 57549). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix azure disk not available issue when device name changed **What this PR does / why we need it**: There is possibility that device name(`/dev/sd*`) would change when attach/detach data disk in Azure VM according to [Troubleshoot Linux VM device name change](https://docs.microsoft.com/en-us/azure/virtual-machines/linux/troubleshoot-device-names-problems). And We did hit this issue, see customer [case](https://github.com/Azure/acs-engine/issues/1918). This PR would use `/dev/disk/by-id` instead of `/dev/sd*` for azure disk and `/dev/disk/by-id` would not change even device name changed. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #57444 **Special notes for your reviewer**: In a customer [case](https://github.com/Azure/acs-engine/issues/1918), customer is unable to use azure disk in StatefulSet since /dev/sd* changed after detach/attach disk. we are using `/dev/sd*`(code is [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/azure_dd/azure_common_linux.go#L140)) to "mount -bind" k8s path, while `/dev/sd*` could be changed when VM is attach/detaching data disks, see [Troubleshoot Linux VM device name change](https://docs.microsoft.com/en-us/azure/virtual-machines/linux/troubleshoot-device-names-problems) And I have also checked related AWS, GCE code, they are using `/dev/disk/by-id/` other than `/dev/sd*`, see [aws code](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/aws_ebs/aws_util.go#L228) [gce code](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/gce_pd/gce_util.go#L278) **Release note**: ``` fix azure disk not available when device name changed ``` /sig azure /assign @rootfs @karataliu @brendandburns @khenidak
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 56382, 57549). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. e2e: Only create PSP if RBAC is enabled **What this PR does / why we need it**: Creating privileged PSPs during e2e tests depends on RBAC being enabled in the target cluster. However it is possible to use PSPs without having RBAC enabled thus only enable creating PSPs during e2e tests if both PSP and RBAC is enabled. Fix #57840 **Special notes for your reviewer**: **Release note**: ```release-note Only create Privileged PSP binding during e2e tests if RBAC is enabled. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57696, 57821, 56317). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Change priority function(CalculateAntiAffinityPriority) into Map/Reduce pattern **What this PR does / why we need it**: Ref #24246. exactly ref https://github.com/kubernetes/kubernetes/issues/51455, the PR aim to unify priority functions(deprecated) by using map/reduce pattern. Previous related PR is https://github.com/kubernetes/kubernetes/pull/51192 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # None **Special notes for your reviewer**: **Release note**: ```release-note None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57696, 57821, 56317). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove hard-coded namespace **What this PR does / why we need it**: Since import cycle is solved, should use metav1.Namespace* instead of hard coding. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57696, 57821, 56317). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move DefaultMaxEBSVolumes constant into scheduler **What this PR does / why we need it**: A constant only used by the scheduler lives in the aws cloudprovider package. Moving the constant into the only package where it is used reduces import bloat. Testing with the dockerized build environment, the kube-scheduler binary went from 61748499 bytes to 47339144 bytes on amd64 with this change. **Release note**: ```release-note NONE ```
-
Lee Verberne authored
This updates the version of the pause container used by the kubelet and various test utilities to 3.1. This also adds a CHANGELOG.md for build/pause
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. validate admission-control startup param **What this PR does / why we need it**: validate admission plugins, if not registered, return err to prevent going on until call AdmissionOptions.ApplyTo. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #56614 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Maciej Szulik authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove comments in get-kube.sh that imply support for environments that were removed long ago. **What this PR does / why we need it**: Code cleanup. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Gavin authored
-
hzxuzhonghu authored
-
Robert Bailey authored
that were removed long ago.
-
hzxuzhonghu authored
-
hzxuzhonghu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Improve comments for Azure Blob Disk Controller **What this PR does / why we need it**: Improve comments for Azure Blob Disk Controller. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
lcfang authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57533, 57524). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make ConfigOK status messages more human readable This makes the ConfigOK status messages for dynamic config more human readable by including the path (e.g. SelfLink) to the object. The messages used to include the UID, but this was kind of useless, because there's no way to GET an object by UID. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57533, 57524). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. periodically check whether assigned kubelet config should become last-known-good Fixes #57808 Previously, the last-known-good was only updated on Kubelet restart. This has been on my todo list for a while, good to finally have a PR up. Previously we could have this scenario, which is fixed by this PR: - lkg is set to local - we set config A - config A passes trial period, but nothing caused Kubelet to restart - we set config B, which turns out to be invalid - Kubelet will fall back to local, because lkg was never updated ```release-note NONE ```
-
mattjmcnaughton authored
With the introduction of the RESTMetrics client, there are two ways to fetch metrics for auto-scaling. However, they previously shared error messages. This could be misleading. Make the error message more clearly show which method is in use.
-
Serguei Bezverkhi authored
Closes: #56088
-