1. 02 Nov, 2017 1 commit
    • Kubernetes Submit Queue's avatar
      Merge pull request #54894 from janetkuo/ds-e2e-flakes · f9e8322c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 54894, 54630, 54828, 54926, 54865). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      DaemonSet e2e should wait for history creation
      
      **What this PR does / why we need it**:
      Found a potential test flake while debugging #54575. ControllerRevisions are created separately with DaemonSet pods by controller, so we should wait for its creation in e2e. 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      **Special notes for your reviewer**: @kubernetes/sig-apps-bugs 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      f9e8322c
  2. 01 Nov, 2017 31 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #54652 from msau42/update-owners · 44390819
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Update volume OWNERS to reflect active sig-storage reviewers
      
      **What this PR does / why we need it**:
      Update sig-storage reviewers to add new members and remove those that don't have as much time to review storage PRs.   Approvers are unchanged.
      
      **Special notes for your reviewer**:
      For all those that have been removed, please approve.  If you want to remain as a reviewer, let me know and I will add you back.
      
      **Release note**:
      NONE
      44390819
    • Kubernetes Submit Queue's avatar
      Merge pull request #54719 from shiliangxue/master · 82184d8e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Move hardcoded constants to the beginning of configure.sh script.
      
      **What this PR does / why we need it**:
      Move hardcoded constants of component version and sha1 to the beginning of configure.sh to make it easier for GKE image preloader to parse.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      82184d8e
    • David Ashpole's avatar
      e0cac2a2
    • Kubernetes Submit Queue's avatar
      Merge pull request #54869 from mwielgus/ca-1.0.2-beta1 · afae7bcc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      ClusterAutoscaler 1.0.2-beta2
      afae7bcc
    • Kubernetes Submit Queue's avatar
      Merge pull request #53553 from bsteciuk/kubeadm-windows · 574492ae
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Kubeadm - Added initial support for Windows worker nodes to join cluster using kubeadm
      
      **What this PR does / why we need it**:
      This PR adds initial support for adding a Windows worker node to a Kubernetes cluster with kubeadm.  Also adds Windows build of kubeadm to node build targets. 
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/kubeadm/issues/364 
      
      **Special notes for your reviewer**:
      
      Depends on #53730 
      
      **Release note**:
      
      ```release-note
      kubeadm: Add support for adding a Windows node
      ```
      574492ae
    • Kubernetes Submit Queue's avatar
      Merge pull request #54893 from mengqiy/fix_convert · fcf9b1f7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Switch kubectl convert back to use legacyscheme and add tests
      
      Revert the change of `convert.go` in #54533.
      Add tests for kubectl convert.
      
      Fixes #54873 
      
      ```release-note
      NONE
      ```
      
      cc: @smarterclayton
      fcf9b1f7
    • Kubernetes Submit Queue's avatar
      Merge pull request #54708 from joelsmith/master · 444a161d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53962, 54708). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Prevent successful containers from restarting with OnFailure restart policy
      
      **What this PR does / why we need it**:
      
      This is a follow-on to #54597 which makes sure that its validation
      also applies to pods with a restart policy of OnFailure. This
      deficiency was pointed out by @smarterclayton here:
      https://github.com/kubernetes/kubernetes/pull/54530#discussion_r147226458
      
      **Which issue this PR fixes**  This is another fix to address #54499
      
      **Release note**:
      ```release-note
      NONE
      ```
      444a161d
    • Kubernetes Submit Queue's avatar
      Merge pull request #53962 from Lion-Wei/kubeadm-ipvs · f5b6dd87
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      support kube-proxy ipvs mode for kubeadm
      
      **What this PR does / why we need it**:
      When using `kubeadm` to build a cluster, you can chose kube-proxy with ipvs mode by add flag `--kube-proxy-mode=ipvs`.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52834
      
      **Special notes for your reviewer**:
      By default, use `iptables` mode. 
      **Release note**:
      ```release-note
      NONE
      ```
      f5b6dd87
    • Kubernetes Submit Queue's avatar
      Merge pull request #54543 from jamiehannaford/self-hosted-etcd-api · 96067e6d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49840, 54937, 54543). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add self-hosted etcd API to kubeadm
      
      **What this PR does / why we need it**:
      
      This PR is part of a larger set that implements self-hosted etcd. This PR takes a first step by adding:
      
      1. new API types in `cmd/kubeadm/app/apis` for configuring self-hosted etcd 
      2. new Go types in `cmd/kubeadm/app/phases/etcd/spec` used for constructing EtcdCluster CRDs for the etcd-operator. The reason we define these in trunk is because kubeadm cannot import `github.com/coreos/etcd-operator` as a dependency until it's in its own repo. Until then, we need to redefine the structs in our codebase.
      
      **Which issue this PR fixes**:
      
      https://github.com/kubernetes/kubeadm/issues/261
      https://github.com/kubernetes/kubeadm/issues/277
      
      **Special notes for your reviewer**:
      
      This is the first step PR in order to save reviewers from a goliath PR
      
      **Release note**:
      ```release-note
      NONE
      ```
      96067e6d
    • Kubernetes Submit Queue's avatar
      Merge pull request #54937 from xiangpengzhao/remove-kubeadm-const · 746cc43f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49840, 54937, 54543). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Remove MinimumCSRAutoApprovalClusterRolesVersion in 1.9 cycle.
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      Have we already bumped the minimum supported version to v1.8.0?
      /cc @luxas 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      746cc43f
    • Kubernetes Submit Queue's avatar
      Merge pull request #49840 from andrewrynhard/variable_certs_dir · c119a609
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49840, 54937, 54543). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm: Make it possible to configure volume mounts via the config file
      
      **What this PR does / why we need it**:
      Kubeadm mounts host CA certs into api server and controller manager. It uses `/etc/pki` and does not allow for the path to be configurable. This PR adds a default to `/etc/pki` but also allows a user to configure the path in the config file. In the case of using Container Linux, the CAs are located at `/usr/share/ca-certificates`, so without this PR the hardcoded `/etc/pki` path is used and will break, for example, the `--cloud-provider` flag because of missing CAs.
      
      Fixes https://github.com/kubernetes/kubeadm/issues/484
      Fixes https://github.com/kubernetes/kubeadm/issues/476
      Fixes https://github.com/kubernetes/kubeadm/issues/441
      
      /cc @luxas
      c119a609
    • Bob Steciuk's avatar
      Kubeadm - Added initial support for Windows worker nodes to join cluster using kubeadm · 44fbec29
      Bob Steciuk authored
      Added kubeadm to node build targets
      
      Created unix/windows specific conditionally compiled for checks.go and defaults.go
      44fbec29
    • Kubernetes Submit Queue's avatar
      Merge pull request #53048 from kubermatic/log-healthz-check-fail · 816f2f46
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Log error when a healthz check fails
      
      **What this PR does / why we need it**:
      Currently we only tell a user that a healthz check failed but we don't display the explicit error of the failed check. This is fine, but we should log the error to make debugging easier.
      
      ```release-note
      Log error of failed healthz check
      ```
      816f2f46
    • xiangpengzhao's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #53629 from andyzhangx/azurefile-improve · 618b705a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46341, 53629). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix azure file mount limit issue on windows due to using drive letter
      
      **What this PR does / why we need it**:
      It's not necessary to use drive letter in azure file mount, correct usage for New-SmbGlobalMapping is like following:
      ```
      New-SmbGlobalMapping -RemotePath $AzureFilePath -Credential $Credential
      mklink /D $mountPath $AzureFilePath 
      ```
      I removed the `LocalPath` parameter in New-SmbGlobalMapping
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #54668
      Without this PR, there is a limit(25) for azure file mount number on each node because only 25 drive letters could be used on each windows node, With this PR, there would be no such limit.
      
      **Special notes for your reviewer**:
      @PatrickLang 
      
      **Release note**:
      
      ```
      fix azure file mount limit issue on windows due to using drive letter
      ```
      /sig azure
      /sig windows
      618b705a
    • Kubernetes Submit Queue's avatar
      Merge pull request #46341 from zhangxiaoyu-zidif/add-unittest-for-secret · e2c31379
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add unittest for describe secret
      
      **What this PR does / why we need it**:
      add unittest for describe secret
      
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      e2c31379
    • Kubernetes Submit Queue's avatar
      Merge pull request #54888 from Cynerva/gkk/fix-iptables-conflict · 741beb64
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 54822, 53561, 54888). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix hook failure in kubernetes-worker charm due to iptables conflict
      
      **What this PR does / why we need it**:
      
      This fixes a hook failure that can occur on the kubernetes-worker charm due to iptable conflicts:
      
      ```
      Another app is currently holding the xtables lock. Perhaps you want to use the -w option?
      ...
      subprocess.CalledProcessError: Command '['iptables', '-P', 'FORWARD', 'ACCEPT']' returned non-zero exit status 4
      ```
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      Passing `-w 300` to iptables tells it to wait up to 5 minutes to acquire the xtables lock, rather than aborting immediately.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      741beb64
    • Kubernetes Submit Queue's avatar
      Merge pull request #53561 from justinsb/update_aws_sdk_go_1_12_7 · e93b049b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 54822, 53561, 54888). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Update AWS SDK to 1.12.7
      
      ```release-note
      Update AWS SDK to 1.12.7
      ```
      
      This includes support for all the latest goodies - in particular NLB and tagging as part of CreateVolume
      
      cc @micahhausler  @gnufied 
      
      Issue #54032
      e93b049b
    • Jamie Hannaford's avatar
      Add generated files · c19d146f
      Jamie Hannaford authored
      c19d146f
    • Jamie Hannaford's avatar
      Add selfHosted etcd API · 5eae39d6
      Jamie Hannaford authored
      5eae39d6
    • Kubernetes Submit Queue's avatar
      Merge pull request #54822 from janetkuo/ds-appsv1-validate · 52e41805
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Validate apps/v1 DaemonSet selector immutable on updates
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #54575
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      52e41805
    • Mengqi Yu's avatar
      add test for convert · b518a80c
      Mengqi Yu authored
      b518a80c
    • Mengqi Yu's avatar
      switch convert to use pkg/api/legacyscheme · 44aa7116
      Mengqi Yu authored
      44aa7116
    • Kubernetes Submit Queue's avatar
      Merge pull request #54406 from superbrothers/kubectl-override-short-flags · 7f9f847c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Improve 'kubectl completion` to override short flags
      
      **What this PR does / why we need it**: This PR improves `kubectl completion` to override short flags in
      addition to long flags. I tested this PR in both bash and zsh.
      
      ```
      # Complete pods name in the `default` namespace
      $ kubectl get po nginx-4217019353-<tab>
      nginx-4217019353-mw1pk  nginx-4217019353-rzw2c
      
      # Complete pods name in the `kube-system` namepace due to overriding the namespace
      $ kubectl -n kube-system get po kube<tab>
      kube-addon-manager-minikube  kube-dns-910330662-l9pwt     kubernetes-dashboard-9fbhm
      ```
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      7f9f847c
    • Andrew Rynhard's avatar
      Allow extra volumes to be defined · 5a64c049
      Andrew Rynhard authored
      5a64c049
    • Kubernetes Submit Queue's avatar
      Merge pull request #52513 from yanxuean/streamExec · 705de0a9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      improve the relation of ExecInContainer and Exec
      
      keep the relation between ExecInContainer and Exec be consistence with PortForward in streaming server
      
      fix #54903
      Signed-off-by: 's avataryanxuean <yan.xuean@zte.com.cn>
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      705de0a9
    • Kubernetes Submit Queue's avatar
      Merge pull request #54801 from apelisse/fix-broken-truncate · 7fdacaa6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53190, 54790, 54445, 52607, 54801). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Update `truncateBody` to not truncate with high level
      
      And add a unit-tests to verify that it works properly.
      
      **What this PR does / why we need it**:
      Update `truncateBody` so that one can use `V(10)` to read the entire content of a HTTP response.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      7fdacaa6
    • Kubernetes Submit Queue's avatar
      Merge pull request #52607 from zhangxiaoyu-zidif/optimize-intergration-test-rs · f65e5514
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53190, 54790, 54445, 52607, 54801). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      optimize speed of integration test:rc
      
      **What this PR does / why we need it**:
      optimize the speed of integration test for rc
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      ```shell
      make test-integration WHAT=./test/integration/replicaset GOFLAGS="-v" KUBE_TEST_ARGS="-run ^TestUpdateSelectorToRemoveControllerRef$"
      
      **Before modification:**
      
      Replicates test:
      --- PASS: TestUpdateSelectorToRemoveControllerRef (32.70s)
      	replicaset_test.go:377: patched rs = &v1beta1.ReplicaSet{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"rs", GenerateName:"", Namespace:"rs-update-selector-to-remove-controllerref", SelfLink:"/apis/extensions/v1beta1/namespaces/rs-update-selector-to-remove-controllerref/replicasets/rs", UID:"12cb97ec-9b59-11e7-a829-186590dec5c5", ResourceVersion:"100", Generation:2, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63641216052, loc:(*time.Location)(0x91f6800)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string{"name":"test"}, Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1beta1.ReplicaSetSpec{Replicas:(*int32)(0xc4227a7ad4), MinReadySeconds:0, Selector:(*v1.LabelSelector)(0xc42035dfe0), Template:v1.PodTemplateSpec{ObjectMeta:v1.ObjectMeta{Name:"", GenerateName:"", Namespace:"", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string{"name":"test", "uniqueKey":"1"}, Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1.PodSpec{Volumes:[]v1.Volume(nil), InitContainers:[]v1.Container(nil), Containers:[]v1.Container{v1.Container{Name:"fake-name", Image:"fakeimage", Command:[]string(nil), Args:[]string(nil), WorkingDir:"", Ports:[]v1.ContainerPort(nil), EnvFrom:[]v1.EnvFromSource(nil), Env:[]v1.EnvVar(nil), Resources:v1.ResourceRequirements{Limits:v1.ResourceList(nil), Requests:v1.ResourceList(nil)}, VolumeMounts:[]v1.VolumeMount(nil), LivenessProbe:(*v1.Probe)(nil), ReadinessProbe:(*v1.Probe)(nil), Lifecycle:(*v1.Lifecycle)(nil), TerminationMessagePath:"/dev/termination-log", TerminationMessagePolicy:"File", ImagePullPolicy:"Always", SecurityContext:(*v1.SecurityContext)(nil), Stdin:false, StdinOnce:false, TTY:false}}, RestartPolicy:"Always", TerminationGracePeriodSeconds:(*int64)(0xc4227a7b90), ActiveDeadlineSeconds:(*int64)(nil), DNSPolicy:"ClusterFirst", NodeSelector:map[string]string(nil), ServiceAccountName:"", DeprecatedServiceAccount:"", AutomountServiceAccountToken:(*bool)(nil), NodeName:"", HostNetwork:false, HostPID:false, HostIPC:false, SecurityContext:(*v1.PodSecurityContext)(0xc422fa6380), ImagePullSecrets:[]v1.LocalObjectReference(nil), Hostname:"", Subdomain:"", Affinity:(*v1.Affinity)(nil), SchedulerName:"default-scheduler", Tolerations:[]v1.Toleration(nil), HostAliases:[]v1.HostAlias(nil), PriorityClassName:"", Priority:(*int32)(nil)}}}, Status:v1beta1.ReplicaSetStatus{Replicas:2, FullyLabeledReplicas:2, ReadyReplicas:0, AvailableReplicas:0, ObservedGeneration:1, Conditions:[]v1beta1.ReplicaSetCondition(nil)}}
      PASS
      ok  	k8s.io/kubernetes/test/integration/replicaset	**32.810s**
      +++ [0917 11:34:42] Cleaning up etcd
      +++ [0917 11:34:42] Integration test cleanup complete
      
      
      **After modification:**
      --- PASS: TestUpdateSelectorToRemoveControllerRef (3.10s)
      	replicaset_test.go:377: patched rs = &v1beta1.ReplicaSet{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ObjectMeta:v1.ObjectMeta{Name:"rs", GenerateName:"", Namespace:"rs-update-selector-to-remove-controllerref", SelfLink:"/apis/extensions/v1beta1/namespaces/rs-update-selector-to-remove-controllerref/replicasets/rs", UID:"5b2fa66f-9b5b-11e7-bf1a-186590dec5c5", ResourceVersion:"100", Generation:2, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:63641217033, loc:(*time.Location)(0x91f6800)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string{"name":"test"}, Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1beta1.ReplicaSetSpec{Replicas:(*int32)(0xc4225dd374), MinReadySeconds:0, Selector:(*v1.LabelSelector)(0xc422f08e40), Template:v1.PodTemplateSpec{ObjectMeta:v1.ObjectMeta{Name:"", GenerateName:"", Namespace:"", SelfLink:"", UID:"", ResourceVersion:"", Generation:0, CreationTimestamp:v1.Time{Time:time.Time{wall:0x0, ext:0, loc:(*time.Location)(nil)}}, DeletionTimestamp:(*v1.Time)(nil), DeletionGracePeriodSeconds:(*int64)(nil), Labels:map[string]string{"name":"test", "uniqueKey":"1"}, Annotations:map[string]string(nil), OwnerReferences:[]v1.OwnerReference(nil), Initializers:(*v1.Initializers)(nil), Finalizers:[]string(nil), ClusterName:""}, Spec:v1.PodSpec{Volumes:[]v1.Volume(nil), InitContainers:[]v1.Container(nil), Containers:[]v1.Container{v1.Container{Name:"fake-name", Image:"fakeimage", Command:[]string(nil), Args:[]string(nil), WorkingDir:"", Ports:[]v1.ContainerPort(nil), EnvFrom:[]v1.EnvFromSource(nil), Env:[]v1.EnvVar(nil), Resources:v1.ResourceRequirements{Limits:v1.ResourceList(nil), Requests:v1.ResourceList(nil)}, VolumeMounts:[]v1.VolumeMount(nil), LivenessProbe:(*v1.Probe)(nil), ReadinessProbe:(*v1.Probe)(nil), Lifecycle:(*v1.Lifecycle)(nil), TerminationMessagePath:"/dev/termination-log", TerminationMessagePolicy:"File", ImagePullPolicy:"Always", SecurityContext:(*v1.SecurityContext)(nil), Stdin:false, StdinOnce:false, TTY:false}}, RestartPolicy:"Always", TerminationGracePeriodSeconds:(*int64)(0xc4225dd3f0), ActiveDeadlineSeconds:(*int64)(nil), DNSPolicy:"ClusterFirst", NodeSelector:map[string]string(nil), ServiceAccountName:"", DeprecatedServiceAccount:"", AutomountServiceAccountToken:(*bool)(nil), NodeName:"", HostNetwork:false, HostPID:false, HostIPC:false, SecurityContext:(*v1.PodSecurityContext)(0xc423096ac0), ImagePullSecrets:[]v1.LocalObjectReference(nil), Hostname:"", Subdomain:"", Affinity:(*v1.Affinity)(nil), SchedulerName:"default-scheduler", Tolerations:[]v1.Toleration(nil), HostAliases:[]v1.HostAlias(nil), PriorityClassName:"", Priority:(*int32)(nil)}}}, Status:v1beta1.ReplicaSetStatus{Replicas:2, FullyLabeledReplicas:2, ReadyReplicas:0, AvailableReplicas:0, ObservedGeneration:1, Conditions:[]v1beta1.ReplicaSetCondition(nil)}}
      PASS
      ok  	k8s.io/kubernetes/test/integration/replicaset	**3.216s**
      +++ [0917 11:50:33] Cleaning up etcd
      +++ [0917 11:50:33] Integration test cleanup complete
      ```
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      f65e5514
    • Kubernetes Submit Queue's avatar
      Merge pull request #54445 from crimsonfaith91/rem · ed00d9c0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53190, 54790, 54445, 52607, 54801). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      remove created-by annotation
      
      **What this PR does / why we need it**:
      This PR removes `CreatedByAnnotation`.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50720
      
      **Release note**:
      
      ```release-note
      The `kubernetes.io/created-by` annotation is no longer added to controller-created objects. Use the  `metadata.ownerReferences` item that has `controller` set to `true` to determine which controller, if any, owns an object.
      ```
      ed00d9c0
    • Kubernetes Submit Queue's avatar
      Merge pull request #54790 from wackxu/fixTODOPdb · 3bea3e87
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53190, 54790, 54445, 52607, 54801). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      one of min-available/max-available must be specified when create pdb
      
      **What this PR does / why we need it**:
      
      fix TODO one of min-available/max-available must be specified when create pdb
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      3bea3e87
    • Kubernetes Submit Queue's avatar
      Merge pull request #53190 from lichen2013/issues_34457 · ff5f0053
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 53190, 54790, 54445, 52607, 54801). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Improve kubectl error messages
      
      Fixes #34457
      Part of work on #31267
      ff5f0053
  3. 31 Oct, 2017 8 commits