1. 25 May, 2017 1 commit
  2. 24 May, 2017 32 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #46268 from jianglingxia/jlx523 · ee0de5f3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix the invalid link
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      ee0de5f3
    • Kubernetes Submit Queue's avatar
      Merge pull request #46329 from zjj2wry/DeamonSet-DaemonSet · aeeadb0c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      DeamonSet-DaemonSet
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      aeeadb0c
    • Kubernetes Submit Queue's avatar
      Merge pull request #44443 from jamiehannaford/kubelet-tc · de1ebf81
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Bump kubelet/networks test coverage
      
      **What this PR does / why we need it**:
      
      Bumps test coverage
      
      **Which issue this PR fixes**:
      
      https://github.com/kubernetes/kubernetes/issues/40780
      https://github.com/kubernetes/kubernetes/issues/39559
      
      **Special notes for your reviewer**:
      
      Writing positive test cases for these lines:
      https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/networks.go#L38 https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/networks.go#L69 
      is quite difficult, so the former has a negative case and the latter has no test coverage.
      
      **Release note**:
      ```release-note
      New tests for kubelet/networks
      ```
      de1ebf81
    • Kubernetes Submit Queue's avatar
      Merge pull request #46128 from jagosan/master · 89a76b8c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Added deprecation notice and guidance for cloud providers.
      
      **What this PR does / why we need it**:
      Adding context/background and general guidance for incoming cloud providers. 
      
      **Which issue this PR fixes** 
      
      **Special notes for your reviewer**:
      Generalized message per discussion with @bgrant0607
      89a76b8c
    • Kubernetes Submit Queue's avatar
      Merge pull request #46262 from xilabao/fix-message-in-storage-extensions · c1d6439f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix err message in storage extensions
      
      **Release note**:
      
      ```release-note
      `NONE`
      ```
      c1d6439f
    • Kubernetes Submit Queue's avatar
      Merge pull request #46305 from sjenning/init-container-status · b3181ec2
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      clear init container status annotations when cleared in status
      
      When I pod with an init container is terminated due to exceeding its active deadline, the pod status is phase `Failed` with reason `DeadlineExceeded`.  All container statuses are cleared from the pod status.
      
      With init containers, however, the status is being regenerated from the status annotations.  This is causing kubectl to report the pod state as `Init:0/1` instead of `DeadlineExceeded` because the kubectl printer observes a running init container, which in reality is not running.
      
      This PR clears out the init container status annotations when they have been removed from the pod status so they are not regenerated on the apiserver.
      
      xref https://bugzilla.redhat.com/show_bug.cgi?id=1453180
      
      @derekwaynecarr 
      
      ```release-note
      Fix init container status reporting when active deadline is exceeded.
      ```
      b3181ec2
    • Kubernetes Submit Queue's avatar
      Merge pull request #46315 from wongma7/gcepdalready · 6f7eac63
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38505, 41785, 46315)
      
      Fix provisioned GCE PD not being reused if already exists
      
      @jsafrane PTAL 
      
      This is another attempt at https://github.com/kubernetes/kubernetes/pull/38702 . We have observed that `gce.service.Disks.Insert(gce.projectID, zone, diskToCreate).Do()` instantly gets an error response of alreadyExists, so we must check for it.
      
      I am not sure if we still need to check for the error after `waitForZoneOp`; I think that if there is an alreadyExists error, the `Do()` above will always respond with it instantly. But because I'm not sure, and to be safe, I will leave it.
      6f7eac63
    • Kubernetes Submit Queue's avatar
      Merge pull request #41785 from jamiehannaford/cinder-performance · 70dd10cc
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 38505, 41785, 46315)
      
      Only retrieve relevant volumes
      
      **What this PR does / why we need it**:
      
      Improves performance for Cinder volume attach/detach calls. 
      
      Currently when Cinder volumes are attached or detached, functions try to retrieve details about the volume from the Nova API. Because some only have the volume name not its UUID, they use the list function in gophercloud to iterate over all volumes to find a match. This incurs severe performance problems on OpenStack projects with lots of volumes (sometimes thousands) since it needs to send a new request when the current page does not contain a match. A better way of doing this is use the `?name=XXX` query parameter to refine the results.
      
      **Which issue this PR fixes**:
      
      https://github.com/kubernetes/kubernetes/issues/26404
      
      **Special notes for your reviewer**:
      
      There were 2 ways of addressing this problem:
      
      1. Use the `name` query parameter
      2. Instead of using the list function, switch to using volume UUIDs and use the GET function instead. You'd need to change the signature of a few functions though, such as [`DeleteVolume`](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/cinder/cinder.go#L49), so I'm not sure how backwards compatible that is.
      
      Since #1 does effectively the same as #2, I went with it because it ensures BC.
      
      One assumption that is made is that the `volumeName` being retrieved matches exactly the name of the volume in Cinder. I'm not sure how accurate that is, but I see no reason why cloud providers would want to append/prefix things arbitrarily. 
      
      **Release note**:
      ```release-note
      Improves performance of Cinder volume attach/detach operations
      ```
      70dd10cc
    • Kubernetes Submit Queue's avatar
      Merge pull request #38505 from… · 2bc097b0
      Kubernetes Submit Queue authored
      Merge pull request #38505 from pospispa/260-finish-aws-provisioner-parse-pvc-selector-dynamic-provision-first-part-including-GCE-changes-StorageClass-zones-part-back-in-history-to-test-it-on-AWS
      
      Automatic merge from submit-queue (batch tested with PRs 38505, 41785, 46315)
      
      GCE and AWS provisioners, dynamic provisioning: admins can configure zone(s) where PVs shall be created
      
      Zone configuration capabilities for GCE and AWS dynamic provisioners are extended.
      Admins can configure in a storage class a comma separated list of allowed zone(s).
      
      Partly fixes Trello cards:
      - [GCE provisioner, parse pvc.Selector](https://trello.com/c/CyemTzsK/259-finish-gce-provisioner-parse-pvc-selector-dynamic-provision)
      - [AWS provisioner, parse pvc.Selector](https://trello.com/c/2XjouSWw/260-finish-aws-provisioner-parse-pvc-selector-dynamic-provision)
      
      ```release-note
      GCE and AWS dynamic provisioners extension: admins can configure zone(s) in which a persistent volume shall be created.
      ```
      
      cc: @jsafrane
      2bc097b0
    • Kubernetes Submit Queue's avatar
      Merge pull request #46213 from xiao-zhou/extention-api · 54f66881
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add test for cross namespace watch and list
      
      **What this PR does / why we need it**: Add more integration test for kube-apiextensions-server
      
      **Which issue this PR fixes** : fixes https://github.com/kubernetes/kubernetes/issues/45511
      
      **Special notes for your reviewer**: The client with cluster scope also works, but it seems to be trivial
      
      @deads2k
      54f66881
    • Jamie Hannaford's avatar
      4bd71a3b
    • Kubernetes Submit Queue's avatar
      Merge pull request #46101 from sttts/sttts-crd-core-names · 7c76e399
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      apiextensions: add Established condition
      
      This introduces a `Established` condition on `CustomResourceDefinition`s. `Established` means that the resource has become active. A resource is established when all names are accepted initially without a conflict. A resource stays established until deleted, even during a later NameConflict due to changed names. Note that not all names can be changed.
      
      This change is necessary to allow deletion of once-active CRDs which might have still instances, but  have NameConflicts now. Before this PR the REST endpoint was not active anymore in this case, making deletion of the instances impossible.
      7c76e399
    • pospispa's avatar
      Admin Can Specify in Which AWS Availability Zone(s) a PV Shall Be Created · 9eb912e6
      pospispa authored
      An admin wants to specify in which AWS availability zone(s) users may create persistent volumes using dynamic provisioning.
      
      That's why the admin can now configure in StorageClass object a comma separated list of zones. Dynamically created PVs for PVCs that use the StorageClass are created in one of the configured zones.
      9eb912e6
    • pospispa's avatar
      Admin Can Specify in Which GCE Availability Zone(s) a PV Shall Be Created · d73c0d64
      pospispa authored
      An admin wants to specify in which GCE availability zone(s) users may create persistent volumes using dynamic provisioning.
      
      That's why the admin can now configure in StorageClass object a comma separated list of zones. Dynamically created PVs for PVCs that use the StorageClass are created in one of the configured zones.
      d73c0d64
    • pospispa's avatar
      Added func ValidateZone · dd17d620
      pospispa authored
      The zone parameter provided in a Storage Class may erroneously be an empty string or contain only spaces and tab characters. Such situation shall be detected and reported as an error.
      
      That's why the func ValidateZone was added.
      dd17d620
    • pospispa's avatar
      Added func ZonesToSet · 0f3a9cfc
      pospispa authored
      An admin shall be able to configure a comma separated list of zones for a StorageClass.
      
      That's why the func ZonesToSet (string) (set.String, error) is added. The func ZonesToSet converts a string containing a comma separated list of zones to a set. In case the list contains an empty zone an error is returned.
      0f3a9cfc
    • zhengjiajin's avatar
      DeamonSet-DaemonSet · 550a834b
      zhengjiajin authored
      550a834b
    • Kubernetes Submit Queue's avatar
      Merge pull request #46147 from nicksardo/gce-cluster-id · c1c7365e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45891, 46147)
      
      Watching ClusterId from within GCE cloud provider
      
      **What this PR does / why we need it**:
      Adds the ability for the GCE cloud provider to watch a config map for `clusterId` and `providerId`.
      
      WIP - still needs more testing
      
      cc @MrHohn @csbell @madhusudancs @thockin @bowei @nikhiljindal 
      
      **Release note**:
      ```release-note
      NONE
      ```
      c1c7365e
    • Kubernetes Submit Queue's avatar
      Merge pull request #45891 from zjj2wry/zjj-t · 84401e76
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45891, 46147)
      
      fix typo
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      84401e76
    • Author xiao-zhou's avatar
      abc4fcfc
    • Dr. Stefan Schimanski's avatar
    • Dr. Stefan Schimanski's avatar
    • Dr. Stefan Schimanski's avatar
      653258f1
    • Kubernetes Submit Queue's avatar
      Merge pull request #45635 from MrHohn/hyperkube-unit-test · 1153ef19
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45514, 45635)
      
      hyperkube_test should not depend on number of spaces.
      
      From #45524.
      
      Apparently adding a long flag to kube-controller-manager breaks the hyperkube unit tests, because they depend on number of spaces :)
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      1153ef19
    • Kubernetes Submit Queue's avatar
      Merge pull request #45514 from mikedanese/cert-refactor · 5be7a6a7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 45514, 45635)
      
      refactor certificate controller to break it into two parts
      
      Break pkg/controller/certificates into:
      * pkg/controller/certificates/approver: containing the group approver
      * pkg/controller/certificates/signer: containing the local signer
      * pkg/controller/certificates: containing shared infrastructure
      ```release-note
      Break the 'certificatesigningrequests' controller into a 'csrapprover' controller and 'csrsigner' controller.
      ```
      5be7a6a7
    • Kubernetes Submit Queue's avatar
      Merge pull request #46312 from dashpole/remove_memcg_jenkins_properties · d4ff0f2a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42042, 46139, 46126, 46258, 46312)
      
      Remove unused test properties
      
      Issue:  #42676
      A separate serial memcg suite was created for the initial stages of re-enabling memcg notifications.  Now that all e2e tests have memcg notifications enabled, this suite is no longer needed.
      d4ff0f2a
    • Kubernetes Submit Queue's avatar
      Merge pull request #46258 from MrHohn/esipp-fix-needsUpdate · 447ee4a1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42042, 46139, 46126, 46258, 46312)
      
      Detect ExternalTrafficPolicy and HealthCheckNodePort changes in needsUpdate()
      
      Fix a bug that editing ExternalTrafficPolicy doesn't trigger LoadBalancer update. I'm surprise that ESIPP e2e tests didn't catch this.
      
      /assign @freehan @thockin 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      447ee4a1
    • Kubernetes Submit Queue's avatar
      Merge pull request #46126 from timstclair/forward-ip · 2b1b7f92
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42042, 46139, 46126, 46258, 46312)
      
      Append X-Forwarded-For in proxy handler
      
      Append the request sender's IP to the `X-Forwarded-For` header chain when proxying requests. This is important for audit logging (https://github.com/kubernetes/features/issues/22) in order to capture the client IP (specifically in the case of federation or kube-aggregator).
      
      /cc @liggitt @deads2k @ericchiang @ihmccreery @soltysh
      2b1b7f92
    • Kubernetes Submit Queue's avatar
      Merge pull request #46139 from monopole/removeDepOnPkgHelper · 8e87c029
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42042, 46139, 46126, 46258, 46312)
      
      Remove kubectl's dependence on pkg/api/helper
      
      **What this PR does / why we need it**:
      
      Remove kubectl's dependence on pkg/api/helper, as part of
      broader effort to isolate kubectl from the rest of k8s.
      In this case, the code becomes private to kubectl; nobody else uses it.
      
      **Which issue this PR fixes**
      
      Part of a series of PRs to address kubernetes/community#598
      
      **Release note**:
      ```release-note
      NONE
      ```
      8e87c029
    • Kubernetes Submit Queue's avatar
      Merge pull request #42042 from perotinus/svcaccounts · f30443ca
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 42042, 46139, 46126, 46258, 46312)
      
      [Federation] Use service accounts instead of the user's credentials when accessing joined clusters' API servers.
      
      Fixes #41267.
      
      Release notes:
      ```release-note
      Modifies kubefed to create and the federation controller manager to use credentials associated with a service account rather than the user's credentials.
      ```
      f30443ca
    • Kubernetes Submit Queue's avatar
      Merge pull request #44428 from qiujian16/commenttypo · 90250220
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix some typo of comment in kubelet.go
      
      **What this PR does / why we need it**:
      The PR is to fix some typo in kubelet.go
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      N/A
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      ```
      90250220
    • Kubernetes Submit Queue's avatar
      Merge pull request #46289 from p0lyn0mial/admission_plugins_remove_init_blocks · 95a6f108
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      remove init blocks from all admission plugins
      
      **What this PR does / why we need it**:
      removes init blocks from all admission plugins
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      95a6f108
  3. 23 May, 2017 7 commits
    • Seth Jennings's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #46194 from CaoShuFeng/under · c2421df3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46149, 45897, 46293, 46296, 46194)
      
      check flag format in file known-flags.txt
      
      All flags in file hack/verify-flags/known-flags.txt should contain
      character -, this change check it to prevent adding useless flags
      to known-flags.txt
      ref #45948 
      
      **Release note**:
      
      ```
      NONE
      ```
      c2421df3
    • Kubernetes Submit Queue's avatar
      Merge pull request #46296 from ncdc/crd-finalizer · 763b75d9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46149, 45897, 46293, 46296, 46194)
      
      Use storage instead of REST for the CRD finalizer
      
      **What this PR does / why we need it**:
      Switch the custom resource definition finalizer controller to use
      storage instead of a REST client, because a client could incorrectly try
      to delete ThirdPartyResources whose names happen to collide with the
      CustomResource instances.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      763b75d9
    • Kubernetes Submit Queue's avatar
      Merge pull request #46293 from nicksardo/chaosmonkey-defer-stop · dae69555
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46149, 45897, 46293, 46296, 46194)
      
      Chaosmonkey - Signal stop to tests and wait for done when disruption fails
      
      **What this PR does / why we need it**:
      Prevents tests from leaking resources because their Teardown was never called when test disruption fails.   
      
      **Which issue this PR fixes**
      First problem of #45842 
      
      **Release note**:
      ```release-note
      NONE
      ```
      dae69555
    • Kubernetes Submit Queue's avatar
      Merge pull request #45897 from ncdc/gc-require-list-watch · 45b275d5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46149, 45897, 46293, 46296, 46194)
      
      GC: update required verbs for deletable resources, allow list of ignored resources to be customized
      
      The garbage collector controller currently needs to list, watch, get,
      patch, update, and delete resources. Update the criteria for
      deletable resources to reflect this.
      
      Also allow the list of resources the garbage collector controller should
      ignore to be customizable, so downstream integrators can add their own
      resources to the list, if necessary.
      
      cc @caesarxuchao @deads2k @smarterclayton @mfojtik @liggitt @sttts @kubernetes/sig-api-machinery-pr-reviews
      45b275d5
    • Matthew Wong's avatar
      11cb36e9
    • Mike Danese's avatar
      refactor certificate controller · f04ce3cf
      Mike Danese authored
      f04ce3cf