1. 06 Sep, 2018 21 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #68087 from grayluck/refetch · f85d39ab
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Let the service controller retry when presistUpdate returns a conflict error
      
      **What this PR does / why we need it**:
      If a load balancer is changed while provisioning, it will fall into an error state and will not self-recover.
      This PR picks up the conflict error and let serviceController retry in order to get the load balancer out of error state.
      
      **Special notes for your reviewer**:
      /assign @MrHohn @rramkumar1 
      
      **Release note**:
      
      ```release-note
      Let service controller retry creating load balancer when persistUpdate failed due to conflict.
      ```
      f85d39ab
    • Kubernetes Submit Queue's avatar
      Merge pull request #61097 from adelina-t/change_hardcoded_busybox_image_in_e2e_tests · 2a17ccb0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Replaced hardcoded busybox image in e2e tests
      
      Some e2e tests use hardcoded busybox image. Replaced it with the one defined in "k8s.io/kubernetes/test/utils/image". This is relevant to the work of porting e2e tests to Windows k8s clusters.
      
      Related to issue #60487
      
       ```release-note
      NONE
       ```
      2a17ccb0
    • Kubernetes Submit Queue's avatar
      Merge pull request #68280 from roberthbailey/cluster-deprecation-notice · 9dba077d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Cleaning up the cluster directory deprecation notice
      
      - Remove link to the kube-deploy repo
       - Remove link to SaltStack
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      9dba077d
    • Kubernetes Submit Queue's avatar
      Merge pull request #68360 from dims/attempt-to-fix-conversion-gen-issues-with-imports-that-are-same · d89d0d91
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      conversion-gen issues with import that are exactly the same
      
      Technically we don't need this. the instruction below:
      ```
      // +k8s:conversion-gen=k8s.io/kubernetes/pkg/controller/apis/config/v1alpha1
      ```
      registers the apiserver/apimachinery packages in the "package universe"
      of the conversion-gen program per comment from lucas in PR 68233
      
      However it looks like some files that use both packages run into trouble
      and causes failures in CI harness. Attempting here to see if we fix the
      order by specifying them explicitly helps.
      
      Change-Id: I20e9c9256f0b7ffdf4e2101d0ca1fe5090e51344
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      d89d0d91
    • Davanum Srinivas's avatar
      conversion-gen issues with import that are exactly the same · 95c70ff6
      Davanum Srinivas authored
      Technically we don't need this. the instruction below:
      ```
      // +k8s:conversion-gen=k8s.io/kubernetes/pkg/controller/apis/config/v1alpha1
      ```
      registers the apiserver/apimachinery packages in the "package universe"
      of the conversion-gen program per comment from lucas in PR 68233
      
      However it looks like some files that use both packages run into trouble
      and causes failures in CI harness. Attempting here to see if we fix the
      order by specifying them explicitly helps.
      
      Change-Id: I20e9c9256f0b7ffdf4e2101d0ca1fe5090e51344
      95c70ff6
    • Kubernetes Submit Queue's avatar
      Merge pull request #68239 from cuppett/issue-59015 · e5f55dd9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Resolves #59015, Scheduler: Add support for EBS types t3, r5, & z1d
      
      Fixes #59015
      
      The new t3, r5, r5d and z1 need matched as well according to this:
      
      From current AWS documentation:
      
      https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/volume_limits.html
      
      T3, C5, C5d, M5, M5d, R5, R5d, and z1d instances support a maximum of
      28 attachments, and every instance has at least one network interface
      attachment. If you have no additional network interface attachments on
      these instances, you could attach 27 EBS volumes.
      
      **Release note**:
      
      ```NONE
      
      ```
      e5f55dd9
    • Adelina Tuvenie's avatar
      8aa33c62
    • Kubernetes Submit Queue's avatar
      Merge pull request #68312 from msau42/fix-e2e · 8e329f1c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Fix gce localssd pv tests
      
      **What this PR does / why we need it**:
      When running local PV tests against GCE local SSD, it directly uses the disk so doesn't need to create a tmp dir like the other test formats.  Fsgroup tests do not create test-file so don't error on cleanup if the file doesn't exist.
      
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #68308
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      8e329f1c
    • Kubernetes Submit Queue's avatar
      Merge pull request #67690 from feiskyer/iptables-cross · 4bc9e94f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Kubelet: only sync iptables on linux
      
      **What this PR does / why we need it**:
      
      Iptables is only supported on Linux, kubelet should only sync NAT rules on Linux.
      
      Without this PR, Kubelet on Windows would logs following errors on each `syncNetworkUtil()`:
      
      ```
      kubelet.err.log:4692:E0711 22:03:42.103939    2872 kubelet_network.go:102] Failed to ensure that nat chain KUBE-MARK-DROP exists: error creating chain "KUBE-MARK-DROP": executable file
      ```
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #65713
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Kubelet now only sync iptables on Linux.
      ```
      4bc9e94f
    • Kubernetes Submit Queue's avatar
      Merge pull request #67911 from ixdy/update-bazel-deps · 4465858a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Update bazel deps
      
      **What this PR does / why we need it**: updates relevant bazel dependencies to pull in minor feature enhancements and bug fixes:
      * rules_go 0.15.3: some speed improvements and better compatibility on Windows and Mac, among other bugfixes / enhancements
      * repo-infra: fixes needed to support rules_go 0.15.1, and also a fix for https://github.com/kubernetes/kubernetes/pull/65501#issuecomment-400761696
      * rules_docker v0.5.1: various enhancements/fixes, but we need this to support new manifest lists from upstream
      * busybox latest: we last updated this a while ago. since Docker hub now uses manifest lists for core images like this, we needed the rules_docker update
      * gazelle 0.14.0: among other enhancements, adds a feature to remove the need to build protoc for every build, which we aren't even using.
      
      **Special notes for your reviewer**:
      Depends on https://github.com/kubernetes/repo-infra/pull/81. I believe we also need bazel 0.16+.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      4465858a
    • Kubernetes Submit Queue's avatar
      Merge pull request #68233 from luxas/ccm_cleanup · c3062bae
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 68171, 67945, 68233). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Move the CloudControllerManagerConfiguration to an API group in `cmd/`
      
      **What this PR does / why we need it**:
      This PR is the last piece of https://github.com/kubernetes/kubernetes/issues/67233.
      It moves the `CloudControllerManagerConfiguration` to its own `cloudcontrollermanager.config.k8s.io` config API group, but unlike the other components this API group is "private" (only available in `k8s.io/kubernetes`, which limits consumer base), as it's located entirely in `cmd/` vs a staging repo.
      This decision was made for now as we're not sure what the story for the ccm loading ComponentConfig files is, and probably a "real" file-loading ccm will never exist in core, only helper libraries. Eventually the ccm will only be a library in any case, and implementors will/can use the base types the ccm library API group provides. It's probably good to note that there is no practical implication of this change as the ccm **cannot** read ComponentConfig files. Hencec the code move isn't user-facing.
      
      With this change, we're able to remove `pkg/apis/componentconfig`, as this was the last consumer. That is hence done in this PR as well (so the move is easily visible in git, vs first one "big add" then a "big remove"). The only piece of code that was used was the flag helper structs, so I moved them to `pkg/util/flag` that I think makes sense for now.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      ref: kubernetes/community#2354
      
      **Special notes for your reviewer**:
      
      This PR builds on top of (first two commits, marked as `Co-authored by: @stewart-yu`) https://github.com/kubernetes/kubernetes/pull/67689
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      /assign @liggitt @sttts @thockin @stewart-yu
      c3062bae
    • Kubernetes Submit Queue's avatar
      Merge pull request #67945 from jsafrane/csi-workload-csidriver3-saad · 7b756e68
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 68171, 67945, 68233). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      CSI pod information in NodePublish
      
      **What this PR does / why we need it**:
      This is implementation of https://github.com/kubernetes/community/pull/2439. It brings CSI closer to Flex volume features, CSI driver can (optionally) get name/namespace/UID/ServiceAccount of the pod that requires the CSI volume mounted. This allows CSI drivers to either do AAA before the volume is mounted or tailor content of  volume to the pod.
      
      Work in progress:
        * contains #67803 to get `CSIDriver` API. Ignore the first commit.
      
      Related to #64984 #66362 (fixes only part of these issues)
      
      /sig storage
      
      cc: @saad-ali @vladimirvivien @verult @msau42 @gnufied 
      
      **Release note**:
      
      ```release-note
      CSI NodePublish call can optionally contain information about the pod that requested the CSI volume.
      ```
      7b756e68
    • Kubernetes Submit Queue's avatar
      Merge pull request #68171 from dixudx/fix_e2e_limitrange_update · 2d7b4b04
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 68171, 67945, 68233). If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      [e2e] verifying LimitRange update is effective before creating new pod
      
      **What this PR does / why we need it**:
      Refer to the flaky test mentioned in #68170, LimitRange updating should be verified before creating new pod.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #68170
      
      **Special notes for your reviewer**:
      /cc bsalamat k82cn 
      /sig scheduling
      
      **Release note**:
      
      ```release-note
      [e2e] verifying LimitRange update is effective before creating new pod
      ```
      2d7b4b04
    • Michelle Au's avatar
      Fix gce localssd pv tests · 07ebe323
      Michelle Au authored
      07ebe323
    • Stephen Cuppett's avatar
      Resolves #59015, extends existing regex to cover t3, r5(d) & z1d instance types · d85daf0f
      Stephen Cuppett authored
      From current AWS documentation:
      
      https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/volume_limits.html
      
      T3, C5, C5d, M5, M5d, R5, R5d, and z1d instances support a maximum of
      28 attachments, and every instance has at least one network interface
      attachment. If you have no additional network interface attachments on
      these instances, you could attach 27 EBS volumes.
      d85daf0f
    • Jan Safranek's avatar
      Add unit tests for pod information in NodePublish · 32ae639e
      Jan Safranek authored
      Some refactoring of CSI tests was necessary.
      32ae639e
    • Jan Safranek's avatar
      a30fc9ca
    • Jan Safranek's avatar
      Add new RBAC rules for CSIDriver · dc6be0cb
      Jan Safranek authored
      Nodes need to watch CSIDrivers to know if they should send pod information
      in NodePublish.
      dc6be0cb
    • Jan Safranek's avatar
      db94508a
    • Jan Safranek's avatar
      e26809a4
    • Kubernetes Submit Queue's avatar
      Merge pull request #67139 from NetApp/dev-random-fix-67091 · a5550441
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.
      
      Fix an issue about generation of secret key with invalid key size in gce
      
      Replace /dev/random to /dev/urandom to avoid generation of secret key with invalid key size.
      
      
      
      **What this PR does / why we need it**:
      In GCE env, AESGCM encryption of secrets by default generates a secret key with /dev/random which sometime generates a key with invalid size.
      This cause the cluster/kube-up.sh to fail in gce environment.
      
      This PR replaces /dev/random with  /dev/urandom to have a secret key generated consistently with right size.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #67091
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      cluster/gce: generate consistent key sizes in config-default.sh using /dev/urandom instead of /dev/random  
      ```
      a5550441
  2. 05 Sep, 2018 19 commits