- 06 Aug, 2017 2 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49855, 49915) Let controllers ignore initialization timeout when creating pods Partially address https://github.com/kubernetes/kubernetes/issues/48893#issuecomment-318540129. This only updates the controllers that create pods with `GenerateName`. The controllers ignore the timeout error when creating the pods, depending on how the initialization progress: * If the initialization is successful in less than 5 mins, the controller will observe the creation via the informer. All is good. * If the initialization fails, server will delete the pod, but the controller won't receive any event. The controller will not create new pod until the Creation expectation expires in 5 min. * If the initialization takes too long (> 5 mins), the Creation expectation expires and the controller will create extra pods. I'll send follow-up PRs to fix the latter two cases, e.g., by refactoring the sharedInformer.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49855, 49915) update dashboard image version fix https://github.com/kubernetes/kubernetes/issues/50195 **What this PR does / why we need it:** Updates dashboard addon to latest version. Changelog can be found [here](https://github.com/kubernetes/dashboard/releases/tag/v1.6.3). **Release note:** ``` Update dashboard version to v1.6.3 ```
-
- 05 Aug, 2017 31 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubeadm: Implementing the kubeconfig phase fully **What this PR does / why we need it:** This contains implementation of kubeconfig phases in kubeadm, which is part of the wider effort of implementing phases in kubeadm, previously in alpha stage. The original proposal for this activity can be found [here](https://github.com/kubernetes/kubeadm/pull/156/files) and related comments. Kubeadm phase implementation checklist is defined [here](https://github.com/kubernetes/kubeadm/issues/267) Common implementation guidelines and principles for all phases are defined [here](https://docs.google.com/document/d/1VQMyFIVMfRGQPP3oCUpfjiWtOr3pLxp4g7cP-hXQFXc/edit?usp=sharing) This PR implements: - [x] kubeadm phase kubeconfig - [x] kubeadm phase kubeconfig all - [x] kubeadm phase kubeconfig admin - [x] kubeadm phase kubeconfig kubelet - [x] kubeadm phase kubeconfig scheduler - [x] kubeadm phase kubeconfig controller-manager - [x] kubeadm phase kubeconfig user **Which issue this PR fixes:** https://github.com/kubernetes/kubeadm/issues/350 **Special notes for your reviewer:** This PR implements the second phases of kubeadm init; implementation of this PR follow the same approach already used for #48196 (cert phases). Please note that: - the API - phase\kubeconfig.go - is now totally free by any UX concerns, and implements only the core logic for kubeconfig generation. - the UX - cmd\phase\kubeconfig.go - now takes charge of UX commands and kubeadm own's rules for kubeconfig files in /etc/kubernetes folder (e.g. create only if not already exists) - The PR includes also a fix for a regression on a unit test for phase certs introduced by #48594 and few minor code changes in phase certs introduced to avoid code duplication between the two phases.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix typo in test/images/port-forward-tester/Makefile **What this PR does / why we need it**: the image build fails due to this typo: ```console $ make WHAT=port-forward-tester ./image-util.sh build port-forward-tester Building image for port-forward-tester ARCH: ppc64le... make[1]: Entering directory '[home]/src/k8s.io/kubernetes/test/images/port-forward-tester' ../image-util.sh bin ../image-util.sh: line 22: $2: unbound variable ``` Images already pushed. **Release note**: ```release-note NONE ``` /approve no-issue /assign @mkumatag
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix typos and grammatical errors in comments and variables
-
Malepati Bala Siva Sai Akhil authored
Fix typo in variable of remote_runtime.go
-
Malepati Bala Siva Sai Akhil authored
Fixed typo in rkt
-
Malepati Bala Siva Sai Akhil authored
Fixed typo in comment in eviction_manager
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49805, 50052) remove the temporary file to make the hyperkube image smaller Remove the temporary file after apt-get install to make the hyperkube image smaller.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49805, 50052) We never want to modify the globally defined SG for ELBs **What this PR does / why we need it**: Fixes a bug where creating or updating an ELB will modify a globally defined security group **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50105 **Special notes for your reviewer**: **Release note**: ```release-note fixes a bug around using the Global config ElbSecurityGroup where Kuberentes would modify the passed in Security Group. ```
-
Malepati Bala Siva Sai Akhil authored
Fix typo in comment in garbagecollector
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix typo in certificate
-
Malepati Bala Siva Sai Akhil authored
-
fabriziopandini authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix typos in federation-controller **What this PR does / why we need it**: fix some typos in federation-controller. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix typo **What this PR does / why we need it**: Fix trivial typo in comment.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48532, 50054, 50082) Refactored the fluentd-es addon Refactor fluentd-elasticsearch addon: - Decrease the number of files by moving RBAC-related objects in the same files where they're used - Move the fluentd configuration out of the image - Don't use PVC to avoid leaking resources in e2e tests - Fluentd now ingest docker and kubelet logs that are written to journald - Disable X-Pack, because it's not free Fixes https://github.com/kubernetes/kubernetes/issues/41462 Fixes https://github.com/kubernetes/kubernetes/issues/49816 Fixes https://github.com/kubernetes/kubernetes/issues/48973 Fixes https://github.com/kubernetes/kubernetes/issues/49450 @aknuds1 @coffeepac Could you please take a look? ```release-note Fluentd DaemonSet in the fluentd-elasticsearch addon is configured via ConfigMap and includes journald plugin Elasticsearch StatefulSet in the fluentd-elasticsearch addon uses local storage instead of PVC by default ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48532, 50054, 50082) Remove [k8s.io] tag and redundant [sig-storage] tags from volume tests **What this PR does / why we need it**: Removes redundant tags from storage e2e test names **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50178 **Release note**: /release-note-none
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48532, 50054, 50082) Correcting two spelling mistakes **What this PR does / why we need it**: Correcting two spelling mistakes. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: NONE ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162) kubeadm: Replace *clientset.Clientset with clientset.Interface **What this PR does / why we need it**: Needed for https://github.com/kubernetes/kubernetes/pull/48899 We should always use `clientset.Interface` instead of `*clientset.Clientset`, for better testability and all the other benefits of using an interface. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: Should be straightforward to merge **Release note**: ```release-note NONE ``` @timothysc @dmmcquay @pipejakob
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162) fix error message for cronjob **What this PR does / why we need it**: fix error message for cronjob expected an error would be better than unexpected lack of error. ref: https://github.com/kubernetes/kubernetes/blob/master/cmd/genutils/genutils_test.go#L33 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162) add possibility to use multiple floatingip pools in openstack loadbalancer **What this PR does / why we need it**: Currently only one floating pool is supported in kubernetes openstack cloud provider. It is quite big issue for us, because we want run only single kubernetes cluster, but we want that external and internal services can be used. It means that we need possibility to create services with internal and external pools. **Which issue this PR fixes**: fixes #49147 **Special notes for your reviewer**: service labels is not maybe correct place to define this floatingpool id. However, I did not find any better place easily. I do not want start modifying service api structure. **Release note**: ```release-note Add possibility to use multiple floatingip pools in openstack loadbalancer ``` Example how it works: ``` cat /etc/kubernetes/cloud-config [Global] auth-url=https://xxxx username=xxxx password=xxxx region=yyy tenant-id=b23efb65b1d44b5abd561511f40c565d domain-name=foobar [LoadBalancer] lb-version=v2 subnet-id=aed26269-cd01-4d4e-b0d8-9ec726c4c2ba lb-method=ROUND_ROBIN floating-network-id=56e523e7-76cb-477f-80e4-2dc8cf32e3b4 create-monitor=yes monitor-delay=10s monitor-timeout=2000s monitor-max-retries=3 ``` ``` apiVersion: apps/v1beta1 kind: Deployment metadata: name: nginx-deployment spec: replicas: 1 template: metadata: labels: run: web spec: containers: - name: nginx image: nginx ports: - containerPort: 80 --- apiVersion: v1 kind: Service metadata: labels: run: web-ext name: web-ext namespace: default spec: selector: run: web ports: - port: 80 name: https protocol: TCP targetPort: 80 type: LoadBalancer --- apiVersion: v1 kind: Service metadata: labels: run: web-int floatingPool: a2a84887-4915-42bf-aaff-2b76688a4ec7 name: web-int namespace: default spec: selector: run: web ports: - port: 80 name: https protocol: TCP targetPort: 80 type: LoadBalancer ``` ``` % kubectl create -f example.yaml deployment "nginx-deployment" created service "web-ext" created service "web-int" created % kubectl get svc -o wide NAME CLUSTER-IP EXTERNAL-IP PORT(S) AGE SELECTOR kubernetes 10.254.0.1 <none> 443/TCP 2m <none> web-ext 10.254.23.153 192.168.1.57,193.xx.xxx.xxx 80:30151/TCP 52s run=web web-int 10.254.128.141 192.168.1.58,10.222.130.80 80:32431/TCP 52s run=web ``` cc @anguslees @k8s-sig-openstack-feature-requests @dims
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162) follow our go code style: error->err Fixes https://github.com/kubernetes/kubernetes/issues/50189 ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue simplify if and else for code Signed-off-by:allencloud <allen.sun@daocloud.io> **What this PR does / why we need it**: This PR tries to simplify the code of if and else, and this could make code a little bit cleaner. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: NONE **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Timeout and Max-in-flight don't report non-resource URLs correctly. Unify error reporting for 429 and 504 to be correct for timeout and max in flight and eviction. Add better messages to eviction (removing a todo). Return the correct body content for timeouts (reason and code should be correct). This potentially increases cardinality of 429, but because non-api urls may be under the max-inflight budget we need to report them somewhere (if something breaks and starts fetching API versions endlessly). ```release-note The 504 timeout error was returning a JSON error body that indicated it was a 500. The body contents now correctly report a 500 error. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700) Add some table printers
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700) fix swallowed error in kubectl rolling_updater This fixes a swallowed error in kubectl. AddDeploymentKeyToReplicationController() is already tested, but there was an error that was not being exposed. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700) add label examples for kubectl run **What this PR does / why we need it**: Add `--labels` examples for kubectl run **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # xref #49854 **Special notes for your reviewer**: /cc @ahmetb **Release note**: ```release-note add examples for kubectl run --labels ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700) Enable overriding fluentd resources in GCP **What this PR does / why we need it**: This enables overriding fluentd resources in GCP, when there is a need for custom ones. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700) validate cadvisor rootpath **What this PR does / why we need it**: When working on issue #48452, I found [KubeletConfiguration.RootDirectory](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/server.go#L525) was never been validated. The default value is set to ["/var/lib/kubelet"](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/componentconfig/v1alpha1/defaults.go#L342). If this directory does not exist in the file system, the [cadvisor.manager](https://github.com/kubernetes/kubernetes/blob/master/vendor/github.com/google/cadvisor/manager/manager.go#L679) will fail to gather the information for metrics. > error trying to get filesystem Device for dir /var/lib/kubelet: err: stat failed on /var/lib/kubelet with error: no such file or directory **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: /cc @feiskyer @k82cn **Release note**: ```release-note validate cadvisor rootpath ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue go-client: Use httpcache client for all requests, even though only openapi returns ETags for caching **What this PR does / why we need it**: Use HTTP ETag for caching Swagger spec download This also adds a new command-line flag "cachedir" to specify where the cache should keep its file. It defaults to `$HOME/.kube/http-cache`. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: partly #38637 **Special notes for your reviewer**: Because this adds a bunch of dependencies, and removes a couple of files, I do recommend reading each commit individually. **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update build requirements **What this PR does / why we need it**: Update the build requirements for docker so that the three configurations are shown as sub-lists instead of a parallel list. Currently, the requirements are shown in this way. 1. xxx 2. xxx 3. xxx 4. xxx 5. xxx But it should be shown as something like this: 1. xxx * xxx * xxx * xxx 2. xxx The problem is because markdown doesn't support well for ordered sub-list under ordered list. So, change it to unordered sub-list can avoid this problem.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Update OWNERS to correct members' handles **What this PR does / why we need it**: Fix some typos of members' handles as per https://github.com/kubernetes/kubernetes/issues/50048#issuecomment-319831957. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Associated with: #50048 **Special notes for your reviewer**: /cc @madhusudancs @sebgoa @liggitt @saad-ali **Release note**: ```release-note NONE ```
-
- 04 Aug, 2017 7 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add information about staging repos to README Pretty much what it sounds like.
-
Paul Morie authored
-
Antoine Pelisse authored
-
Antoine Pelisse authored
-
Antoine Pelisse authored
Add a new command-line cachedir flag to specify where to store the http cache responses. This cache will only be used for OpenAPI Swagger spec for now (as this is the only end-point that returns an ETag).
-
Antoine Pelisse authored
The cache will be removed and replaced with HTTP Etag caching instead. This patch is simply removing the existing mechanism.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50119, 48366, 47181, 41611, 49547) Task 0: Added node taints labels and feature flags **What this PR does / why we need it**: Added node taint const for node condition. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: part of #42001 **Release note**: ```release-note None ```
-