1. 06 Aug, 2017 2 commits
  2. 05 Aug, 2017 31 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #49419 from fabriziopandini/kubeadm-phase-kubeconfig2 · 48415c01
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      kubeadm: Implementing the kubeconfig phase fully
      
      **What this PR does / why we need it:**
      This contains implementation of kubeconfig phases in kubeadm, which is part of the wider effort of implementing phases in kubeadm, previously in alpha stage.
      
      The original proposal for this activity can be found [here](https://github.com/kubernetes/kubeadm/pull/156/files) and related comments.
      
      Kubeadm phase implementation checklist is defined [here](https://github.com/kubernetes/kubeadm/issues/267)
      
      Common implementation guidelines and principles for all phases are defined [here](https://docs.google.com/document/d/1VQMyFIVMfRGQPP3oCUpfjiWtOr3pLxp4g7cP-hXQFXc/edit?usp=sharing)
      
      This PR implements:
      
      - [x] kubeadm phase kubeconfig
        - [x] kubeadm phase kubeconfig all
        - [x] kubeadm phase kubeconfig admin
        - [x] kubeadm phase kubeconfig kubelet
        - [x] kubeadm phase kubeconfig scheduler
        - [x] kubeadm phase kubeconfig controller-manager
        - [x] kubeadm phase kubeconfig user
      
      **Which issue this PR fixes:**
      https://github.com/kubernetes/kubeadm/issues/350
      
      **Special notes for your reviewer:**
      
      This PR implements the second phases of kubeadm init; implementation of this PR follow the same approach already used for #48196 (cert phases).
      
      Please note that:
      - the API - phase\kubeconfig.go - is now totally free by any UX concerns, and implements only the core logic for kubeconfig generation.
      - the UX - cmd\phase\kubeconfig.go - now takes charge of UX commands and kubeadm own's rules for kubeconfig files in /etc/kubernetes folder (e.g. create only if not already exists)
      - The PR includes also a fix for a regression on a unit test for phase certs introduced by #48594 and few minor code changes in phase certs introduced to avoid code duplication between the two phases.
      48415c01
    • Kubernetes Submit Queue's avatar
      Merge pull request #50045 from ixdy/test-images-port-forward-tester · 44b0e108
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix typo in test/images/port-forward-tester/Makefile
      
      **What this PR does / why we need it**: the image build fails due to this typo:
      ```console
      $ make WHAT=port-forward-tester
      ./image-util.sh build port-forward-tester
      Building image for port-forward-tester ARCH: ppc64le...
      make[1]: Entering directory '[home]/src/k8s.io/kubernetes/test/images/port-forward-tester'
      ../image-util.sh bin
      ../image-util.sh: line 22: $2: unbound variable
      ```
      
      Images already pushed.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      /approve no-issue
      /assign @mkumatag
      44b0e108
    • Kubernetes Submit Queue's avatar
      Merge pull request #50197 from mbssaiakhil/patch-5 · de7e661a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix typos and grammatical errors in comments and variables
      de7e661a
    • Malepati Bala Siva Sai Akhil's avatar
      Fix typo in variable of remote · 0c548ea4
      Malepati Bala Siva Sai Akhil authored
      Fix typo in variable of remote_runtime.go
      0c548ea4
    • Malepati Bala Siva Sai Akhil's avatar
      Fixed typo in rkt · 84844bb6
      Malepati Bala Siva Sai Akhil authored
      Fixed typo in rkt
      84844bb6
    • Malepati Bala Siva Sai Akhil's avatar
      Fixed typo in comment in eviction_manager · ee82de56
      Malepati Bala Siva Sai Akhil authored
      Fixed typo in comment in eviction_manager
      ee82de56
    • Kubernetes Submit Queue's avatar
      Merge pull request #50052 from foxyriver/clean-install · eea9045a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49805, 50052)
      
      remove the temporary file to make the hyperkube image smaller
      
      Remove the temporary file after apt-get install to make the hyperkube image smaller.
      eea9045a
    • Kubernetes Submit Queue's avatar
      Merge pull request #49805 from nbutton23/nbutton-fix-elb-sg-bug · 207a95a0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 49805, 50052)
      
      We never want to modify the globally defined SG for ELBs
      
      **What this PR does / why we need it**:
      Fixes a bug where creating or updating an ELB will modify a globally defined security group
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50105
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      fixes a bug around using the Global config ElbSecurityGroup where Kuberentes would modify the passed in Security Group.
      ```
      207a95a0
    • Malepati Bala Siva Sai Akhil's avatar
      Fix typo in comment · 83603f03
      Malepati Bala Siva Sai Akhil authored
      Fix typo in comment in garbagecollector
      83603f03
    • Kubernetes Submit Queue's avatar
      Merge pull request #50194 from mbssaiakhil/patch-3 · 259d7d7b
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix typo in certificate
      259d7d7b
    • Malepati Bala Siva Sai Akhil's avatar
      Fix typo in certificate · f90a8253
      Malepati Bala Siva Sai Akhil authored
      f90a8253
    • fabriziopandini's avatar
      fully implement kubeadm-phase-kubeconfig · f9f91bf1
      fabriziopandini authored
      f9f91bf1
    • Kubernetes Submit Queue's avatar
      Merge pull request #50134 from m1093782566/fed-controller · b6ff77ee
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix typos in federation-controller
      
      **What this PR does / why we need it**:
      
      fix some typos in federation-controller.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b6ff77ee
    • Kubernetes Submit Queue's avatar
      Merge pull request #48141 from ankon/patch-2 · 0b9aa056
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix typo
      
      **What this PR does / why we need it**: Fix trivial typo in comment.
      0b9aa056
    • Kubernetes Submit Queue's avatar
      Merge pull request #50082 from crassirostris/cleanup-fluentd-es · 70b4db20
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48532, 50054, 50082)
      
      Refactored the fluentd-es addon
      
      Refactor fluentd-elasticsearch addon:
      
      - Decrease the number of files by moving RBAC-related objects in the same files where they're used
      - Move the fluentd configuration out of the image
      - Don't use PVC to avoid leaking resources in e2e tests
      - Fluentd now ingest docker and kubelet logs that are written to journald
      - Disable X-Pack, because it's not free
      
      Fixes https://github.com/kubernetes/kubernetes/issues/41462
      Fixes https://github.com/kubernetes/kubernetes/issues/49816
      Fixes https://github.com/kubernetes/kubernetes/issues/48973
      Fixes https://github.com/kubernetes/kubernetes/issues/49450
      
      @aknuds1 @coffeepac Could you please take a look?
      
      ```release-note
      Fluentd DaemonSet in the fluentd-elasticsearch addon is configured via ConfigMap and includes journald plugin
      Elasticsearch StatefulSet in the fluentd-elasticsearch addon uses local storage instead of PVC by default
      ```
      70b4db20
    • Kubernetes Submit Queue's avatar
      Merge pull request #50054 from msau42/e2e-cleanup · 40b4f77a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48532, 50054, 50082)
      
      Remove [k8s.io] tag and redundant [sig-storage] tags from volume tests
      
      **What this PR does / why we need it**:
      Removes redundant tags from storage e2e test names
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #50178
      
      **Release note**:
      /release-note-none
      40b4f77a
    • Kubernetes Submit Queue's avatar
      Merge pull request #48532 from YuxiJin-tobeyjin/e2ekubectl · 2f6664e5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48532, 50054, 50082)
      
        Correcting two spelling mistakes
      
      **What this PR does / why we need it**:
        Correcting two spelling mistakes.
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      NONE
      **Special notes for your reviewer**:
      NONE
      **Release note**:
      NONE
      ```release-note
      ```
      2f6664e5
    • Kubernetes Submit Queue's avatar
      Merge pull request #50162 from luxas/kubeadm_clientset_iface · bb99ccc1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162)
      
      kubeadm: Replace *clientset.Clientset with clientset.Interface
      
      **What this PR does / why we need it**:
      
      Needed for https://github.com/kubernetes/kubernetes/pull/48899
      We should always use `clientset.Interface` instead of `*clientset.Clientset`, for better testability and all the other benefits of using an interface.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      Should be straightforward to merge
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      @timothysc @dmmcquay @pipejakob
      bb99ccc1
    • Kubernetes Submit Queue's avatar
      Merge pull request #49860 from zhangxiaoyu-zidif/fix-error-print-for-cronjob-utils-test · ec424949
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162)
      
      fix error message for cronjob
      
      **What this PR does / why we need it**:
      fix error message for cronjob
      expected an error would be better than unexpected lack of error.
      ref: https://github.com/kubernetes/kubernetes/blob/master/cmd/genutils/genutils_test.go#L33
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      ec424949
    • Kubernetes Submit Queue's avatar
      Merge pull request #49697 from zetaab/mfloating · c3f4dba5
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162)
      
      add possibility to use multiple floatingip pools in openstack loadbalancer
      
      **What this PR does / why we need it**: Currently only one floating pool is supported in kubernetes openstack cloud provider. It is quite big issue for us, because we want run only single kubernetes cluster, but we want that external and internal services can be used. It means that we need possibility to create services with internal and external pools.
      
      **Which issue this PR fixes**: fixes #49147
      
      **Special notes for your reviewer**: service labels is not maybe correct place to define this floatingpool id. However, I did not find any better place easily. I do not want start modifying service api structure.
      
      **Release note**:
      ```release-note
      Add possibility to use multiple floatingip pools in openstack loadbalancer
      ```
      
      Example how it works:
      ```
      cat /etc/kubernetes/cloud-config
      [Global]
      auth-url=https://xxxx
      username=xxxx
      password=xxxx
      region=yyy
      tenant-id=b23efb65b1d44b5abd561511f40c565d
      domain-name=foobar
      
      [LoadBalancer]
      lb-version=v2
      subnet-id=aed26269-cd01-4d4e-b0d8-9ec726c4c2ba
      lb-method=ROUND_ROBIN
      floating-network-id=56e523e7-76cb-477f-80e4-2dc8cf32e3b4
      create-monitor=yes
      monitor-delay=10s
      monitor-timeout=2000s
      monitor-max-retries=3
      ```
      ```
      apiVersion: apps/v1beta1
      kind: Deployment
      metadata:
        name: nginx-deployment
      spec:
        replicas: 1
        template:
          metadata:
            labels:
              run: web
          spec:
            containers:
            - name: nginx
              image: nginx
              ports:
              - containerPort: 80
      ---
      apiVersion: v1
      kind: Service
      metadata:
        labels:
          run: web-ext
        name: web-ext
        namespace: default
      spec:
        selector:
          run: web
        ports:
        - port: 80
          name: https
          protocol: TCP
          targetPort: 80
        type: LoadBalancer
      ---
      apiVersion: v1
      kind: Service
      metadata:
        labels:
          run: web-int
          floatingPool: a2a84887-4915-42bf-aaff-2b76688a4ec7
        name: web-int
        namespace: default
      spec:
        selector:
          run: web
        ports:
        - port: 80
          name: https
          protocol: TCP
          targetPort: 80
        type: LoadBalancer
      ```
      ```
      % kubectl create -f example.yaml
      deployment "nginx-deployment" created
      service "web-ext" created
      service "web-int" created
      % kubectl get svc -o wide
      NAME         CLUSTER-IP       EXTERNAL-IP                   PORT(S)        AGE       SELECTOR
      kubernetes   10.254.0.1       <none>                        443/TCP        2m        <none>
      web-ext      10.254.23.153    192.168.1.57,193.xx.xxx.xxx   80:30151/TCP   52s       run=web
      web-int      10.254.128.141   192.168.1.58,10.222.130.80    80:32431/TCP   52s       run=web
      ```
      
      cc @anguslees @k8s-sig-openstack-feature-requests @dims
      c3f4dba5
    • Kubernetes Submit Queue's avatar
      Merge pull request #47408 from shiywang/follow-go-code-style · fa5877de
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 47416, 47408, 49697, 49860, 50162)
      
      follow our go code style: error->err
      
      Fixes https://github.com/kubernetes/kubernetes/issues/50189
      ```release-note
      NONE
      ```
      fa5877de
    • Kubernetes Submit Queue's avatar
      Merge pull request #47416 from allencloud/simplify-if-else · 58819b02
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      simplify if and else for code
      Signed-off-by: 's avatarallencloud <allen.sun@daocloud.io>
      
      **What this PR does / why we need it**:
      This PR tries to simplify the code of if and else, and this could make code a little bit cleaner.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      NONE
      
      **Special notes for your reviewer**:
      NONE
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      58819b02
    • Kubernetes Submit Queue's avatar
      Merge pull request #49678 from smarterclayton/429_metric · 8d6bbaa8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Timeout and Max-in-flight don't report non-resource URLs correctly.
      
      Unify error reporting for 429 and 504 to be correct for timeout and max in flight and eviction. Add better messages to eviction (removing a todo). Return the correct body content for timeouts (reason and code should be correct).
      
      This potentially increases cardinality of 429, but because non-api urls may be under the max-inflight budget we need to report them somewhere (if something breaks and starts fetching API versions endlessly).
      
      ```release-note
      The 504 timeout error was returning a JSON error body that indicated it was a 500.  The body contents now correctly report a 500 error.
      ```
      8d6bbaa8
    • Kubernetes Submit Queue's avatar
      Merge pull request #49700 from wanghaoran1988/convert_to_table_printer · 94abce7c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700)
      
      Add some table printers
      94abce7c
    • Kubernetes Submit Queue's avatar
      Merge pull request #49843 from alrs/kubectl-rolling_updater-swallowed-error · deb5c77c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700)
      
      fix swallowed error in kubectl rolling_updater
      
      This fixes a swallowed error in kubectl. 
      
      AddDeploymentKeyToReplicationController() is already tested, but there was an error that was not being exposed.
      
      ```release-note
      NONE
      ```
      deb5c77c
    • Kubernetes Submit Queue's avatar
      Merge pull request #49862 from dixudx/kubectl_run_labels · eeb72d78
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700)
      
      add label examples for kubectl run
      
      **What this PR does / why we need it**:
      
      Add `--labels` examples for kubectl run
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      xref #49854
      
      **Special notes for your reviewer**:
      /cc @ahmetb 
      
      **Release note**:
      
      ```release-note
      add examples for kubectl run --labels
      ```
      eeb72d78
    • Kubernetes Submit Queue's avatar
      Merge pull request #49009 from x13n/fluentd · 361079af
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700)
      
      Enable overriding fluentd resources in GCP
      
      **What this PR does / why we need it**: This enables overriding fluentd resources in GCP, when there is a need for custom ones.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      361079af
    • Kubernetes Submit Queue's avatar
      Merge pull request #48487 from dixudx/validate_cadvisor_rootpath · 7c9ba696
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48487, 49009, 49862, 49843, 49700)
      
      validate cadvisor rootpath
      
      **What this PR does / why we need it**:
      
      When working on issue #48452, I found [KubeletConfiguration.RootDirectory](https://github.com/kubernetes/kubernetes/blob/master/cmd/kubelet/app/server.go#L525) was never been validated. The default value is set to ["/var/lib/kubelet"](https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/componentconfig/v1alpha1/defaults.go#L342).
      
      If this directory does not exist in the file system, the [cadvisor.manager](https://github.com/kubernetes/kubernetes/blob/master/vendor/github.com/google/cadvisor/manager/manager.go#L679) will fail to gather the information for metrics.
      
      > error trying to get filesystem Device for dir /var/lib/kubelet: err: stat failed on /var/lib/kubelet with error: no such file or directory
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      /cc @feiskyer @k82cn
      
      **Release note**:
      
      ```release-note
      validate cadvisor rootpath
      ```
      7c9ba696
    • Kubernetes Submit Queue's avatar
      Merge pull request #47353 from apelisse/http-cache · fc89743d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      go-client: Use httpcache client for all requests, even though only openapi returns ETags for caching
      
      **What this PR does / why we need it**: Use HTTP ETag for caching Swagger spec download
      
      This also adds a new command-line flag "cachedir" to specify where the cache should keep its file. It defaults to `$HOME/.kube/http-cache`.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: partly #38637
      
      **Special notes for your reviewer**:
      Because this adds a bunch of dependencies, and removes a couple of files, I do recommend reading each commit individually.
      
      **Release note**:
      ```release-note
      ```
      fc89743d
    • Kubernetes Submit Queue's avatar
      Merge pull request #50172 from mingzhaodotname/patch-1 · 29ab38e8
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Update build requirements
      
      **What this PR does / why we need it**:
      Update the build requirements for docker so that the three configurations are shown as sub-lists instead of a parallel list. 
      
      Currently, the requirements are shown in this way.
      1. xxx
      2. xxx
      3. xxx
      4. xxx
      5. xxx
      
      But it should be shown as something like this:
      1. xxx
        * xxx
        * xxx
        * xxx
      2. xxx
      
      The problem is because markdown doesn't support well for ordered sub-list under ordered list. So, change it to unordered sub-list can avoid this problem.
      29ab38e8
    • Kubernetes Submit Queue's avatar
      Merge pull request #50133 from xiangpengzhao/update-owner · ed481a07
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Update OWNERS to correct members' handles
      
      **What this PR does / why we need it**:
      Fix some typos of members' handles as per https://github.com/kubernetes/kubernetes/issues/50048#issuecomment-319831957.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      Associated with: #50048
      
      **Special notes for your reviewer**:
      /cc @madhusudancs @sebgoa @liggitt @saad-ali
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      ed481a07
  3. 04 Aug, 2017 7 commits