1. 17 Jan, 2018 7 commits
    • Gavin's avatar
      create auto-gen files · f653d02b
      Gavin authored
      f653d02b
    • Gavin's avatar
      bb5e156a
    • Kubernetes Submit Queue's avatar
      Merge pull request #58248 from mikedanese/rm-salt · 58547ebd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      cluster: remove salt
      
      Nothing uses it directly. There were some dangling dependencies from GCE and Centos kube-ups, so I just copied them into respective dirs.
      
      see #49213
      
      ```release-note
      Remove deprecated and unmaintained salt support. kubernetes-salt.tar.gz will no longer be published in the release tarball.
      ```
      58547ebd
    • Kubernetes Submit Queue's avatar
      Merge pull request #58345 from rootfs/azure-missing-disk · 23881a90
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58319, 58345). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      azure disk: if the disk is not found, immediately detach it. This prevents azure keeps the bad request and stops issuing new request
      
      **What this PR does / why we need it**:
      Detach and clear bad disk URI
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #58344
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      23881a90
    • Kubernetes Submit Queue's avatar
      Merge pull request #58319 from vikaschoudhary16/grpc-conn-error · 43924b1d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 58319, 58345). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Call Dial in blocking mode
      
      **What this PR does / why we need it**:
      # Tests which uncover underlying problem
      On the current master code:
      1. comment out stub plugin server start [here](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/cm/deviceplugin/endpoint_test.go#L127-L128)
      2. run `go test  -v k8s.io/kubernetes/pkg/kubelet/cm/deviceplugin --run TestNewEndpoint --count 1`. Test succeeds.
      3. run `go test  -v k8s.io/kubernetes/pkg/kubelet/cm/deviceplugin --run TestRun --count 1`. Test hangs with:
      > listAndWatch ended unexpectedly for device plugin mock with error rpc error: code = Unavailable desc = grpc: the connection is unavailable
      
      `2` does not fail even though it invokes Dial and no listening server is running. It is because currently Dial is not waiting till the connection turns to Ready state. And this case does not invokes any RPC call over the `conn` returned by `Dial`
      
      `3` hangs because this tests involves actual usage of `conn`(client) and there it does not find listening server because we dint start and deliberately stopped in `1`.
      
      `Dial` should be using `WithBlock` option which ensures that `conn` is returned only when connection is in `Ready` state.
      
      After using `WithBlock` in the `Dial`, in this PR, if `1`, `2` and `3` are repeated. Both, `2` and `3`, fails at `Dial`, which is expected behavior. By `fail`, I meant Dial blocks forever if `WithTimeout` is not used or otherwise, a timeout failure.
      
      
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #58281
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      None
      ```
      /area hw-accelerators
      /sig node
      /cc  @jiayingz @RenaudWasTaken @vishh @ScorpioCPH @sjenning @derekwaynecarr @jeremyeder @lichuqiang @tengqm
      43924b1d
    • Anago GCB's avatar
      Update CHANGELOG-1.8.md for v1.8.7. · e35d67e0
      Anago GCB authored
      e35d67e0
    • Kubernetes Submit Queue's avatar
      Merge pull request #58293 from deads2k/cli-18-fail · c67a5e4f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fail earlier on discovery failures
      
      When discovery fails, the object mapper and typer are incomplete.  This change reflects that and returns errors instead of nils.
      
      @juanvallejo
      c67a5e4f
  2. 16 Jan, 2018 33 commits