1. 01 May, 2018 9 commits
  2. 30 Apr, 2018 16 commits
  3. 29 Apr, 2018 8 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #62534 from nicolasbigler/duplicate-iptables-comment · 03c5f298
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix duplicate comment in iptables rule for non-local public-port rule
      
      **What this PR does / why we need it**:
      
      When kubernetes creates an iptable rule for "from-non-local public-port"
      rule the rule gets created with two identical comment section.
      
      The function `iptablesNonLocalNodePortArgs` creates a list of arguments
      for the rule from iptablesCommonPortalArgs function. This function
      already appends the arguments for the rules comments and therefore does
      not require appending the comment again.
      
      **Special notes for your reviewer**:
      
      I'm actually not a go programmer at all and have no idea how your tests work.
      I doubt that my fix will require adjustements on tests but I'm not 100% sure.
      If additional work is needed, I would be glad if someone could point it out to me so I can take care of it.
      
      **Release note**:
      ```release-note
      NONE
      ```
      03c5f298
    • Kubernetes Submit Queue's avatar
      Merge pull request #61874 from Pingan2017/changelog1-10 · 8a006e67
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      correct CHANGELOG-1.10.md
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      8a006e67
    • Kubernetes Submit Queue's avatar
      Merge pull request #62581 from Pharb/changelog-1.10-etcd · 9ac547fd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      1.10 CHANGELOG: Fix supported etcd version comparison with K8s v1.9
      
      **What this PR does / why we need it**:
      This updates the 1.10 CHANGELOG to correctly state that the supported etcd server version in v1.9 is 3.1.10.
      This also corrects the reference to the pull request which updated the etcd version for v1.10. 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      9ac547fd
    • Kubernetes Submit Queue's avatar
      Merge pull request #62497 from MrHohn/endpoint-controller-headless-ports · dfba1c1f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Fix a bug that headless service without ports fails to have endpoint created.
      
      **What this PR does / why we need it**:
      Follow up of https://github.com/kubernetes/kubernetes/pull/47250. Headless service without ports fails to have corresponding endpoint created because endpoint controller deliberately attaches a dummy endpointPort with portNum=0, which will fail API validation check. Error as below:
      ```
      endpoints_controller.go:375] Error syncing endpoints for service "default/XXX": Endpoints "XXX" is invalid: subsets[0].ports[0].port: Invalid value: 0: must be between 1 and 65535, inclusive
      ```
      
      This PR makes endpoint controller not attach the dummy endpointPort for headless service.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #55158, fixes #62440 
      
      **Special notes for your reviewer**:
      cc @xiangpengzhao 
      
      **Release note**:
      
      ```release-note
      Fix a bug that headless service without ports fails to have endpoint created.
      ```
      dfba1c1f
    • Kubernetes Submit Queue's avatar
      Merge pull request #62438 from MrHohn/ep-controller-owner · b16d054e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add approvers to pkg/controller/endpoint
      
      **What this PR does / why we need it**:
      Promoting reviewers listed in pkg/controller/endpoint to approvers.
      
      /assign @thockin 
      cc @bowei 
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #NONE 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      b16d054e
    • Kubernetes Submit Queue's avatar
      Merge pull request #62852 from serathius/prometheus-statefulset · f8fea90d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      [Prometheus addon] Use StatefulSet
      
      This PR changes prometheus server manifest from deployment to statefulset. 
      Version label is removed from pods because statefulset disallows updating selectors.
      
      ```release-note
      NONE
      ```
      /cc @branch @kawych
      f8fea90d
    • Kubernetes Submit Queue's avatar
      Merge pull request #63271 from ceshihao/clean_test_util · a4d2a3a4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Move pkg/scheduler/util/testutil.go to pkg/scheduler/testing
      
      **What this PR does / why we need it**:
      In the package `k8s.io/kubernetes/pkg/scheduler/util`, we have testutil.go, which has an init() function. Since this package is imported in production code, we are inadvertently running test code in production.
      
      Fortunately (depending on how you look at it) scheduler already has a package called `k8s.io/kubernetes/pkg/scheduler/testing` which would be an appropriate home for these utils.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #63269
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      a4d2a3a4
    • Kubernetes Submit Queue's avatar
      Merge pull request #56568 from zouyee/sync · 2716de27
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      sync code from copy destination
      
      **What this PR does / why we need it**:
      sync code from copy destination
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```
      NONE
      
      ```
      2716de27
  4. 28 Apr, 2018 7 commits