1. 13 Aug, 2018 3 commits
    • Xianglin Gao's avatar
    • Xianglin Gao's avatar
      Move defaultKubeConfig to constants.go · 866631fa
      Xianglin Gao authored
      Signed-off-by: 's avatarXianglin Gao <xianglin.gxl@alibaba-inc.com>
      866631fa
    • Kubernetes Submit Queue's avatar
      Merge pull request #65803 from honkiko/ipvs-add-addrtype-match · 4492337d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      ipvs: add addrtype match for nodeport
      
      **What this PR does / why we need it**:
      before this PR:
      ```
      -A KUBE-SERVICES -m comment --comment "Kubernetes nodeport TCP port for masquerade purpose" -m set --match-set KUBE-NODE-PORT-TCP dst -j KUBE-NODE-PORT
      -A KUBE-SERVICES -m comment --comment "Kubernetes service cluster ip + port for masquerade purpose" -m set --match-set KUBE-CLUSTER-IP dst,dst -j KUBE-MARK-MASQ
      -A KUBE-SERVICES -m set --match-set KUBE-CLUSTER-IP dst,dst -j ACCEPT
      -A KUBE-NODE-PORT -p tcp -m comment --comment "Kubernetes nodeport TCP port with externalTrafficPolicy=local" -m set --match-set KUBE-NODE-PORT-LOCAL-TCP dst -j RETURN
      -A KUBE-NODE-PORT -j KUBE-MARK-MASQ
      ```
      after this PR:
      ```
      -A KUBE-NODE-PORT -p tcp -m comment --comment "Kubernetes nodeport TCP port with externalTrafficPolicy=local" -m set --match-set KUBE-NODE-PORT-LOCAL-TCP dst -j RETURN
      -A KUBE-NODE-PORT -p tcp -m comment --comment "Kubernetes nodeport TCP port for masquerade purpose" -m set --match-set KUBE-NODE-PORT-TCP dst -j KUBE-MARK-MASQ
      -A KUBE-SERVICES -m comment --comment "Kubernetes service cluster ip + port for masquerade purpose" -m set --match-set KUBE-CLUSTER-IP dst,dst -j KUBE-MARK-MASQ
      -A KUBE-SERVICES -m set --match-set KUBE-CLUSTER-IP dst,dst -j ACCEPT
      -A KUBE-SERVICES -m addrtype --dst-type LOCAL -j KUBE-NODE-PORT
      ```
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #65459
      
      **Special notes for your reviewer**:
      manually tested cases:
      - ClusterIP distributed to pod on same node
      - ClusterIP distributed to pod on other node
      - NodePort distributed to pod on same node
      - NodePort distributed to pod on other node
      
      **Release note**:
      
      ```release-note
      
      ```
      4492337d
  2. 12 Aug, 2018 1 commit
  3. 11 Aug, 2018 17 commits
  4. 10 Aug, 2018 19 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #67017 from bart0sh/PR0027-kubeadm-fix-CRI-ListKubeContainers · 95307254
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm: fix CRI ListKubeContainers API
      
      **What this PR does / why we need it**:
      
      Current implementation of this API always returns
      checks output of 'crictl pods -q' and filters out everything
      that doesn't start with k8s_. 'crictl pods -q' returns only pod ids,
      so everything is always filtered out.
      
      Removing filtering by name prefix should fix this.
      
      **Which issue this PR fixes**
      Fixes: kubernetes/kubeadm#926
      
      **Release note**:
      ```release-note
      NONE
      ```
      95307254
    • Deep Debroy's avatar
      0417b21d
    • Jeff Grafton's avatar
      Update to use debian-base:0.3.2 · 296fe185
      Jeff Grafton authored
      296fe185
    • Jeff Grafton's avatar
      Add missing tmpdir path to chmod · df788bd6
      Jeff Grafton authored
      df788bd6
    • Kubernetes Submit Queue's avatar
      Merge pull request #67275 from spiffxp/owners-label-kind-api-change · 819253dd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Use OWNERS-based labeling for kind/api-change
      
      **What this PR does / why we need it**:
      
      This replaces the following path-label munger config, except
      we're using kind/api-change for everything instead of two
      different kind/ labels
      
      ```
      ^pkg/api/([^/]+/)?types.go$    kind/api-change
      ^pkg/api/([^/]+/)?register.go$ kind/new-api
      ^pkg/apis/[^/]+/([^/]+/)?types.go$    kind/api-change
      ^pkg/apis/[^/]+/([^/]+/)?register.go$ kind/new-api
      ```
      
      This fixes https://github.com/kubernetes/test-infra/issues/9007
      
      **Special notes for your reviewer**:
      This can be merged independently of us turning path-label off of
      mungegithub. While both labeling options are active, they won't
      clash, just race. 
      
      ```release-note
      NONE
      ```
      819253dd
    • Kubernetes Submit Queue's avatar
      Merge pull request #66332 from jianglingxia/jlx-k8s-201807181704 · 6696ae39
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66602, 67178, 67207, 67125, 66332). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add UT to RBD volume test of TestGetAccessModes and TestRequiresRemount
      
      **What this PR does / why we need it**:
      Add UT to RBD volume test of TestGetAccessModes and TestRequiresRemount
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      6696ae39
    • Kubernetes Submit Queue's avatar
      Merge pull request #67125 from isaacdong/patch-1 · 1b4f2e1f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66602, 67178, 67207, 67125, 66332). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix get-kube-local.sh 2 wrong parameters.
      
      **bug fix**
      1. run ./get-kube-local.sh, and get this error.
      >  ./get-kube-local.sh: line 60: 2: unbound variable
      2. remove duplicate filename in docker run command: `--kubeconfig=${KUBELET_KUBECONFIG}`
      
      **Special notes for your reviewer**:
      code detail:
      line 88: create-kubelet-kubeconfig "${KUBELET_KUBECONFIG}" 
      line 59: function create-kubelet-kubeconfig() {
      line 60:  local destination="${1}"
      
      **Release note**:
      
      ```release-note
            NONE
      ```
      1b4f2e1f
    • Kubernetes Submit Queue's avatar
      Merge pull request #67207 from luxas/remove_shared_config_defaulting · 94a754c7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66602, 67178, 67207, 67125, 66332). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Remove defaulting from shared ComponentConfig types
      
      **What this PR does / why we need it**:
      
      As @deads2k commented in kubernetes/community#2354, we should not register defaults for the shared componentconfig types as it gets very hard for consumer to opt-out of the default defaulting funcs. Instead, the package provides a  `DefaultFoo` function the consuming API group can call if it wants to as an opt-in in `SetDefaults_Bar` (where `Bar` wraps `Foo` as a field)
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      ref: kubernetes/community#2354
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      /assign @sttts @liggitt @deads2k
      94a754c7
    • Kubernetes Submit Queue's avatar
      Merge pull request #67178 from cblecker/cfssl · 818e632c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66602, 67178, 67207, 67125, 66332). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Vendor cfssl/cfssljson utilities
      
      **What this PR does / why we need it**:
      Vendors the `cfssl` and `cfssljson` tools. Updates `kube::util::ensure-cfssl` to use them.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      fixes #66995, fixes #60070
      
      **Special notes for your reviewer**:
      1. Add cfssl/cfssljson ot the required bins for saving
      2. Manually cloned/checked out the new dependencies to my gopath. `godep restore` doesn't pull them down because they aren't required or already in the `Godeps.json`. Used @BenTheElder's list here: https://github.com/kubernetes/kubernetes/issues/66995#issuecomment-410594532
      3. `hack/godep-save.sh` to add the packages and dependencies to godep
      4. Fixed two bugs when building:
        a. `golang.org/x/crypto` needed to be updated
        b. `github.com/cloudflare/cfssl` needed to be updated to https://github.com/cloudflare/cfssl/commit/56268a613adfed278936377c18b1152d2c4ad5da so we can vendor their fork of `crypto/tls`, as we discard their modified vendored stdlib.
      5. Update staging godeps
      6. Update the `kube::util::ensure-cfssl` to install from vendor
      
      **Release note**:
      ```release-note
      NONE
      ```
      818e632c
    • Kubernetes Submit Queue's avatar
      Merge pull request #66602 from dixudx/kubectl_apply_force_invalid · 0e62573d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 66602, 67178, 67207, 67125, 66332). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubectl: recreating resources for immutable fields when force is applied
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #66390
      
      **Special notes for your reviewer**:
      /assign soltysh juanvallejo
      /cc @kubernetes/sig-cli-bugs 
      
      **Release note**:
      
      ```release-note
      kubectl: recreating resources for immutable fields when force is applied
      ```
      0e62573d
    • Aaron Crickenberger's avatar
      Use OWNERS-based labeling for kind/api-change · d0b25959
      Aaron Crickenberger authored
      This replaces the following path-label munger config, except
      we're using kind/api-change for everything instead of two
      different kind/ labels
      
      ```
      ^pkg/api/([^/]+/)?types.go$    kind/api-change
      ^pkg/api/([^/]+/)?register.go$ kind/new-api
      ^pkg/apis/[^/]+/([^/]+/)?types.go$    kind/api-change
      ^pkg/apis/[^/]+/([^/]+/)?register.go$ kind/new-api
      ```
      d0b25959
    • Sean Sullivan's avatar
      083f0e3d
    • Kubernetes Submit Queue's avatar
      Merge pull request #67200 from bclau/fix-autoscaling-tests-skip · c8ffbe3e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      tests: Skips AfterEach step if provider is not supported
      
      **What this PR does / why we need it**:
      
      The BeforeEach step for cluster_size_autoscaling is skipped if
      the provider is not gce or gke. The AfterEach step should also
      be skipped, since nothing was done.
      
      **Which issue(s) this PR fixes**:
      Fixes #67199
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      c8ffbe3e
    • Kubernetes Submit Queue's avatar
      Merge pull request #65420 from jsoref/issue-61739 · df439192
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Remove --interactive flag from kubectl logs
      
      fixes #61739
      
      ```release-note
      Remove deprecated --interactive flag from kubectl logs.
      ```
      df439192
    • Kubernetes Submit Queue's avatar
      Merge pull request #65485 from ravisantoshgudimetla/owner · 6d8a317f
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add ravi to sig scheduling approvers
      
      **What this PR does / why we need it**:
      According to the requirement of Approver at community-membership.md, I meet the following requirements so I'd like to add myself as an approver of scheduler.
      
      I have :
      
      - Authored more than ~40 commits to k/k repository and 22 commits in kube-incubator/descheduler.
      - Been co-maintainer on descheduler.
      - Been a reviewer for more than 3 months.
      - Reviewed/helped in reviewing more than 70 PRs.
      - Been helping new contributors in getting upto speed and guide them on performance aspects of the kube-scheduler.
      
      As an approver,
      
      -   I agree to only approve familiar PRs
      -   I agree to be responsive to review/approve requests as per community expectations
      -   I agree to continue my reviewer work as per community expectations
      -   I agree to continue my contribution, e.g. PRs, mentor contributors
      
      
      ```release-note
      NONE
      ```
      
      /cc @bsalamat @k82cn @aveshagarwal
      6d8a317f
    • Kubernetes Submit Queue's avatar
      Merge pull request #67219 from seans3/rbac-dependency · 8174d841
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Move validation dependency from pkg/apis/core/validation to staging
      
      **What this PR does / why we need it**:
      
      Moves a dependency in metricsutil from `pkg/apis/core/validation` to the staging dependency.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      
      Helps Fix: **Remove Kubectl dependencies on kubernetes/pkg/api and kubernetes/pkg/apis**
      https://github.com/kubernetes/kubectl/issues/83
      
      **Special notes for your reviewer**:
      
      ```release-note
      NONE
      ```
      8174d841
    • Aaron Crickenberger's avatar
      macOS and docker for mac don't play nicely with mktemp · 2de8daf0
      Aaron Crickenberger authored
      On macOS mktemp -d drops something in /var/folders, which isn't
      shared by default with Docker for Mac. Thus I can't run docker
      with that volume mounted to build binaries for test images. So
      instead, tell mktemp to use kubernetes/_tmp as its base, which
      is what I see some of the hack/verify-* scripts use.
      2de8daf0
    • Kubernetes Submit Queue's avatar
      Merge pull request #67176 from charrywanganthony/auditv1beta1Tov1_utils · 5de3896d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      use v1 version of advanced audit policy in kubeadm
      
      audit api version has been updated to v1 #65891 
      
      **Release note**:
      ```release-note
      kubeadm uses audit policy v1 instead of v1beta1
      ```
      5de3896d
    • Kubernetes Submit Queue's avatar
      Merge pull request #67131 from rosti/kube-proxy-manifest-fix2 · cd06fd4a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm: Deduplicate kube-proxy image logic
      
      **What this PR does / why we need it**:
      
      Until now, kube-proxy image was handled in two separate places:
          
      - In images.go along with the pre-pull code and without having the image override capabilities (via UnifiedControlPlaneImage)
      
      - In the kube-proxy manifest, where image override was possible.
      
      This duplicates the kube-proxy image logic and makes it prone to errors.
      Therefore, this change aims to deduplicate it and make it more straightforward.
      This is achieved in the following ways:
      
      - GetKubeControlPlaneImage is used for kube-proxy image fetching, thus allowing for the image to be overriden by UnifiedControlPlaneImage.
      
      - Remove duplicated logic from the manifest and use GetKubeControlPlaneImage to generate the image for the manifest.
      
      This PR also removes GetKubeControlPlaneImageNoOverride as it's no longer needed.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      None
      
      **Special notes for your reviewer**:
      
      /cc @kubernetes/sig-cluster-lifecycle-pr-reviews
      /area kubeadm
      /assign @luxas
      /assign @timothysc
      
      **Release note**:
      
      ```release-note
      kubeadm: make sure pre-pulled kube-proxy image and the one specified in its daemon set manifest are the same
      ```
      cd06fd4a