- 19 Apr, 2018 40 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. wire print flags through apply cmd **Release note**: ```release-note NONE ``` Depends on https://github.com/kubernetes/kubernetes/pull/62300 Adds PrintFlags to `apply` command. cc @soltysh @deads2k
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. simplify the client cache We created the client cache back when we negotiated versions to create a config and a client. Now we don't, so this is just debt. This removes all the obvious places. I'll open a separate WIP to try to kill the rest. @kubernetes/sig-cli-maintainers @soltysh ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62642, 62855, 62487, 62858, 62873). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Make pod status to Running if some are Running and some are Completed **What this PR does / why we need it**: Make pod status to Running if some are Running and some are Completed **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #62588 **Special notes for your reviewer**: Only Set Pod status to Completed when no other reason, no Running container and only Completed containers. Set status to Running if some are Running and some are Completed **Release note**: ```release-note Set pod status to "Running" if there is at least one container still reporting as "Running" status and others are "Completed". ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Separate pod priority from preemption **What this PR does / why we need it**: Users request to split priority and preemption feature gate so they can use priority separately. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #62068 **Special notes for your reviewer**: ~~I kept use `ENABLE_POD_PRIORITY` as ENV name for gce cluster scripts for backward compatibility reason. Please let me know if other approach is preffered.~~ ~~This is a potential **break change** as existing clusters will be affected, we may need to include this in 1.11 maybe?~~ TODO: update this doc https://kubernetes.io/docs/concepts/configuration/pod-priority-preemption/ [Update] Usage: in config file for scheduler: ```yaml apiVersion: componentconfig/v1alpha1 kind: KubeSchedulerConfiguration ... disablePreemption: true ``` **Release note**: ```release-note Split PodPriority and PodPreemption feature gate ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Use shorter timeout when we expecting failure **What this PR does / why we need it**: Use shorter timeout when we wait pod to not be running or PVC to not be bound **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #55174 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. update comments for local volume **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # https://github.com/kubernetes/kubernetes/issues/62278 **Special notes for your reviewer**: /assign @jsafrane @msau42 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add support to resize Portworx volume Signed-off-by:
Harsh Desai <harsh@portworx.com> **What this PR does / why we need it**: This PR adds support in the Portworx volume plugin to expand an existing PVC. **Which issue(s) this PR fixes**: Closes #62305 **Release note**: ```release-note Add support to resize Portworx volumes. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59592, 62308, 62523, 62635, 62243). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Roundtrip test helper for external types **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #54698 **Special notes for your reviewer**: /assign @deads2k @sttts Since you've asked for it in the original issue. The FIXME I've pointed out to is worth addressing, but I'd prefer to do it afterwards. Do we want to implement appropriate test for all the api groups from `k8s.io/api` ? **Release note**: ```release-note NONE ```
-
Anago GCB authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add ut for kuberuntime-gc **What this PR does / why we need it**: Add ut for kuberuntime-gc to cover more situations: 1) Add two uncovered cases to test sandbox-gc (1) When there are more than one exited sandboxes,the older exited sandboxes without containers for existing pods should be garbage collected; (2) Even though there are more than one exited sandboxes,the older exited sandboxes with containers for existing pods should not be garbage collected. 2) Add one uncovered case to test container-gc (1) To cover the situation when allSourcesReady is set false; **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note "NONE" ```
-
Harsh Desai authored
Closes #62305 Signed-off-by:
Harsh Desai <harsh@portworx.com> update comment and variable references to GiB Signed-off-by:
Harsh Desai <harsh@portworx.com> explicitly check volume size after resize and fix size volume spec Signed-off-by:
Harsh Desai <harsh@portworx.com> If Portworx volume is already greater than new size, skip resize Signed-off-by:
Harsh Desai <harsh@portworx.com> Allow updated volume to be greater than requested size Signed-off-by:
Harsh Desai <harsh@portworx.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62726, 60085, 62583). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update github.com/stretchr/testify to v1.2.1 cd $GOPATH/src/k8s.io/kubernetes hack/godep-restore.sh rm -rf Godeps rm -rf vendor hack/godep-save.sh **What this PR does / why we need it**: v1.2.1 of Testify includes new functions (e.g., ElementsMatch) that make it easier to compare data structures such as slices. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62726, 60085, 62583). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove podpreset in local up cluster This was enabled in 6a7aca31, but shouldn't have been since the podpreset implementation is in the process of being moved into service-catalog. Release note: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62726, 60085, 62583). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Refactor kubeadm api validation. **What this PR does / why we need it**: This PR refactor kubeadm api validation to use field json name. When users get a validation error, they can easily know which field is invalid in their config files. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: @fabriziopandini I remember we mentioned this refactoring in some comment. I didn't see this change was done, so I send this PR to address this. **Release note**: ```release-note NONE ```
-
David Eads authored
-
juanvallejo authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add metrics to cinder volume **What this PR does / why we need it**: We need cinder volume metrics to be exposed **Which issue(s) this PR fixes**: Fixes #62644 **Special notes for your reviewer**: This is not tested in running cluster. **Release note**: ```release-note Make volume usage metrics available for Cinder ``` cc @gnufied @dims
-
Anago GCB authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62632, 62789, 62512, 62848). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. use recordFlags to manage recording This updates the set commands to use the recordflags and updates the commands we're touching to follow the pattern that is emerging. A method for New*Options, a valid default value for a recorder there, using the value `o` everywhere to refer to options, naming the struct `<commandName>Options`. @kubernetes/sig-cli-maintainers @soltysh @juanvallejo continues the effort ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62632, 62789, 62512, 62848). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. kubectl stops rendering List as suffix kind name for CRD resources **What this PR does / why we need it**: `List` should not be treated as suffix when validating CRD objects. Removing this validation won't break anything. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #62410 **Special notes for your reviewer**: /assign liggitt deads2k /cc nikhita soltysh **Release note**: ```release-note kubectl stops rendering List as suffix kind name for CRD resources ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62632, 62789, 62512, 62848). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [prometheus addon] Use secure kubelet port This PR changes port used by prometheus server to kubelet secure port. To access endpoints for metrics it adds "nodes/metrics" resource to rbac. Previously it was not possible to authorize to kubelet in GCP, because Token Auth was disabled. PR that enabled Token Auth in GCP https://github.com/kubernetes/kubernetes/pull/58178 ```release-note NONE ``` /cc @brancz @kawych
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix garbled code in kubeadm output **What this PR does / why we need it**: This fixes the garbled code:  **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62803, 62787). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add `volumenameprefix` tests for glusterfs dynamic provisioner. Signed-off-by:
Humble Chirammal <hchiramm@redhat.com> **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Van Tu authored
cd $GOPATH/src/k8s.io/kubernetes hack/godep-restore.sh rm -rf Godeps rm -rf vendor hack/godep-save.sh hack/update-staging-godeps.sh
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove flags deprecated in 1.5 This removes --include-extended-apis which was deprecated back in https://github.com/kubernetes/kubernetes/pull/32894 ```release-note Removes --include-extended-apis which was deprecated back in https://github.com/kubernetes/kubernetes/pull/32894 ```
-
Di Xu authored
-
David Eads authored
-
David Eads authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix ipvs delay on sync rules **What this PR does / why we need it**: Fix most of flaky test cases in `gci-gce-ipvs` CI. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #62839 **Special notes for your reviewer**: Make sure `proxier.initialized` be successfully set. **Release note**: ```release-note NONE ```
-
Lion-Wei authored
-
Marek Siarkowicz authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62781, 62815). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update kubeadm upgrade message **What this PR does / why we need it**: Updates kubeadm upgrade message per user request **Which issue(s) this PR fixes**: Fixes https://github.com/kubernetes/kubeadm/issues/672 **Special notes for your reviewer**: none **Release note**: ``` NONE ``` /cc @kubernetes/sig-cluster-lifecycle-pr-reviews @kargakis
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. [prometheus addon] Add OWNERS file This PR adds owners from sig-instrumentation to prometheus addon ```release-note NONE ``` cc @piosz @brancz @kawych
-
ceshihao authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62510, 61689). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Extend kubectl describe for networkPolicy **What this PR does / why we need it**: Recently `networkpolicy` was allowed podSelector and namespaceSelector to be specified together in a NetworkPolicyPeer, so we need to extend `kubectl describe` for networkpolicy. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes kubernetes/kubectl#376 **Special notes for your reviewer**: Here is the example output of `kubectl describe networkpolicies`: NetworkPolicy file: ```yaml apiVersion: networking.k8s.io/v1 kind: NetworkPolicy metadata: name: test-network-policy namespace: default spec: podSelector: matchLabels: role: db ingress: - from: - namespaceSelector: matchLabels: project: myproject podSelector: matchLabels: role: frontend ports: - protocol: TCP port: 6379 egress: - to: - namespaceSelector: matchLabels: project: myproject podSelector: matchLabels: role: frontend ports: - protocol: TCP port: 6379 ``` describe: ```shell # ./kubectl describe netpol test-network-policy Name: test-network-policy Namespace: default Created on: 2018-03-26 15:20:11 +0800 CST Labels: <none> Annotations: <none> Spec: PodSelector: role=db Allowing ingress traffic: To Port: 6379/TCP From NamespaceSelector: project=myproject PodSelector: role=frontend Allowing egress traffic: To Port: 6379/TCP To NamespaceSelector: project=myproject PodSelector: role=frontend Policy Types: Ingress, Egress ``` **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62510, 61689). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. clean unused error type variable **What this PR does / why we need it**: The function which invoked this variable was removed by https://github.com/kubernetes/kubernetes/pull/58725/ **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Yecheng Fu authored
- Add PodStartShortTimeout and ClaimProvisionShortTimeout constants. - Change framework.PodStartTimeout to framework.PodStartShortTimeout in persistent_volumes-local.go. Busybox image is very small, no need to wait for a long time.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62481, 62643, 61877, 62515). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add write-config-to to scheduler **What this PR does / why we need it**: Scheduler should be able to write its default configure to file. This actually applies to all components which claims options other than `--config` will be deprecated. Otherwise, users will be super confused to find out how to write a proper config file to these components. See: https://stackoverflow.com/questions/47966440/how-to-create-a-config-file-for-kube-scheduler-to-use-by-the-config-argument ref: #52562 **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes #58805 Usage: ```bash ./_output/bin/kube-scheduler --write-config-to /tmp/kube-scheduler.yaml ``` **Special notes for your reviewer**: This should have been fixed several releases ago, so lets include it in 1.11 **Release note**: ```release-note Add write-config-to to scheduler ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62481, 62643, 61877, 62515). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove deprecated ExternalID This field has been deprecated since 1.1. After we remove it we can remove "self delete" from the node's permission set. @kubernetes/api-reviewers @kubernetes/sig-auth-pr-reviews fixes https://github.com/kubernetes/kubernetes/issues/61966 part of https://github.com/kubernetes/community/pull/911 ```release-note Kubelets will no longer set `externalID` in their node spec. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 62481, 62643, 61877, 62515). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Not validating front proxy CA Key when using External CA. **What this PR does / why we need it**: "That the front ca key is not required as the front proxy client tls keypair can be managed by the third party." This PR don't validate the front CA Key but check if it already exists. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes https://github.com/kubernetes/kubeadm/issues/752 **Special notes for your reviewer**: @yanndegat @timothysc @stealthybox @fabriziopandini **Release note**: ```release-note NONE ```
-