- 09 Feb, 2018 5 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59344, 59595, 59598). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Update cadvisor to 6116f265302357cbb10f84737af30b1f13ce2d6c Update cadvisor to 6116f265302357cbb10f84737af30b1f13ce2d6c. For * containerd integration performance optimization: https://github.com/google/cadvisor/commit/1dd94694690a56df4d8b7bf38db3e1d1bd887976 * overlay bug fix: https://github.com/google/cadvisor/commit/812cc819acc5ebc353b9992f43411f5b750d313c @kubernetes/sig-node-pr-reviews @dashpole /cc @thockin for vendor review. Signed-off-by:
Lantao Liu <lantaol@google.com> **Release note**: ```release-note none ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59344, 59595, 59598). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix kubeadm typo **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. AWS: Do not ignore errors from EC2::DescribeVolume in DetachDisk The DetachDisk method of AWS cloudprovider indirectly calls EC2::DescribeVolume AWS API function to check if the volume being detached is really attached to the specified node. The AWS API call may fail and return error which is logged however the DetachDisk then finishes successfully. This may cause the AWS volumes to remain attached to the instances forever because the attach/detach controller will mark the volume as attached. The PV controller will never be able to delete those disks and they need to be detached manually. This patch ensures the error from DescribeVolume is propagated to attach/detach controller and the detach operation is re-tried. cc: @gnufied, @jsafrane ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59580, 58854). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Prefer apps/v1 storage for daemonsets, deployments, replicasets, statefulsets The workload API objects went GA in 1.9. This means we can safely begin persisting them in etcd in apps/v1 format in 1.10. xref #43214 ```release-note DaemonSet, Deployment, ReplicaSet, and StatefulSet objects are now persisted in etcd in apps/v1 format ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. remove CAdvisorPort from KubeletConfiguration struct See: #56523, cAdvisor is becoming an implementation detail of Kubernetes, and we should not canonize its knobs on the KubeletConfiguration. ```release-note NONE ```
-
- 08 Feb, 2018 35 commits
-
-
Lantao Liu authored
Signed-off-by:Lantao Liu <lantaol@google.com>
-
Michael Taufen authored
See: #56523, cAdvisor is becoming an implementation detail of Kubernetes, and we should not canonize its knobs on the KubeletConfiguration.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Extract instantiation of cloud provider **What this PR does / why we need it**: Add a separate method in a new file for creating cloud providers. Currently the code is all mixed into the controller manager. We should actively control what is made available to the cloud provider so list explicitly the parms needed and move the code out. This will avoid linkages to sneak in as we will catch it better during reviews. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59190, 59360). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Adding benchmarks to envelop encryption integration tests **What this PR does / why we need it**: Adding benchmarks for envelop encryption integration tests. Allows to estimate how envelop encryption may impact the performance of KubeAPI server. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Reimplement 2 tests using fakeexec **What this PR does / why we need it**: Used fakeexec API from utils/exec/testing to test GetKubeletVersion and KubeletVersionCheck APIs without running kubelet. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59054, 59515, 59577). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Uniquify kubemark image builds and use new registry format Solves issues 1 and 3 in https://github.com/kubernetes/kubernetes/issues/59567. /cc @wojtek-t fyi - @thockin @kubernetes/sig-scalability-misc ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59054, 59515, 59577). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add 'none' option to EnforceNodeAllocatable This lets us use omitempty on `EnforceNodeAllocatable`. We shouldn't treat `nil` as different from `[]T{}`, because this can play havoc with serializers (a-la #43203). See: https://github.com/kubernetes/kubernetes/pull/53833#discussion_r166672137 ```release-note 'none' can now be specified in KubeletConfiguration.EnforceNodeAllocatable (--enforce-node-allocatable) to explicitly disable enforcement. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove port from HTTPProxyCheck **What this PR does / why we need it**: HTTPProxyCheck doesn't use port. It uses proxy related variables (HTTP_PROXY, NO_PROXY, etc) that only operate with protocol and host. Removing port from the check should make it more clear for user that port is not used as it will not be present in the check output. **Release note**: ```release-note NONE ```
-
alex authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. vclib: enable VM disk attach test **What this PR does / why we need it**: Follow up to PR #58534 , where this test was disabled due to a limitation in govmomi/simulator. The test passes as expected with godeps update of govmomi. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: This PR is 1-line update to the vSphere Cloud Provider tests and godep update of the vendor'd vmware/govmomi repo. **Release note**: ```release-note NONE ```
-
Michael Taufen authored
This lets us use omitempty on EnforceNodeAllocatable. We shouldn't treat `nil` as different from `[]T{}`, because this can play havoc with serializers (a-la #43203). See: https://github.com/kubernetes/kubernetes/pull/53833#discussion_r166672137 -
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Report InstanceID for vSphere Cloud Provider as UUID obtained from product_serial file **What this PR does / why we need it**: vSphere Cloud Provider is not able to find the nodes for VMs created on vSphere v1.6.5. Kubelet fetches SystemUUID from file ```/sys/class/dmi/id/product_uuid```. vSphere Cloud Provider uses this uuid as VM identifier to get node information from vCenter. vCenter v1.6.5 doesn't recognize this uuids, as a result, nodes are not found. UUID present in file ```/sys/class/dmi/id/product_serial``` is recognized by vCenter. Yet, Kubelet doesn't report this. Therefore, in this PR InstanceID is reported as UUID which is fetched from file ```/sys/class/dmi/id/product_serial```. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes https://github.com/kubernetes/kubernetes/issues/58927 **Special notes for your reviewer**: Internally review here: https://github.com/vmware/kubernetes/pull/452 Tested: Launched K8s cluster using kubeadm (Used Ubuntu VM compatible with vSphere version 6.5.) _**Note: Installed Ubuntu from ISO**_ Observed following: ``` Master > cat /sys/class/dmi/id/product_uuid 743F0E42-84EA-A2F9-7736-6106BB5DBF6B > cat /sys/class/dmi/id/product_serial VMware-42 0e 3f 74 ea 84 f9 a2-77 36 61 06 bb 5d bf 6b Node > cat /sys/class/dmi/id/product_uuid 956E0E42-CC9D-3D89-9757-F27CEB539B76 > cat /sys/class/dmi/id/product_serial VMware-42 0e 6e 95 9d cc 89 3d-97 57 f2 7c eb 53 9b 76 ``` With this fix controller manager was able to find the nodes. **controller manager logs** ``` {"log":"I0205 22:43:00.106416 1 nodemanager.go:183] Found node ubuntu-node as vm=VirtualMachine:vm-95 in vc=10.161.120.115 and datacenter=vcqaDC\n","stream":"stderr","time":"2018-02-05T22:43:00.421010375Z"} ``` **Release note**: ```release-note vSphere Cloud Provider supports VMs provisioned on vSphere v1.6.5 ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Move test cases to a proper test method **What this PR does / why we need it**: Prior this change, we had tests in `TestValidatePodSpec()` method that is designated for testing `ValidatePodSpec()`. But because we test code from the `ValidateSecurityContext()` method, the tests should belong to `TestValidateSecurityContext()`. This PR improves the tests. Now the tests become less fragile because `ValidatePodSpec()` do a lot more validations than `ValidateSecurityContext()`. **Which issue(s) this PR fixes**: Related to https://github.com/kubernetes/kubernetes/pull/52803 where this code and tests were introduced. **Release note**: ```release-note NONE ``` PTAL @jessfraz CC @simo5
-
Shyam Jeedigunta authored
-
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add shyamjvs to cluster/images/kubemark/OWNERS Ref https://github.com/kubernetes/kubernetes/pull/59577#issuecomment-364147745 /cc @wojtek-t ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Fix bug with profile-gathering waitgroup in scale tests This bug has caused panic due to: ``` I0208 14:11:52.955] [91m[1mTest Panicked[0m I0208 14:11:52.955] [91msync: negative WaitGroup counter[0m ``` e.g failure - https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-kubemark-500-gce/11818) /cc @wojtek-t ```release-note NONE ```
-
Slava Semushin authored
validation_test.go: move test cases for AllowPrivilegeEscalation option from TestValidatePodSpec to TestValidateSecurityContext.
-
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. client-gen: remove base input dirs Were these dirs some kind of cargo cult? Removing them causes no change to the generated code. Background: having those packages in the list of input dirs makes them mandatory to exist. If people use code-gen on a project that does not vendor them (due to vendor/ pruning), code-gen fails. Fixes https://github.com/kubernetes/sample-controller/issues/8
-
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix using defer in loop in cors test **What this PR does / why we need it**: fix bug in cors test **Special notes for your reviewer**: a small bug fix, wrap defer in a closure **Release note**: ```release-note NONE ```
-
Davanum Srinivas authored
Add a separate method in a new file for creating cloud providers. Currently the code is all mixed into the controller manager. We should actively control what is made available to the cloud provider so list explicitly the parms needed and move the code out. This will avoid linkages to sneak in as we will catch it better during reviews.
-
Tomas Smetana authored
The DetachDisk method of AWS cloudprovider indirectly calls EC2::DescribeVolume AWS API function to check if the volume being detached is really attached to the specified node. The AWS API call may fail and return error which is logged however the DetachDisk then finishes successfully. This may cause the AWS volumes to remain attached to the instances forever because the attach/detach controller will mark the volume as attached. The PV controller will never be able to delete those disks and they need to be detached manually. This patch ensures on error from DescribeVolume is propagated to attach/detach controller and the detach operation is re-tried.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 54685, 59352). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Add apiserver profiling to our scalability tests Follows PR https://github.com/kubernetes/kubernetes/pull/58763 /cc @wojtek-t @porridge @kubernetes/sig-scalability-misc
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add unchedule information to kubectl describe node **What this PR does / why we need it**: Fixes #53721 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: cc @smarterclayton now output: ``` Name: bar Roles: <none> Labels: <none> Annotations: <none> Taints: <none> Unschedulable: true CreationTimestamp: Mon, 01 Jan 0001 00:00:00 +0000 ``` **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57824, 58806, 59410, 59280). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Ability to run an external binary instead of hyperkube cloud-controller-manager **What this PR does / why we need it**: Since we want folks to test their own binaries, let's allow a way for them them to specify a custom binary. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57824, 58806, 59410, 59280). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add some package to code-generator **What this PR does / why we need it**: add some package to code-generator and regenerated files. **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: /cc @sttts **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57824, 58806, 59410, 59280). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. add Annotations to advanced audit api **Release note**: ```release-note Annotations is added to advanced audit api ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 57824, 58806, 59410, 59280). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. 2nd try at using a vanity GCR name The 2nd commit here is the changes relative to the reverted PR. Please focus review attention on that. This is the 2nd attempt. The previous try (#57573) was reverted while we figured out the regional mirrors (oops). New plan: k8s.gcr.io is a read-only facade that auto-detects your source region (us, eu, or asia for now) and pulls from the closest. To publish an image, push k8s-staging.gcr.io and it will be synced to the regionals automatically (similar to today). For now the staging is an alias to gcr.io/google_containers (the legacy URL). When we move off of google-owned projects (working on it), then we just do a one-time sync, and change the google-internal config, and nobody outside should notice. We can, in parallel, change the auto-sync into a manual sync - send a PR to "promote" something from staging, and a bot activates it. Nice and visible, easy to keep track of. xref https://github.com/kubernetes/release/issues/281 TL;DR: * The new `staging-k8s.gcr.io` is where we push images. It is literally an alias to `gcr.io/google_containers` (the existing repo) and is hosted in the US. * The contents of `staging-k8s.gcr.io` are automatically synced to `{asia,eu,us)-k8s.gcr.io`. * The new `k8s.gcr.io` will be a read-only alias to whichever regional repo is closest to you. * In the future, images will be promoted from `staging` to regional "prod" more explicitly and auditably. ```release-note Use "k8s.gcr.io" for pulling container images rather than "gcr.io/google_containers". Images are already synced, so this should not impact anyone materially. Documentation and tools should all convert to the new name. Users should take note of this in case they see this new name in the system. ```
-
Dr. Stefan Schimanski authored
-
hzxuzhonghu authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59539, 59309). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. fix describe when allocatable CPU/Memory is 0 **What this PR does / why we need it**: **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 59539, 59309). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Set instanceID to azure resource ID format while useInstanceMetadata is enabled **What this PR does / why we need it**: This PR sets instanceID to azure resource ID format while useInstanceMetadata is enabled. Before this PR, it is `azure://d84a1c30-0c9f-11e8-8a34-000d3a919531`. With this PR, it becomes `azure:///subscriptions/<id>/resourceGroups/<rg>/providers/Microsoft.Compute/virtualMachines/<node-name>` **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*: Fixes # **Special notes for your reviewer**: This PR is only for vmas and could be cherry-picked to old releases. There will be another PR for vmss after this. Should cherry-pick to release 1.8 and 1.9. **Release note**: ```release-note Node's providerID is following Azure resource ID format now when useInstanceMetadata is enabled ```
-
Shyam Jeedigunta authored
-