- 04 Aug, 2017 13 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue kubelet: remove code for handling old pod/containers paths **What this PR does / why we need it**: This PR removes the code for handling the paths that has been deprecated for a long time. **Release note**: ```release-note NONE ``` CC @simo5
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096) GCE: Bump GLBC version to 0.9.6 Closes #50095 **Release note**: ```release-note GCE: Bump GLBC version to 0.9.6 ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096) Remove 0,1,3 from rand.String to avoid 'bad words' **What this PR does / why we need it**: Remove 0,1,3 from the runes to prevent accidental bad words profanity **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49543 **Special notes for your reviewer**: /cc @mml @jamesawebb1 @spiffxp **Release note**: ```release-note Remove 0,1,3 from rand.String, to avoid 'bad words' ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096) apiextensions: fix data race in storage Fixes data race in CRD storage. Copy to a new map because we cannot write to storageMap without a race as it is used without locking elsewhere. **Release note**: ```release-note NONE ``` /cc @sttts
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096) Cover equivalence cache tests in scheduler core **What this PR does / why we need it**: Finish the last part of equivalence class scheduling #17390 : complete unit tests. Also, removed `InvalidateCachedPredicateItemForPod` which is unused in latest design. ``` godep go test -v equivalence_cache_test.go equivalence_cache.go -cover PASS coverage: 92.3% of statements ok command-line-arguments 0.071s ``` **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix err message in namespace_policy **What this PR does / why we need it**: **Which issue this PR fixes**: fixes #49541 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix pointer bug in local volume e2e test **What this PR does / why we need it**: Fix pointer bug in local volume e2e test **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/kubernetes/issues/50043 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48237, 50084, 50019, 50069, 50090) Explicitly use Core client as EventClient in hollow node
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48237, 50084, 50019, 50069, 50090) Fix comment of isHTTPSURL **What this PR does / why we need it**: fix comment of isHTTPSURL
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48237, 50084, 50019, 50069, 50090) create default storage selection functions The vast majority of our REST storage needs either default selection predicates or minor tweaks the the field selection criteria. This pull makes that work without any special fields set, but also allows the more complex configuration where it is required. I only changed one storage an example. Once this merges, I'll update the others. @kubernetes/sig-api-machinery-misc @wojtek-t @smarterclayton @sttts @cheftako ptal.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48237, 50084, 50019, 50069, 50090) Allow for some pods not to get scheduled in CA tests. This will allow us to ignore long tail node creation or failure to create some nodes when running scalability tests on kubemark. **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add test for kube-proxy running with "--cleanup-iptables=true" **What this PR does / why we need it**: Add test to prevent such kube-proxy panic to happen again. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48177 **Special notes for your reviewer**: Forgot to add this in last PR #48183. Should we also add this to v1.7 milestone? /cc @ncdc @dchen1107 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Adding a Cassandra upgrade test Tests for #38336
-
- 03 Aug, 2017 27 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969) Run kazel on the entire tree **What this PR does / why we need it**: part of #47558: auto-generate `BUILD` files on the entire tree, since this is what `gazelle` does, and it'll make subsequent reviews easier if less is changing. **Release note**: ```release-note NONE ``` /assign /release-note-none
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969) Adding IPv6 to cidr_set and cidr_set_test **What this PR does / why we need it**: This allows IPv6 in cidr_set Currently cidr_set only supports IPv4. This adds IPv6 compatibility and adds IPv6 unit tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #43588 **Special notes for your reviewer**: The IPv6 code here makes some assumptions. The subnets should be at least /64. (maximum 64 bits of prefix) The subnet mask size cannot be greater than 30 more than the cluster mask size. **Release note**: ```release-note ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969) Do not try to run preStopHook when the gracePeriod is 0 **What this PR does / why we need it**: 1. Sometimes when the user force deletes a POD with no gracePeriod, its possible that kubelet attempts to execute the preStopHook which will certainly fail. This PR prevents this inavitable PreStopHook failure. ``` kubectl delete --force --grace-period=0 po/<pod-name> ``` 2. This also adds UT for LifeCycle Hooks ``` time go test --cover -v --run "Hook" ./pkg/kubelet/kuberuntime/ . . . --- PASS: TestLifeCycleHook (0.00s) --- PASS: TestLifeCycleHook/PreStop-CMDExec (0.00s) --- PASS: TestLifeCycleHook/PreStop-HTTPGet (0.00s) --- PASS: TestLifeCycleHook/PreStop-NoTimeToRun (0.00s) --- PASS: TestLifeCycleHook/PostStart-CmdExe (0.00s) PASS coverage: 15.3% of statements ok k8s.io/kubernetes/pkg/kubelet/kuberuntime 0.429s ``` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ``` Do not try to run preStopHook when the gracePeriod is 0 ``` -
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969) Add missing UID in SubjectAccessReviewSpec **What this PR does / why we need it**: WebhookAuthorizer's Authorize should send *all* the information present in the user.Info data structure. We are not sending the UID currently. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note The SubjectAccessReview API in the authorization.k8s.io API group now allows providing the user uid. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969) [Bug Fix] Fix updating LastHeartbeatTime for the OutOfDisk node condition. Fixes #50058. #49841 for some (currently unknown) reason did not correctly update LastHeartbeatTime, causing OutOfDisk to be marked unknown. I have not found the reason for this yet. This change makes the setNodeOODCondition method nearly identical to the other conditions (e.g. [setNodeMemoryPressureCondition](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kubelet_node_status.go#L741)). I have started a cluster with this change, and all nodes have been reporting `Ready` for 25 minutes.
-
David Ashpole authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add kube-proxy change notice to v1.7.3 release note **What this PR does / why we need it**: Add necessary release note for issue #48600. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48600 **Special notes for your reviewer**: This is suppose to be in v1.7.3 release note, but turned out I only updated release note on the cherrypick PR (#49799) instead of the original PR (#48625) so nothing got picked up :( /assign @bowei @wojtek-t **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue apiextensions: fix panic with KUBE_API_VERSIONS set https://github.com/kubernetes/kubernetes/pull/48837 introduced a panic in apiextension-apiserver triggered by the `hack/test-update-storage-objects.sh` script in CI.
-
Anthony Yeh authored
-
Zihong Zheng authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Increase default value of apps/v1beta2 DeploymentSpec.RevisionHistoryLimit to 10 **What this PR does / why we need it**: All controllers that use the `RevisionHistoryLimit` field have a default value of 10 for the field, except for `Deployment`, which has a default of 2. We should increase it to 10 for consistency on its default value across controllers. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49913 **Special notes for your reviewer**: /cc @janetkuo @foxish @liyinan926 **Release note**: ```release-note Increase default value of apps/v1beta2 DeploymentSpec.RevisionHistoryLimit to 10 ```
-
Maisem Ali authored
-
Robert Pothier authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix incorrect owner in OWNERS **What this PR does / why we need it**: typo: yuyuhong --> yujuhong **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # https://github.com/kubernetes/kubernetes/issues/50048#issuecomment-319846621 **Special notes for your reviewer**: /assign @yujuhong I don't know whether you can approve this PR or not in such case
😄 **Release note**: ```release-note NONE ``` -
Nikhita Raghunath authored
-
Nick Sardo authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Moves left networking e2e tests to test/e2e/network **What this PR does / why we need it**: #48784 forgot to move some networking e2e tests. This PR moves them. It also move the networking tests from within `test/e2e/common/networking.go` to `test/e2e/network/networking.go` **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Associated PR #48784 Umbrella issue #49161 **Special notes for your reviewer**: /assign @wojtek-t @bowei **Release note**: ```release-note NONE ```
-
Harry Zhang authored
-
Harry Zhang authored
Fix testing method
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix typo in staging/src/k8s.io/apiserver/pkg/server/config.go **What this PR does / why we need it**: Fix a typo `It's members are sorted roughly in order of importance for composers.` in `staging/src/k8s.io/apiserver/pkg/server/config.go`. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: `NONE`
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Moved node condition check into Predicats. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: partially fixes #42001 **Release note**: ```release-note None ```
-
gmarek authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Remove remaining traces of go2idl
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add --feature-gate flags to kubeadm **What this PR does / why we need it**: Adds `--feature-gates` in similar manner to other `cmd` binaries **Which issue this PR fixes** https://github.com/kubernetes/kubeadm/issues/323 **Special notes for your reviewer**: This results in a lot of probably unnecessary feature flags. I'm guessing a lot of kubeadm users will be confused when they see: ``` Flags: --feature-gates mapStringBool A set of key=value pairs that describe feature gates for alpha/experimental features. Options are: APIResponseCompression=true|false (ALPHA - default=false) Accelerators=true|false (ALPHA - default=false) AdvancedAuditing=true|false (ALPHA - default=false) AllAlpha=true|false (ALPHA - default=false) AllowExtTrafficLocalEndpoints=true|false (default=true) AppArmor=true|false (BETA - default=true) DebugContainers=true|false (ALPHA - default=false) DynamicKubeletConfig=true|false (ALPHA - default=false) DynamicVolumeProvisioning=true|false (ALPHA - default=true) ExperimentalCriticalPodAnnotation=true|false (ALPHA - default=false) ExperimentalHostUserNamespaceDefaulting=true|false (BETA - default=false) LocalStorageCapacityIsolation=true|false (ALPHA - default=false) PersistentLocalVolumes=true|false (ALPHA - default=false) PodPriority=true|false (ALPHA - default=false) RotateKubeletClientCertificate=true|false (ALPHA - default=false) RotateKubeletServerCertificate=true|false (ALPHA - default=false) StreamingProxyRedirects=true|false (BETA - default=true) TaintBasedEvictions=true|false (ALPHA - default=false) -h, --help help for kubeadm ``` However the feature flags used in the core pkg is global, so I don't think it can be overriden. So we have a few options: 1. Allow these flags for kubeadm 2. Refactor feature pkg to allow granular features 3. Roll our own feature gating for kubeadm /cc @luxas
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Switch from package syscall to golang.org/x/sys/unix **What this PR does / why we need it**: The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes without having to use a new go version. In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function. **Special notes for your reviewer**: This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588 **Release note**: ```release-note NONE ```
-
Beata Skiba authored
This will allow us to ignore long tail node creation or failure to create some nodes when running scalability tests on kubemark.
-