1. 04 Aug, 2017 13 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #48952 from php-coder/remove_old_stuff · e331de9e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      kubelet: remove code for handling old pod/containers paths
      
      **What this PR does / why we need it**:
      This PR removes the code for handling the paths that has been deprecated for a long time.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      CC @simo5
      e331de9e
    • Kubernetes Submit Queue's avatar
      Merge pull request #50096 from nicksardo/bump-glbc-0.9.6 · 68a72215
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096)
      
      GCE: Bump GLBC version to 0.9.6
      
      Closes #50095
      
      **Release note**:
      ```release-note
      GCE: Bump GLBC version to 0.9.6
      ```
      68a72215
    • Kubernetes Submit Queue's avatar
      Merge pull request #50070 from dixudx/remove_013_to_avoid_bad_words · 704cc7f9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096)
      
      Remove 0,1,3 from rand.String to avoid 'bad words'
      
      **What this PR does / why we need it**:
      
      Remove 0,1,3 from the runes to prevent accidental bad words profanity
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49543
      
      **Special notes for your reviewer**:
      /cc @mml  @jamesawebb1  @spiffxp 
      
      **Release note**:
      
      ```release-note
      Remove 0,1,3 from rand.String, to avoid 'bad words'
      ```
      704cc7f9
    • Kubernetes Submit Queue's avatar
      Merge pull request #50098 from nikhita/crd-data-race · c66d2499
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096)
      
      apiextensions: fix data race in storage
      
      Fixes data race in CRD storage.
      
      Copy to a new map because we cannot write to storageMap without a race as it is used without locking elsewhere.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      
      /cc @sttts
      c66d2499
    • Kubernetes Submit Queue's avatar
      Merge pull request #49863 from resouer/eclass-test · 6065a0da
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 46685, 49863, 50098, 50070, 50096)
      
      Cover equivalence cache tests in scheduler core
      
      **What this PR does / why we need it**:
      
      Finish the last part of equivalence class scheduling #17390 : complete unit tests.
      
      Also, removed `InvalidateCachedPredicateItemForPod` which is unused in latest design.
      
      ```
      godep go test -v equivalence_cache_test.go  equivalence_cache.go  -cover
      
      PASS
      coverage: 92.3% of statements
      ok  	command-line-arguments	0.071s
      ```
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      6065a0da
    • Kubernetes Submit Queue's avatar
      Merge pull request #46685 from xilabao/fix-err-message-in-namespace_policy · 0a4903b0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix err message in namespace_policy
      
      **What this PR does / why we need it**:
      
      **Which issue this PR fixes**: fixes #49541
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      0a4903b0
    • Kubernetes Submit Queue's avatar
      Merge pull request #50059 from ddysher/local-e2e-bug-fix · 15842f37
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix pointer bug in local volume e2e test
      
      **What this PR does / why we need it**:
      Fix pointer bug in local volume e2e test
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes https://github.com/kubernetes/kubernetes/issues/50043
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      15842f37
    • Kubernetes Submit Queue's avatar
      Merge pull request #50090 from gmarek/EventClient · e29ead11
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48237, 50084, 50019, 50069, 50090)
      
      Explicitly use Core client as EventClient in hollow node
      e29ead11
    • Kubernetes Submit Queue's avatar
      Merge pull request #50069 from fisherxu/master · 151b8118
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48237, 50084, 50019, 50069, 50090)
      
      Fix comment of isHTTPSURL
      
      **What this PR does / why we need it**:
      fix comment of isHTTPSURL
      151b8118
    • Kubernetes Submit Queue's avatar
      Merge pull request #50019 from deads2k/server-38-storage · 65e6bf8d
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48237, 50084, 50019, 50069, 50090)
      
      create default storage selection functions
      
      The vast majority of our REST storage needs either default selection predicates or minor tweaks the the field selection criteria.  This pull makes that work without any special fields set, but also allows the more complex configuration where it is required.  I only changed one storage an example.  Once this merges, I'll update the others.
      
      @kubernetes/sig-api-machinery-misc @wojtek-t @smarterclayton @sttts @cheftako ptal.
      65e6bf8d
    • Kubernetes Submit Queue's avatar
      Merge pull request #50084 from bskiba/ca_tolerate_unready · 9a26cdfb
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 48237, 50084, 50019, 50069, 50090)
      
      Allow for some pods not to get scheduled in CA tests.
      
      This will allow us to ignore long tail node creation or failure
      to create some nodes when running scalability tests on kubemark.
      
      **Release note**:
      
      ```
      NONE
      ```
      9a26cdfb
    • Kubernetes Submit Queue's avatar
      Merge pull request #48237 from xiangpengzhao/fix-proxy-test · 0c2f8166
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add test for kube-proxy running with "--cleanup-iptables=true"
      
      **What this PR does / why we need it**:
      Add test to prevent such kube-proxy panic to happen again.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48177
      
      **Special notes for your reviewer**:
      Forgot to add this in last PR #48183. Should we also add this to v1.7 milestone?
      /cc @ncdc @dchen1107 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      0c2f8166
    • Kubernetes Submit Queue's avatar
      Merge pull request #47200 from maisem/cassandra · 325a53aa
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Adding a Cassandra upgrade test
      
      Tests for #38336
      325a53aa
  2. 03 Aug, 2017 27 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #48969 from ixdy/update-kazel · d15baf69
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969)
      
      Run kazel on the entire tree
      
      **What this PR does / why we need it**: part of #47558: auto-generate `BUILD` files on the entire tree, since this is what `gazelle` does, and it'll make subsequent reviews easier if less is changing.
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      /assign
      /release-note-none
      d15baf69
    • Kubernetes Submit Queue's avatar
      Merge pull request #43586 from rpothier/cidr_set_ipv6 · 063fc6a7
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969)
      
      Adding IPv6 to cidr_set and cidr_set_test
      
      **What this PR does / why we need it**:
      This allows IPv6 in cidr_set
      
      Currently cidr_set only supports IPv4. This adds IPv6 compatibility and adds
      IPv6 unit tests.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #43588
      
      **Special notes for your reviewer**:
      The IPv6 code here makes some assumptions.
      The subnets should be at least /64. (maximum 64 bits of prefix)
      The subnet mask size cannot be greater than 30 more than the cluster mask size.
      
      **Release note**:
      
      ```release-note
      ```
      063fc6a7
    • Kubernetes Submit Queue's avatar
      Merge pull request #49449 from dhilipkumars/PreStopFix · 6843ca57
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969)
      
      Do not try to run preStopHook when the gracePeriod is 0
      
      **What this PR does / why we need it**:
      1. Sometimes when the user force deletes a POD with no gracePeriod, its possible that kubelet attempts to execute the preStopHook which will certainly fail.  This PR prevents this inavitable PreStopHook failure.
      ```
      kubectl delete --force --grace-period=0 po/<pod-name>
      ```
      2. This also adds UT for LifeCycle Hooks
      ```
      time go test --cover -v --run "Hook" ./pkg/kubelet/kuberuntime/
      .
      .
      .
      --- PASS: TestLifeCycleHook (0.00s)
          --- PASS: TestLifeCycleHook/PreStop-CMDExec (0.00s)
          --- PASS: TestLifeCycleHook/PreStop-HTTPGet (0.00s)
          --- PASS: TestLifeCycleHook/PreStop-NoTimeToRun (0.00s)
          --- PASS: TestLifeCycleHook/PostStart-CmdExe (0.00s)
      PASS
      coverage: 15.3% of statements
      ok      k8s.io/kubernetes/pkg/kubelet/kuberuntime       0.429s
      ```
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```
      Do not try to run preStopHook when the gracePeriod is 0
      ```
      6843ca57
    • Kubernetes Submit Queue's avatar
      Merge pull request #49677 from dims/send-missing-uid-field-during-webhook-authorize · 40d66b8e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969)
      
      Add missing UID in SubjectAccessReviewSpec
      
      **What this PR does / why we need it**:
      WebhookAuthorizer's Authorize should send *all* the information
      present in the user.Info data structure. We are not sending the
      UID currently.
      
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      The SubjectAccessReview API in the authorization.k8s.io API group now allows providing the user uid.
      ```
      40d66b8e
    • Kubernetes Submit Queue's avatar
      Merge pull request #50103 from dashpole/fix_ood · a1aeea8e
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 50103, 49677, 49449, 43586, 48969)
      
      [Bug Fix] Fix updating LastHeartbeatTime for the OutOfDisk node condition.
      
      Fixes #50058.  #49841 for some (currently unknown) reason did not correctly update LastHeartbeatTime, causing OutOfDisk to be marked unknown.
      I have not found the reason for this yet.  This change makes the setNodeOODCondition method nearly identical to the other conditions (e.g. [setNodeMemoryPressureCondition](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/kubelet_node_status.go#L741)).
      
      I have started a cluster with this change, and all nodes have been reporting `Ready` for 25 minutes.
      a1aeea8e
    • David Ashpole's avatar
      fix outofdisk condition not reported · 177d6421
      David Ashpole authored
      177d6421
    • Kubernetes Submit Queue's avatar
      Merge pull request #50104 from MrHohn/kube-proxy-1.7.3-changelog · 04b2c29a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add kube-proxy change notice to v1.7.3 release note
      
      **What this PR does / why we need it**: Add necessary release note for issue #48600.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48600 
      
      **Special notes for your reviewer**:
      
      This is suppose to be in v1.7.3 release note, but turned out I only updated release note on the cherrypick PR (#49799) instead of the original PR (#48625) so nothing got picked up :( 
      
      /assign @bowei @wojtek-t 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      04b2c29a
    • Kubernetes Submit Queue's avatar
      Merge pull request #50092 from sttts/sttts-fix-apiextensions-segfault · 0d6a0404
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      apiextensions: fix panic with KUBE_API_VERSIONS set
      
      https://github.com/kubernetes/kubernetes/pull/48837 introduced a panic in apiextension-apiserver triggered by the `hack/test-update-storage-objects.sh` script in CI.
      0d6a0404
    • Anthony Yeh's avatar
      Update CHANGELOG.md for v1.6.8. · ae2175b6
      Anthony Yeh authored
      ae2175b6
    • Zihong Zheng's avatar
      357f3452
    • Kubernetes Submit Queue's avatar
      Merge pull request #49924 from dixudx/increase_deployment_default_RevisionHistoryLimit · 66bfab89
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Increase default value of apps/v1beta2 DeploymentSpec.RevisionHistoryLimit to 10
      
      **What this PR does / why we need it**:
      
      All controllers that use the `RevisionHistoryLimit` field have a default value of 10 for the field, except for `Deployment`, which has a default of 2. We should increase it to 10 for consistency on its default value across controllers.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49913
      
      **Special notes for your reviewer**:
      /cc @janetkuo @foxish @liyinan926
      
      **Release note**:
      
      ```release-note
      Increase default value of apps/v1beta2 DeploymentSpec.RevisionHistoryLimit to 10
      ```
      66bfab89
    • Maisem Ali's avatar
      Adding cassandra test. · 3ea11b2b
      Maisem Ali authored
      3ea11b2b
    • Robert Pothier's avatar
      Adding IPv6 to cidr_set and cidr_set_test · 5e965239
      Robert Pothier authored
      5e965239
    • Kubernetes Submit Queue's avatar
      Merge pull request #50053 from xiangpengzhao/fix-owners · 1284d78c
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Fix incorrect owner in OWNERS
      
      **What this PR does / why we need it**:
      typo: yuyuhong --> yujuhong
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      https://github.com/kubernetes/kubernetes/issues/50048#issuecomment-319846621
      
      **Special notes for your reviewer**:
      /assign @yujuhong 
      I don't know whether you can approve this PR or not in such case 😄 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      1284d78c
    • Nikhita Raghunath's avatar
      4a08a693
    • Nick Sardo's avatar
      Bump GLBC version to 0.9.6 · 97114d73
      Nick Sardo authored
      97114d73
    • Kubernetes Submit Queue's avatar
      Merge pull request #49942 from xiangpengzhao/nw-e2e · 928cf542
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Moves left networking e2e tests to test/e2e/network
      
      **What this PR does / why we need it**:
      #48784 forgot to move some networking e2e tests. This PR moves them.
      
      It also move the networking tests from within `test/e2e/common/networking.go` to  `test/e2e/network/networking.go`
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      Associated PR #48784
      Umbrella issue #49161
      
      **Special notes for your reviewer**:
      /assign @wojtek-t @bowei 
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      928cf542
    • Harry Zhang's avatar
      Update generated files · f8309d75
      Harry Zhang authored
      f8309d75
    • Harry Zhang's avatar
      Cover get equivalence cache in core · a0787358
      Harry Zhang authored
      Fix testing method
      a0787358
    • Dr. Stefan Schimanski's avatar
    • Kubernetes Submit Queue's avatar
      Merge pull request #49195 from huangjiuyuan/fix-typo · 2bd0b3dd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      fix typo in staging/src/k8s.io/apiserver/pkg/server/config.go
      
      **What this PR does / why we need it**: Fix a typo `It's members are sorted roughly in order of importance for composers.` in `staging/src/k8s.io/apiserver/pkg/server/config.go`.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      `NONE`
      2bd0b3dd
    • Kubernetes Submit Queue's avatar
      Merge pull request #49932 from k82cn/k8s_42001_2_1 · 4c0de012
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Moved node condition check into Predicats.
      
      **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: partially fixes #42001 
      
      **Release note**:
      
      ```release-note
      None
      ```
      4c0de012
    • gmarek's avatar
      20b6b3ca
    • Kubernetes Submit Queue's avatar
      Merge pull request #49368 from sttts/sttts-clean-go2idl · ef5ee331
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Remove remaining traces of go2idl
      ef5ee331
    • Kubernetes Submit Queue's avatar
      Merge pull request #48943 from jamiehannaford/kubeadm-feature-gates · 42a73ee3
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Add --feature-gate flags to kubeadm
      
      **What this PR does / why we need it**:
      
      Adds `--feature-gates` in similar manner to other `cmd` binaries
      
      **Which issue this PR fixes** 
      
      https://github.com/kubernetes/kubeadm/issues/323
      
      **Special notes for your reviewer**:
      
      This results in a lot of probably unnecessary feature flags. I'm guessing a lot of kubeadm users will be confused when they see:
      
      ```
      Flags:
            --feature-gates mapStringBool   A set of key=value pairs that describe feature gates for alpha/experimental features. Options are:
      APIResponseCompression=true|false (ALPHA - default=false)
      Accelerators=true|false (ALPHA - default=false)
      AdvancedAuditing=true|false (ALPHA - default=false)
      AllAlpha=true|false (ALPHA - default=false)
      AllowExtTrafficLocalEndpoints=true|false (default=true)
      AppArmor=true|false (BETA - default=true)
      DebugContainers=true|false (ALPHA - default=false)
      DynamicKubeletConfig=true|false (ALPHA - default=false)
      DynamicVolumeProvisioning=true|false (ALPHA - default=true)
      ExperimentalCriticalPodAnnotation=true|false (ALPHA - default=false)
      ExperimentalHostUserNamespaceDefaulting=true|false (BETA - default=false)
      LocalStorageCapacityIsolation=true|false (ALPHA - default=false)
      PersistentLocalVolumes=true|false (ALPHA - default=false)
      PodPriority=true|false (ALPHA - default=false)
      RotateKubeletClientCertificate=true|false (ALPHA - default=false)
      RotateKubeletServerCertificate=true|false (ALPHA - default=false)
      StreamingProxyRedirects=true|false (BETA - default=true)
      TaintBasedEvictions=true|false (ALPHA - default=false)
        -h, --help                          help for kubeadm
      ```
      
      However the feature flags used in the core pkg is global, so I don't think it can be overriden. So we have a few options:
      
      1. Allow these flags for kubeadm
      2. Refactor feature pkg to allow granular features
      3. Roll our own feature gating for kubeadm
      
      /cc @luxas
      42a73ee3
    • Kubernetes Submit Queue's avatar
      Merge pull request #49300 from tklauser/syscall-to-x-sys-unix · 5d24a2c1
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue
      
      Switch from package syscall to golang.org/x/sys/unix
      
      **What this PR does / why we need it**:
      
      The syscall package is locked down and the comment in https://github.com/golang/go/blob/master/src/syscall/syscall.go#L21-L24 advises to switch code to use the corresponding package from golang.org/x/sys. This PR does so and replaces usage of package syscall with package golang.org/x/sys/unix where applicable. This will also allow to get updates and fixes
      without having to use a new go version.
      
      In order to get the latest functionality, golang.org/x/sys/ is re-vendored. This also allows to use Eventfd() from this package instead of calling the eventfd() C function.
      
      **Special notes for your reviewer**:
      
      This follows previous works in other Go projects, see e.g. moby/moby#33399, cilium/cilium#588
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      5d24a2c1
    • Beata Skiba's avatar
      Allow for some pods not to get scheduled in CA tests. · e4f6b144
      Beata Skiba authored
      This will allow us to ignore long tail node creation or failure
      to create some nodes when running scalability tests on kubemark.
      e4f6b144