- 08 Sep, 2017 40 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50949, 52155, 52175, 52112, 52188) Allow watch cache to be disabled per type Currently setting watch cache size for a given resource does not disable the watch cache. This commit adds a new `default-watch-cache-size` flag to map to the existing field, and refactors how watch cache sizes are calculated to bring all of the code into one place. It also adds debug logging to startup to allow us to verify watch cache enablement in production. Part of #51825 Will allow watch cache to be disabled selectively.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50949, 52155, 52175, 52112, 52188) bump(github.com/google/cadvisor): cda62a43857256fbc95dd31e7c810888f00f8ec7 Bump cadvisor to v0.27.1 for cri-o enhancements @derekwaynecarr @runcom @dashpole /release-note-none /sig node
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 50949, 52155, 52175, 52112, 52188) Fix prober ticking shift for kubelet restart cases Fixes #52154 call sleep() before `probeTicker` starts ticking, to reduce the number of probers executed at the same time, after kubelete restarted. **Special notes for your reviewer**: Before:  After:  **Release note**: ```release-note NONE ``` /cc @kubernetes/sig-node-bugs
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add pod preemption to the scheduler **What this PR does / why we need it**: This is the last of a series of PRs to add priority-based preemption to the scheduler. This PR connects the preemption logic to the scheduler workflow. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48646 **Special notes for your reviewer**: This PR includes other PRs which are under review (#50805, #50405, #50190). All the new code is located in https://github.com/kubernetes/kubernetes/pull/50949/commits/43627afdf96a2a05aee245f70099dd5af5313bc5. **Release note**: ```release-note Add priority-based preemption to the scheduler. ``` ref/ #47604 /assign @davidopp @kubernetes/sig-scheduling-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add cluster up configuration for certificate signing duration. ```release-note Add CLUSTER_SIGNING_DURATION environment variable to cluster configuration scripts to allow configuration of signing duration of certificates issued via the Certificate Signing Request API. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add German translation for kubectl **What this PR does / why we need it**: This PR provides a first attempt to translate kubectl in German (related to #40645, #45573, #45562, #40591, #46559, #50155). **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # No issues **Special notes for your reviewer**: This PR requires German people to assist in the review. I'm native in German with BSc in Business Information Technology. **Release note**: ```release-note Adding German translation for kubectl ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue ScaleIO - Specify SDC GUID value via node label **What this PR does / why we need it**: This is a ScaleIO plugin volume PR to do the following: - Reads node label `scaleio.sdcGuid` value for the SDC GUID - Uses value to look up the Scaleio SDC `instance ID` - If label not found, falls back to current way of doing instance id look up now This enhancement allows the ScaleIO plugin to work properly even if the drv_cfg binary is not installed on the kubelet node. **Special Notes** Associated issue - #51537 Closes #51537 ```release-note The ScaleIO volume plugin can now read the SDC GUID value as node label scaleio.sdcGuid; if binary drv_cfg is not installed, the plugin will still work properly; if node label not found, it defaults to drv_cfg if installed. ```
-
Clayton Coleman authored
Currently setting watch cache size for a given resource does not disable the watch cache. This commit adds a new `default-watch-cache-size` flag to map to the existing field, and refactors how watch cache sizes are calculated to bring all of the code into one place. It also adds debug logging to startup to allow us to verify watch cache enablement in production.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix deployment timeout reporting If the previous condition has been a successful rollout then we shouldn't try to estimate any progress. Scenario: * progressDeadlineSeconds is smaller than the difference between now and the time the last rollout finished in the past. * the creation of a new ReplicaSet triggers a resync of the Deployment prior to the cached copy of the Deployment getting updated with the status.condition that indicates the creation of the new ReplicaSet. The Deployment will be resynced and eventually its Progressing condition will catch up with the state of the world. Fixes https://github.com/kubernetes/kubernetes/issues/49637 I will also cherry-pick this back to 1.7. **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51900, 51782, 52030) Fill in creationtimestamp in audit events **What this PR does / why we need it**: This is fixing null creationtimestamp in audit events. @sttts @crassirostris like we've talked earlier today **Release note**: ```release-note none ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51900, 51782, 52030) A policy with 0 rules should return an error **Which issue this PR fixes** [isuue#51565](https://github.com/kubernetes/kubernetes/issues/51565) **Release note**: ``` An audit policy file with 0 rule returns an error. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 51900, 51782, 52030) apiservers: stratify versioned informer construction The versioned share informer factory has been part of the GenericApiServer config, but its construction depended on other fields of that config (e.g. the loopback client config). Hence, the order of changes to the config mattered. This PR stratifies this by moving the SharedInformerFactory from the generic Config to the CompleteConfig struct. Hence, it is only filled during completion when it is guaranteed that the loopback client config is set. While doing this, the CompletedConfig construction is made more type-safe again, i.e. the use of SkipCompletion() is considereably reduced. This is archieved by splitting the derived apiserver Configs into the GenericConfig and the ExtraConfig part. Then the completion is structural again because CompleteConfig is again of the same structure: generic CompletedConfig and local completed ExtraConfig. Fixes #50661.
-
Michail Kargakis authored
If the previous condition has been a successful rollout then we shouldn't try to estimate any progress. Scenario: * progressDeadlineSeconds is smaller than the difference between now and the time the last rollout finished in the past. * the creation of a new ReplicaSet triggers a resync of the Deployment prior to the cached copy of the Deployment getting updated with the status.condition that indicates the creation of the new ReplicaSet. The Deployment will be resynced and eventually its Progressing condition will catch up with the state of the world. Signed-off-by:Michail Kargakis <mkargaki@redhat.com>
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add bskiba to cluster-autoscaler config owners Bskiba is a member of the Autoscaling team @ Google.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Bump cluster autoscaler to 0.7.0-alpha3 After adding an extra field to `etc/gce.conf` CA stopped starting properly. After this change CI test suite should become more green.
-
Seth Jennings authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix pointer receivers handling in unstructured converter **What this PR does / why we need it**: Fixes unstructured converter to properly handle types that have `MarshalJSON()` implemented with a pointer receiver. In particular the converter now can roundtrip `*Unstructured` type. **Which issue this PR fixes**: Fixes #47889. Similar to #43346. **Special notes for your reviewer**: Without the fix the tests are failing: ```console make test WHAT=./vendor/k8s.io/apimachinery/pkg/conversion/unstructured Running tests for APIVersion: v1,admissionregistration.k8s.io/v1alpha1,admission.k8s.io/v1alpha1,apps/v1beta1,apps/v1beta2,authentication.k8s.io/v1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1,authorization.k8s.io/v1beta1,autoscaling/v1,autoscaling/v2alpha1,batch/v1,batch/v1beta1,batch/v2alpha1,certificates.k8s.io/v1beta1,extensions/v1beta1,imagepolicy.k8s.io/v1alpha1,networking.k8s.io/v1,policy/v1beta1,rbac.authorization.k8s.io/v1,rbac.authorization.k8s.io/v1beta1,rbac.authorization.k8s.io/v1alpha1,scheduling.k8s.io/v1alpha1,settings.k8s.io/v1alpha1,storage.k8s.io/v1beta1,storage.k8s.io/v1,,federation/v1beta1 +++ [0829 16:39:36] Running tests without code coverage --- FAIL: TestCustomToUnstructured (0.00s) --- FAIL: TestCustomToUnstructured/false (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: bool(false) actual: map[string]interface {}(map[string]interface {}{"data":"ZmFsc2U="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/[1] (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: []interface {}([]interface {}{1}) actual: map[string]interface {}(map[string]interface {}{"data":"WzFd"}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/true (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: bool(true) actual: map[string]interface {}(map[string]interface {}{"data":"dHJ1ZQ=="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/0 (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: int64(0) actual: map[string]interface {}(map[string]interface {}{"data":"MA=="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/null (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: <nil>(<nil>) actual: map[string]interface {}(map[string]interface {}{"data":"bnVsbA=="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/[] (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: []interface {}([]interface {}{}) actual: map[string]interface {}(map[string]interface {}{"data":"W10="}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/{"a":1} (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: map[string]interface {}{"a":1} actual: map[string]interface {}{"data":"eyJhIjoxfQ=="} Diff: --- Expected +++ Actual @@ -1,3 +1,3 @@ (map[string]interface {}) (len=1) { - (string) (len=1) "a": (int64) 1 + (string) (len=4) "data": (string) (len=12) "eyJhIjoxfQ==" } Messages: customPointer1 --- FAIL: TestCustomToUnstructured/0.0 (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: float64(0) actual: map[string]interface {}(map[string]interface {}{"data":"MC4w"}) Messages: customPointer1 --- FAIL: TestCustomToUnstructured/{} (0.00s) Error Trace: converter_test.go:500 Error: Not equal: expected: map[string]interface {}{} actual: map[string]interface {}{"data":"e30="} Diff: --- Expected +++ Actual @@ -1,2 +1,3 @@ -(map[string]interface {}) { +(map[string]interface {}) (len=1) { + (string) (len=4) "data": (string) (len=4) "e30=" } Messages: customPointer1 --- FAIL: TestCustomToUnstructuredTopLevel (0.00s) --- FAIL: TestCustomToUnstructuredTopLevel/1 (0.00s) Error Trace: converter_test.go:519 Error: Not equal: expected: map[string]interface {}{"a":1} actual: map[string]interface {}{"data":"eyJhIjoxfQ=="} Diff: --- Expected +++ Actual @@ -1,3 +1,3 @@ (map[string]interface {}) (len=1) { - (string) (len=1) "a": (int64) 1 + (string) (len=4) "data": (string) (len=12) "eyJhIjoxfQ==" } FAIL FAIL k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/conversion/unstructured 0.047s make: *** [test] Error 1 ``` ```console make test WHAT=./vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured Running tests for APIVersion: v1,admissionregistration.k8s.io/v1alpha1,admission.k8s.io/v1alpha1,apps/v1beta1,apps/v1beta2,authentication.k8s.io/v1,authentication.k8s.io/v1beta1,authorization.k8s.io/v1,authorization.k8s.io/v1beta1,autoscaling/v1,autoscaling/v2alpha1,batch/v1,batch/v1beta1,batch/v2alpha1,certificates.k8s.io/v1beta1,extensions/v1beta1,imagepolicy.k8s.io/v1alpha1,networking.k8s.io/v1,policy/v1beta1,rbac.authorization.k8s.io/v1,rbac.authorization.k8s.io/v1beta1,rbac.authorization.k8s.io/v1alpha1,scheduling.k8s.io/v1alpha1,settings.k8s.io/v1alpha1,storage.k8s.io/v1beta1,storage.k8s.io/v1,,federation/v1beta1 +++ [0829 16:40:38] Running tests without code coverage --- FAIL: TestConversionRoundtrip (0.00s) unstructured_test.go:111: FromUnstructured failed: Object 'Kind' is missing in '{"object":{"apiVersion":"v1","kind":"Foo","metadata":{"name":"foo1"}}}' FAIL FAIL k8s.io/kubernetes/vendor/k8s.io/apimachinery/pkg/apis/meta/v1/unstructured 0.046s make: *** [test] Error 1 ``` **Release note**: ```release-note NONE ``` /kind bug /sig api-machinery -
Marcin Wielgus authored
-
Maciej Szulik authored
-
Marcin Wielgus authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Dr. Stefan Schimanski authored
-
Chao Wang authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52091, 52071) Log a warning when --audit-policy-file not passed to apiserver When audit backend provided, but --audit-policy-file is not passed, leave a info in log. **Release note**: ``` Log a warning when --audit-policy-file not passed to apiserver ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 52091, 52071) Bugfix: Improve how JobController use queue for backoff **What this PR does / why we need it**: In some cases, the backoff delay for a given Job is reset unnecessarily. the PR improves how JobController uses queue for backoff: - Centralize the key "forget" and "re-queue" process in only on method. - Change the signature of the syncJob method in order to return the information if it is necessary to forget the backoff delay for a given key. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Links to #51153 **Special notes for your reviewer**: **Release note**: ```release-note ```
-
Mikhail Mazurskiy authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix format of forbidden messages **What this PR does / why we need it**: **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #51813 **Special notes for your reviewer**: /assign @deads2k @liggitt **Release note**: ```release-note None ```
-
Kevin authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 48552, 51876) Disable default paging in list watches For 1.8 this will be off by default. In 1.9 it will be on by default. Add tests and rename some fields to use the `chunking` terminology. Note that the pager may be used for other things besides chunking. Follow on to #48921, we left the field on to get some exercise in the normal code paths, but needs to be disabled for 1.8. @liggitt let's merge on wednesday.
-
Cao Shufeng authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Multiarch support for pets images **What this PR does / why we need it**: This PR is for multiarch support for pets image **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #52133 **Special notes for your reviewer**: Copied over the `contrib/pets/peer-finder` as this one is heavily used in many docker images under `test/images`. After this PR I'll submit the PR in contrib project to remove it. **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue GCE: Bubble IP reservation error to the user when the address is specified. This PR improves the debug-ability of internal load balancers when an IP fails to be reserved. I'm mostly worried about the case when the subnetwork URL is wrong or referencing a shared network from another project which isn't yet supported. As you can see from line 160, I had originally planned to surface the reservation error, but printed the wrong error. **Special notes for your reviewer**: /assign @yujuhong Please apply 1.8 milestone. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Pipe in upgrade image target for kube-proxy migration tests **What this PR does / why we need it**: https://k8s-testgrid.appspot.com/sig-network#gci-gce-latest-upgrade-kube-proxy-ds&width=20 and https://k8s-testgrid.appspot.com/sig-network#gci-gce-latest-downgrade-kube-proxy-ds&width=20 are still failing. Reproduced it locally and found node image is being default to debian during upgrade (it was gci before upgrade) because we don't pass in `gci` via `--upgrade--target`. And for some reasons (haven't figured out yet), the upgraded node uses debian image with gci startupscripts... This PR pipes in `--upgrade-target` for kube-proxy migration tests, hopefully in conjunction with https://github.com/kubernetes/test-infra/pull/4447 it will bring the tests back to normal. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #NONE **Special notes for your reviewer**: Sorry for bothering again. /assign @krousey **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Revert update vendor kube-openapi Revert https://github.com/kubernetes/kubernetes/pull/51762 since https://github.com/kubernetes/kubernetes/pull/51321 are not going to get in this release. Will revert https://github.com/kubernetes/kube-openapi/pull/10 after this PR merged. fixes: #52135 ```release-note NONE ``` /assign @apelisse @liggitt
-