- 31 Jul, 2017 2 commits
-
-
https://github.com/kubernetes/kubernetes/issues/49728wulihua authored
Let user choose ADVERTISE_ADDRESS in case the apiserver heuristic for the external address is broken
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue fix invalid issue link in api conversion **What this PR does / why we need it**: When working on #49336, found invalid link `https://github.com/kubernetes/kubernetextensionsssues/39865`. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: cc @janetkuo **Release note**: ```release-note None ```
-
- 30 Jul, 2017 3 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49533, 49264) Add test items for pdb describe **What this PR does / why we need it**: Add test items for pdb describe **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # NONE **Special notes for your reviewer**: ref: #49362 **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49533, 49264) rename stop.go to delete.go to avoid confusion **What this PR does / why we need it**: Refer to [comments](https://github.com/kubernetes/kubernetes/pull/46784#issuecomment-317582927) from @foxish and @janetkuo **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # xref #46784 **Special notes for your reviewer**: /cc @janetkuo @foxish **Release note**: ```release-note rename stop.go file to delete.go to avoid confusion ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Adding option to set the federation api server port if nodeport is set **What this PR does / why we need it**: Kubefed will deploy the respected services and then it will do a health check. Prior to this patch if the user selects the nodeport a random port is opened. In environments where firewalls are in place this random port selection will cause the health check to fail. With this patch we enable users to designate a specific port, after for example opening it on their firewall. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46021 **Special notes for your reviewer**: **Release note**: ``` Kubefed init allows for setting port in Nodeport configuration ```
-
- 29 Jul, 2017 6 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49538, 49708, 47665, 49750, 49528) Add ext4 and xfs tests to GCE PD basic mount tests **What this PR does / why we need it**: Add ext4 and xfs to basic GCE PD mount tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49511 **Special notes for your reviewer**: **Release note**: /release-note-none /sig storage
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49538, 49708, 47665, 49750, 49528) Lowercases hostname for kubeadm cert slice **What this PR does / why we need it**: Previously, unit tests on master were failing due to this error: ``` --- FAIL: TestSubCmdApiServerFlags (0.99s) certs_test.go:149: APIserverCert.DNSNames[0] is danehans-m-c1kp instead of DANEHANS-M-C1KP ``` The PR fixes the TestSubCmdApiServerFlags test, which uses the OS hostname to compare the apiserver serving cert and fails if the OS hostname is in caps. **Which issue this PR fixes**: fixes # https://github.com/kubernetes/kubeadm/issues/361 **Special notes for your reviewer**: **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49538, 49708, 47665, 49750, 49528) Enable garbage collection of custom resources Enhance the garbage collector to periodically refresh the resources it monitors (via discovery) to enable custom resource definition GC (addressing #44507 and reverting #47432). This is a replacement for #46000. /cc @lavalamp @deads2k @sttts @caesarxuchao /ref https://github.com/kubernetes/kubernetes/pull/48065 ```release-note The garbage collector now supports custom APIs added via CustomeResourceDefinition or aggregated apiservers. Note that the garbage collector controller refreshes periodically, so there is a latency between when the API is added and when the garbage collector starts to manage it. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49538, 49708, 47665, 49750, 49528) Add a support for GKE regional clusters in e2e tests. **What this PR does / why we need it**: Add a support for GKE regional clusters in e2e tests. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49538, 49708, 47665, 49750, 49528) Use the core client with version **What this PR does / why we need it**: Replace the **deprecated** `clientSet.Core()` with `clientSet.CoreV1()`. **Which issue this PR fixes**: fixes #49535 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Di Xu authored
-
- 28 Jul, 2017 29 commits
-
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix bug and add log statements to log-dump script
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix Reaper timeout bug This PR is an fix to the issue [noticed](https://github.com/kubernetes/kubernetes/pull/46468#discussion_r118589512) in a previous PR. Previous behavior was to calculate a timeout but then ignore it, using `reaper.timeout` instead. New behavior is to use the calculated timeout for `waitForStatefulSet`, which is passed to the Scaler. Thanks to @foxish and @apelisse for pointing me in the right direction. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49581, 49652, 49681, 49688, 44655) Re-enable federated ingress test that was disabled due to a federated service deletion bug. The details of the bug is described in PR #44626. We believe this bug fixes the flakiness in this test and hence we are re-enabling this test to get some mileage on it. If it turns out to be a problem again we are going to revert this back. **Release note**: ```release-note NONE ``` /assign @csbell cc @kubernetes/sig-federation-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49581, 49652, 49681, 49688, 44655) Don't use cacher if uninitialized Ref #49684
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49581, 49652, 49681, 49688, 44655) kubeadm: use kubelet bootstrap instead of reimplementing @kubernetes/sig-cluster-lifecycle-api-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49581, 49652, 49681, 49688, 44655) Move the audit e2e test out of the node SIG It was mistakenly moved to sig-node in https://github.com/kubernetes/kubernetes/pull/48910, but this is an apiserver feature, not a node feature. /cc @crassirostris
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49581, 49652, 49681, 49688, 44655) Add sig-testing OWNERS_ALIASES /sig testing **What this PR does / why we need it**: follow the sig-foo-{reviewers,approvers} convention - rename test-infra-maintainers to sig-testing-approvers - copy sig-testing-approvers to sig-testing-reviewers - remove inviduals in test/OWNERS in favor of new aliases as a result - rmmh gets test/ approver privileges - spiffxp gets hack/jenkins/ approver privileges **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #49580 **Special notes for your reviewer**: **Release note**: ```release-note NONE ``` -
Shyam Jeedigunta authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue copy OWNERS to k8s.io/api `staging/src/k8s.io/api/OWNERS` is combination of `pkg/api/OWNERS` and `pkg/apis/OWNERS`. Other `OWNERS` files are copied from `pkg/apis/<group_name>/OWNERS`. Since this PR is essentially copying files, so we don't need approval from everyone listed in the OWNERS.
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Fix crd delete nil pointer in example **What this PR does / why we need it**: When error is `IsAlreadyExists`, crd will be nil, then `defer` statement will `nil pointer`. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Add apiserver metric for response sizes Fixes https://github.com/kubernetes/kubernetes/issues/47728 This should help us understand GET/LIST call latencies better. It'll also help catch differences in object sizes across kubemark and real cluster. I'm labelling the metrics by namespace (hoping that there won't be toooo many of them). /cc @smarterclayton @gmarek cc @kubernetes/sig-scalability-misc @kubernetes/sig-api-machinery-misc @lavalamp @wojtek-t
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue Volunteer to review Cinder related code **What this PR does / why we need it**: Since i am currently helping with the OpenStack cloud provider, happy to do the same with cinder package as well as they are related. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49712, 49694, 49714, 49670, 49717) set juju master charm state to blocked if the services appear to be failing **What this PR does / why we need it**: set the juju master charm state to blocked if the services appear to be failing **Release note**: ```release-note set the juju master charm state to blocked if the services appear to be failing ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49712, 49694, 49714, 49670, 49717) FC volume plugin: remove unmount of global mount **What this PR does / why we need it**: The unmount operation for global mount should be done by reconciler.go instead of executing inside the FC Plugin since attacher/detacher for FC plugin was merged recently. **Which issue this PR fixes** : fixes #49669 **Special notes for your reviewer**: **Release note**: ``` NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49712, 49694, 49714, 49670, 49717) Adding old Juju charm maintainers **What this PR does / why we need it**: Update email addresses of past Juju charm maintainers **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: **Special notes for your reviewer**: **Release note**: ```NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49712, 49694, 49714, 49670, 49717) fix arg type error in printf **What this PR does / why we need it**: A value of wrong type is passed as arg to a `Errorf` in `vendor/k8s.io/apimachinery/pkg/fields/selector_test.go`, This PR fixes this problem. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: **Release note**: `NONE`
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49712, 49694, 49714, 49670, 49717) Reduce GC e2e test flakiness Increase GC wait timeout in a flaky e2e test. The test expects a GC operation to be performed within 30s, while in practice the operation often takes longer due to a delay between the enqueueing of the owner's delete operation and the GC's actual processing of that event. Doubling the time seems to stabilize the test. The test's assumptions can be revisited, and the processing delay under load can be investigated in the future. Extracted from https://github.com/kubernetes/kubernetes/pull/47665 per https://github.com/kubernetes/kubernetes/pull/47665#issuecomment-318219099. /cc @sttts @caesarxuchao @deads2k @kubernetes/sig-api-machinery-bugs ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45813, 49594, 49443, 49167, 47539) Deprecate keep-terminated-pod-volumes It was discussed and agreed by sig-storage that this flag causes unnecessary confusion and is hard to keep synchornized with controller's attach/detach functionality. Fixes https://github.com/kubernetes/kubernetes/issues/45615 ```release-note keep-terminated-pod-volumes flag on kubelet is deprecated. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45813, 49594, 49443, 49167, 47539) GCE: Adding unit test for ensureStaticIP **What this PR does / why we need it**: Entry into unit testing GCE loadbalancer code by testing `ensureStaticIP` which had a bug in 1.7.0. @bowei @freehan @MrHohn @dnardo @thockin, any thoughts and comments on how we could unit test LB code moving forward? I think there are many areas we can split functions into smaller ones for easier testing - firewallNeedsUpdate being an example of that. However, it seems to me that we still need to mock our GCP calls for some functions that heavily revolve around API calls. A dream goal would be to have a unit test that can call EnsureLoadBalancer. Now that we have shared resources between different services and ingresses (firewalls, instance groups, [future features]), being able to setup different scenarios without depending on E2E tests would be awesome. However, I'm not sure how reachable that goal would be. Most importantly, let's not make things worse. If you have advice on anti-patterns to avoid, please speak up. ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45813, 49594, 49443, 49167, 47539) Add node e2e tests for GKE environment Ref: https://github.com/kubernetes/kubernetes/issues/46891 This PR adds node e2e tests for validating images used on GKE. - We pass the `SYSTEM_SPEC_NAME` to the node e2e test process via the flag `--system-spec-name` so that we can skip the environment specific tests using `RunIfSystemSpecNameIs()`. - Also added `SkipIfContainerRuntimeIs()` as the opposite of `RunIfContainerRuntimeIs()`. **Release note**: ``` None ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45813, 49594, 49443, 49167, 47539) GCE: Update vendor of gcfg and filter config parsing errors **What this PR does / why we need it**: To utilize new function `FatalOnly` which filters "programmer errors" **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # Fixes #49660 **Special notes for your reviewer**: /assign @bowei **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 45813, 49594, 49443, 49167, 47539) add podsecuritypolicy in kubectl describe command **What this PR does / why we need it**: Describe all fields of podsecuritypolicy ``` # ./cluster/kubectl.sh describe psp restricted Name: restricted Settings: Allow Privileged: false Default Add Capabilities: <none> Required Drop Capabilities: <none> Allowed Capabilities: <none> Allowed Volume Types: emptyDir,secret,downwardAPI,configMap,persistentVolumeClaim,projected Allow Host Network: false Allow Host Ports: <none> Allow Host PID: false Allow Host IPC: false Read Only Root Filesystem: false SELinux Context Strategy: RunAsAny User: <none> Role: <none> Type: <none> Level: <none> Run As User Strategy: MustRunAsNonRoot Ranges: <none> FSGroup Strategy: RunAsAny Ranges: <none> Supplemental Groups Strategy: RunAsAny Ranges: <none> ``` **Which issue this PR fixes**: fixes #43757 **Special notes for your reviewer**: **Release note**: ```release-note kubectl describe podsecuritypolicy describes all fields. ``` -
Dan Mace authored
Enhance the garbage collector to periodically refresh the resources it monitors (via discovery) to enable custom resource definition GC. This implementation caches Unstructured structs for any kinds not covered by a shared informer. The existing meta-only codec only supports compiled types; an improved codec which supports arbitrary types could be introduced to optimize caching to store only metadata for all non-informer types.
-
Harry Zhang authored
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49619, 49598, 47267, 49597, 49638) Remove default binding of system:node role to system:nodes group part of https://github.com/kubernetes/features/issues/279 deprecation of this automatic binding announced in 1.7 in https://github.com/kubernetes/kubernetes/pull/46076 ```release-note RBAC: the `system:node` role is no longer automatically granted to the `system:nodes` group in new clusters. It is recommended that nodes be authorized using the `Node` authorization mode instead. Installations that wish to continue giving all members of the `system:nodes` group the `system:node` role (which grants broad read access, including all secrets and configmaps) must create an installation-specific `ClusterRoleBinding`. ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49619, 49598, 47267, 49597, 49638) improve log for pod deletion poll loop **What this PR does / why we need it**: It improves some logging related to waiting for a pod to reach a passed-in condition. Specifically, related to issue [49529](https://github.com/kubernetes/kubernetes/issues/49529) where better logging may help to debug the root cause. **Release note**: ```release-note NONE ```
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49619, 49598, 47267, 49597, 49638) Flag support in kubectl plugins Adds support to flags in `kubectl` plugins. Flags are declared in the plugin descriptor and are passed to plugins through env vars, similar to global flags (which already works). Fixes https://github.com/kubernetes/kubernetes/issues/49122 **Release note**: ```release-note Added flag support to kubectl plugins ``` PTAL @monopole @kubernetes/sig-cli-pr-reviews
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49619, 49598, 47267, 49597, 49638) Adding metrics support to local volume Adding metrics support to local volume plugin. Fixes #49601
-
Kubernetes Submit Queue authored
Automatic merge from submit-queue (batch tested with PRs 49619, 49598, 47267, 49597, 49638) replicaset fix typo **What this PR does / why we need it**: reopen #47821 **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # **Special notes for your reviewer**: @NickrenREN **Release note**: ```release-note NONE ```
-