1. 13 Feb, 2018 4 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #59773 from nicksardo/glbc-alpha2 · d9086a7a
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 59298, 59773, 59772). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Bump GLBC to 0.9.8-alpha.2 and change back to --verbose
      
      **What this PR does / why we need it**:
      Bumps GLBC version to 0.9.8-alpha.2 which is logically equivalent to 0.9.8-alpha.1 except verbose mode sets v=3 instead of v=4
      
      **Special notes for your reviewer**:
      /cc @rramkumar1 
      /assign @bowei 
      
      **Release note**:
      ```release-note
      NONE
      ```
      d9086a7a
    • Kubernetes Submit Queue's avatar
      Merge pull request #59298 from jpbetz/etcd3-minor-version-rollback · c1216dfd
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 59298, 59773, 59772). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add etcd 3.x minor version rollback support to migrate-if-needed.sh
      
      Provide automatic etcd 3.x minor version downgrade when using the gcr.io/google_containers/etcd docker images to operate etcd.
      
      Uses `etcdctl snapshot save` and `etcdctl snapshot restore` to safely downgrade etcd from 3.2->3.1 or 3.1->3.0. This is safe because the data storage file formats used by etcd have not changed between these versions.
      
      Intended as a stop-gap until we can introduce more comprehensive downgrade support in etcd. The main limitation of this approach is that it is not able to perform zero downtime downgrades for HA clusters.   For HA clusters, all members must be stopped and downgraded before the cluster may be restarted at the downgraded version.
      
      Example usage:
      - Initially the [etcd.manifest](https://github.com/kubernetes/kubernetes/blob/58547ebd72bf314cba26e8d9148db282751e34f2/cluster/gce/manifests/etcd.manifest#L43) is set to gcr.io/google_containers/etcd:3.0.17, TARGET_VERSION=3.0.17
      - A upgrade to 3.1.11 is initiated.
      - etcd.manifest is updated to gcr.io/google_containers/etcd:3.1.11, TARGET_VERSION=3.1.11
      - etcd restarts and establishes 3.1 as it's "cluster version"
      - For whatever reason, a downgrade is initiated
      - etcd.manifest is updated gcr.io/google_containers/etcd:3.1.11, TARGET_VERSION=3.0.17
      - migrate-if-needed.sh detects that the current version (3.1.11) is newer than the target version, so it:
        - creates a snapshot using etcd & etcdctl 3.1.11
        - backs up the data dir
        - restores the snapshot using etcdctl 3.0.17 to create a replacement data dir
        - starts etcd 3.0.17
      
      Note that while this will rollback to an earlier etcd version, the newer etcd gcr.io image version must continue to be used throughout the downgrade. Only TARGET_VERSION is downgraded.
      
      Test coverage was lacking for `migrate-if-needed.sh` so this adds some container level testing to the `Makefile` for migrating and rolling back. This surfaced a couple bugs that are fixed by this PR as well.
      
      cc @mml @lavalamp @wenjiaswe
      
      ```release-note
      Add automatic etcd 3.2->3.1 and 3.1->3.0 minor version rollback support to gcr.io/google_container/etcd images. For HA clusters, all members must be stopped before performing a rollback.
      ```
      c1216dfd
    • Kubernetes Submit Queue's avatar
      Merge pull request #59246 from huangjiuyuan/scheduler/add-tests-for-schedulercache · 821cf923
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue (batch tested with PRs 59479, 59246). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add tests for schedulercache
      
      **What this PR does / why we need it**:
      Add tests for `node_info.go` under `schedulercache` package.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```
      NONE
      ```
      821cf923
    • Kubernetes Submit Queue's avatar
      Merge pull request #59479 from tossmilestone/avoid-ecahe-update-race · ab2e1cb0
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Avoid race condition when updating equivalence cache
      
      **What this PR does / why we need it**:
      Lock the ecache to update the ecache on each predicate running, to avoid race condition.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fix #58507 
      
      **Special notes for your reviewer**:
      None
      
      **Release note**:
      
      ```release-note
      None
      ```
      ab2e1cb0
  2. 12 Feb, 2018 20 commits
  3. 11 Feb, 2018 16 commits
    • Kubernetes Submit Queue's avatar
      Merge pull request #58737 from NickrenREN/fix-scheduler-ephemeral-storage · 74089bc4
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Subtract local ephemeral storage resource from NodeInfo when removing pod
      
      **What this PR does / why we need it**:
      When we are removing pods, we need to subtract local ephemeral storage resource from NodeInfo
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      ```release-note
      NONE
      ```
      
      /kind bug
      /sig storage
      /sig scheduling
      
      /assign @jingxu97  @bsalamat
      74089bc4
    • Mike Wilson's avatar
      15530c09
    • Kubernetes Submit Queue's avatar
      Merge pull request #58960 from rosti/kubeadm-imagepullpolicy · 19829a24
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      kubeadm: imagePullPolicy option in init config
      
      **What this PR does / why we need it**:
      This PR adds `imagePullPolicy` option to the `kubeadm init` configuration file.
      
      The new `imagePullPolicy` option is forwarded to the generated kubelet static pods for etcd, kube-apiserver, kube-controller-manager and kube-scheduler. This option allows for precise image pull policy specification for master nodes and thus for more tight control over images. It is useful in CI environments and in environments, where the user has total control over master VM templates (thus, the master VM templates can be preloaded with the required Docker images for the control plane services).
      
      **Special notes for your reviewer**:
      
      /cc @kubernetes/sig-cluster-lifecycle-pr-reviews
      /area kubeadm
      /assign @luxas
      
      **Release note**:
      
      ```release-note
      kubeadm: New "imagePullPolicy" option in the init configuration file, that gets forwarded to kubelet static pods to control pull policy for etcd and control plane images.
      ```
      19829a24
    • Kubernetes Submit Queue's avatar
      Merge pull request #56557 from andyzhangx/azurefile-createaccount · cfa67745
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix the create azure file pvc failure if there is no storage account in current resource group
      
      **What this PR does / why we need it**:
      When create an azure file PVC, there will be error if there is no storage account in current resource group.
      With this PR, a storage account will be created if there is no storage account in current resource group.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #56556
      
      **Special notes for your reviewer**:
      1. rephrase the code logic of `CreateFileShare` func.
      ```
      if accountName is empty, then 
          find a storage account that matches accountType
          if no storage account found, then
              create a new account
      else
          we only use user specified storage account
      
      create a file share according to found storage account
      ```
      2. Use func `getStorageAccountName` to get a unique storage account name by UUID, a storage account for azure file would be like `f0b2b0bd40c010112e897fa`. And in next PR, I will use this function to create storage account for azure disk, the storage account for azure disk would be like `d8f3ad8ad92000f1e1e88bd`.
      
      **Release note**:
      
      ```
      fix the create azure file pvc failure if there is no storage account in current resource group
      ```
      /sig azure
      /assign @rootfs
      cfa67745
    • andyzhangx's avatar
      create storage account if necessary when create azure file pvc · aa21bef6
      andyzhangx authored
      use new storage account name generation method
      
      use uuid to generate account name
      
      change azure file account prefix
      
      use uniqueID to generate a storage account name
      
      fix comments
      
      fix comments
      
      fix comments
      
      fix a storage account matching bug
      
      only use UUID in getStorageAccountName func
      
      use shorter storage account prefix for azure file
      
      fix comments
      
      fix comments
      
      fix comments
      
      fix rebase build error
      
      rewrite CreateFileShare code logic
      
      fix gofmt issue
      
      fix test error
      
      fix comments
      
      fix a location matching bug
      aa21bef6
    • Kubernetes Submit Queue's avatar
      Merge pull request #59464 from dixudx/fix_all_typos · 317853c9
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      fix all the typos across the project
      
      **What this PR does / why we need it**:
      There are lots of typos across the project. We should avoid small PRs on fixing those annoying typos, which is time-consuming and low efficient.
      
      This PR does fix all the typos across the project currently. And with #59463, typos could be avoided when a new PR gets merged.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      /sig testing
      /area test-infra
      /sig release
      /cc @ixdy 
      /assign @fejta 
      
      **Release note**:
      
      ```release-note
      None
      ```
      317853c9
    • Kubernetes Submit Queue's avatar
      Merge pull request #59715 from dims/switch-FengyunPan-id-to-FengyunPan2 · 21eff150
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      New github id - FengyunPan -> FengyunPan2
      
      PanFengyun <pan_feng_yun@163.com>'s previous github id was @FengyunPan
      
      Due to some problem with github, he lost access to @FengyunPan and
      is not using @FengyunPan2. So let's switch over to the new id. Github
      has promised to release the previous id back in 6 months, so we may
      have to switch it back later.
      
      
      
      **What this PR does / why we need it**:
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes #
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      21eff150
    • Kubernetes Submit Queue's avatar
      Merge pull request #58364 from stewart-yu/fixiptableError · da8b79ec
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      [kube-proxy]fix bad error message in kube-proxy.log when run cluster in local
      
      **What this PR does / why we need it**:
      When run `hack/local-up-cluster.sh` in local with `iptable` proxymode, we can see `/tmp/kube-proxy.log ` include some error messages, like that:
      ```shell
      E0117 09:10:45.720142  108141 proxier.go:863] Error deleting dummy device kube-ipvs0 created by IPVS proxier: error deleting a non-exist dummy device: kube-ipvs0
      E0117 09:10:45.729617  108141 proxier.go:838] Failed to execute iptables-restore for nat: exit status 1 (iptables-restore: line 7 failed
      )
      E0117 09:10:45.730508  108141 proxier.go:876] Error removing ipset KUBE-LOOP-BACK, error: error destroying set KUBE-LOOP-BACK:, error: exit status 1
      E0117 09:10:45.731329  108141 proxier.go:876] Error removing ipset KUBE-CLUSTER-IP, error: error destroying set KUBE-CLUSTER-IP:, error: exit status 1
      E0117 09:10:45.732100  108141 proxier.go:876] Error removing ipset KUBE-LOAD-BALANCER, error: error destroying set KUBE-LOAD-BALANCER:, error: exit status 1
      E0117 09:10:45.732855  108141 proxier.go:876] Error removing ipset KUBE-NODE-PORT-TCP, error: error destroying set KUBE-NODE-PORT-TCP:, error: exit status 1
      E0117 09:10:45.735082  108141 proxier.go:876] Error removing ipset KUBE-NODE-PORT-UDP, error: error destroying set KUBE-NODE-PORT-UDP:, error: exit status 1
      E0117 09:10:45.735829  108141 proxier.go:876] Error removing ipset KUBE-EXTERNAL-IP, error: error destroying set KUBE-EXTERNAL-IP:, error: exit status 1
      E0117 09:10:45.736619  108141 proxier.go:876] Error removing ipset KUBE-LOAD-BALANCER-SOURCE-IP, error: error destroying set KUBE-LOAD-BALANCER-SOURCE-IP:, error: exit status 1
      E0117 09:10:45.737360  108141 proxier.go:876] Error removing ipset KUBE-LOAD-BALANCER-SOURCE-CIDR, error: error destroying set KUBE-LOAD-BALANCER-SOURCE-CIDR:, error: exit status 1
      E0117 09:10:45.738114  108141 proxier.go:876] Error removing ipset KUBE-LOAD-BALANCER-MASQ, error: error destroying set KUBE-LOAD-BALANCER-MASQ:, error: exit status 1
      ```
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Fixes [https://github.com/kubernetes/kubernetes/issues/58366](https://github.com/kubernetes/kubernetes/issues/58366)
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      NONE
      ```
      da8b79ec
    • Kubernetes Submit Queue's avatar
      Merge pull request #59234 from nikhiljindal/kubemcie2e · 98860f03
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Adding kubemci e2e test for ingress spec conformance
      
      **What this PR does / why we need it**:
      Adding an e2e test case for kubemci to verify that it conforms to the ingress spec.
      Not all tests will pass right now, but adding it will enable us to track the latest status.
      
      ```release-note
      NONE
      ```
      98860f03
    • Davanum Srinivas's avatar
      New github id - FengyunPan -> FengyunPan2 · 7ef4f207
      Davanum Srinivas authored
      PanFengyun <pan_feng_yun@163.com>'s previous github id was @FengyunPan
      
      Due to some problem with github, he lost access to @FengyunPan and
      is not using @FengyunPan2. So let's switch over to the new id. Github
      has promised to release the previous id back in 6 months, so we may
      have to switch it back later.
      7ef4f207
    • Pengfei Ni's avatar
      Adjust unit tests for vmss · f32bd6a0
      Pengfei Ni authored
      f32bd6a0
    • Pengfei Ni's avatar
      Use generic cache for vmss · 4d5e7b7c
      Pengfei Ni authored
      4d5e7b7c
    • Kubernetes Submit Queue's avatar
      Merge pull request #59520 from feiskyer/new-cache · f0e573d6
      Kubernetes Submit Queue authored
      Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.
      
      Add generic cache for Azure VM/LB/NSG/RouteTable
      
      **What this PR does / why we need it**:
      
      Part of #58770. This PR adds a generic cache of Azure VM/LB/NSG/RouteTable for reducing ARM calls.
      
      **Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:
      Part of #58770
      
      **Special notes for your reviewer**:
      
      **Release note**:
      
      ```release-note
      Add generic cache for Azure VM/LB/NSG/RouteTable
      ```
      f0e573d6
    • Di Xu's avatar
      auto-generated · 521146e6
      Di Xu authored
      521146e6
    • Di Xu's avatar
      fix all the typos across the project · 48388fec
      Di Xu authored
      48388fec
    • stewart-yu's avatar